kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Subject: Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'?
Date: Tue, 5 May 2020 16:50:13 +0200	[thread overview]
Message-ID: <7dea2810-85cf-0892-20a8-bba3e3a2c133@redhat.com> (raw)
In-Reply-To: <202005052221.83QerHmG%lkp@intel.com>

On 05.05.20 16:15, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
> head:   da1742791d8c0c0a8e5471f181549c4726a5c5f9
> commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug
> config: x86_64-randconfig-b002-20200505 (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
>         git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe':
>>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration]
>      vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>                        ^~~~~~~
>                        vzalloc
>>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>      vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL);
>                      ^
>>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration]
>      kfree(vm);
>      ^~~~~
>      vfree
>    cc1: some warnings being treated as errors
> 
> vim +1375 drivers/virtio/virtio_mem.c

Guess we simply need

 #include <linux/slab.h>

to make it work for that config.

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2020-05-05 14:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 14:15 [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? kbuild test robot
2020-05-05 14:50 ` David Hildenbrand [this message]
2020-05-05 15:44   ` Michael S. Tsirkin
2020-05-05 15:46     ` David Hildenbrand
2020-05-05 16:20       ` Michael S. Tsirkin
2020-05-05 16:22         ` David Hildenbrand
2020-05-05 16:30           ` Michael S. Tsirkin
2020-05-06 20:28           ` Michael S. Tsirkin
2020-05-06 20:32             ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dea2810-85cf-0892-20a8-bba3e3a2c133@redhat.com \
    --to=david@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).