[PATCH kvm-unit-tests] port80: remove test

[PATCH kvm-unit-tests] port80: remove test

[Paolo Bonzini]

KVM has not passed port 0x80 directly to the hardware for three years
(commit d59d51f08801, "KVM: VMX: remove I/O port 0x80 bypass on Intel
hosts", 2017-12-05) so the port80 test is a useless duplicate of the
outl_to_pmtimer vmexit test, without the reporting of how long the
access takes and without adaptive choice of the number of iterations.
Remove it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 x86/Makefile.common |  2 +-
 x86/README          |  1 -
 x86/port80.c        | 12 ------------
 x86/unittests.cfg   |  3 ---
 4 files changed, 1 insertion(+), 17 deletions(-)
 delete mode 100644 x86/port80.c

diff --git a/x86/Makefile.common b/x86/Makefile.common
index b942086..55f7f28 100644
--- a/x86/Makefile.common
+++ b/x86/Makefile.common
@@ -53,7 +53,7 @@ FLATLIBS = lib/libcflat.a $(libgcc)
 	@chmod a-x $@
 
 tests-common = $(TEST_DIR)/vmexit.flat $(TEST_DIR)/tsc.flat \
-               $(TEST_DIR)/smptest.flat  $(TEST_DIR)/port80.flat \
+               $(TEST_DIR)/smptest.flat  \
                $(TEST_DIR)/realmode.flat $(TEST_DIR)/msr.flat \
                $(TEST_DIR)/hypercall.flat $(TEST_DIR)/sieve.flat \
                $(TEST_DIR)/kvmclock_test.flat  $(TEST_DIR)/eventinj.flat \
diff --git a/x86/README b/x86/README
index 218fe1a..8b0b118 100644
--- a/x86/README
+++ b/x86/README
@@ -27,7 +27,6 @@ Tests in this directory and what they do:
  emulator:	move to/from regs, cmps, push, pop, to/from cr8, smsw and lmsw
  hypercall:	intel and amd hypercall insn
  msr:		write to msr (only KERNEL_GS_BASE for now)
- port80:	lots of out to port 80
  realmode:	goes back to realmode, shld, push/pop, mov immediate, cmp
 		immediate, add immediate, io, eflags instructions
 		(clc, cli, etc.), jcc short, jcc near, call, long jmp, xchg
diff --git a/x86/port80.c b/x86/port80.c
deleted file mode 100644
index 791431c..0000000
--- a/x86/port80.c
+++ /dev/null
@@ -1,12 +0,0 @@
-#include "libcflat.h"
-
-int main(void)
-{
-    int i;
-
-    printf("begining port 0x80 write test\n");
-    for (i = 0; i < 10000000; ++i)
-	asm volatile("outb %al, $0x80");
-    printf("done\n");
-    return 0;
-}
diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index c035c79..b48c98b 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -175,9 +175,6 @@ extra_params = -machine vmport=on -cpu host
 check = /sys/module/kvm/parameters/enable_vmware_backdoor=Y
 arch = x86_64
 
-[port80]
-file = port80.flat
-
 [realmode]
 file = realmode.flat
 
-- 
2.26.2

Re: [PATCH kvm-unit-tests] port80: remove test

[Jim Mattson]

On Sat, Oct 31, 2020 at 7:49 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> KVM has not passed port 0x80 directly to the hardware for three years
> (commit d59d51f08801, "KVM: VMX: remove I/O port 0x80 bypass on Intel
> hosts", 2017-12-05) so the port80 test is a useless duplicate of the
> outl_to_pmtimer vmexit test, without the reporting of how long the
> access takes and without adaptive choice of the number of iterations.
> Remove it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Jim Mattson <jmattson@google.com>