From: Andrew Jones <drjones@redhat.com>
To: Ben Gardon <bgardon@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
Peter Shier <pshier@google.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Thomas Huth <thuth@redhat.com>, Peter Feiner <pfeiner@google.com>
Subject: Re: [PATCH v2 1/5] KVM: selftests: Remove address rounding in guest code
Date: Wed, 4 Nov 2020 11:54:50 +0100 [thread overview]
Message-ID: <20201104105450.t2frosra4mvixrwi@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20201103234952.1626730-2-bgardon@google.com>
On Tue, Nov 03, 2020 at 03:49:48PM -0800, Ben Gardon wrote:
> Rounding the address the guest writes to a host page boundary
> will only have an effect if the host page size is larger than the guest
> page size, but in that case the guest write would still go to the same
> host page. There's no reason to round the address down, so remove the
> rounding to simplify the demand paging test.
>
> Signed-off-by: Ben Gardon <bgardon@google.com>
> ---
> tools/testing/selftests/kvm/demand_paging_test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c
> index 360cd3ea4cd67..32a42eafc6b5c 100644
> --- a/tools/testing/selftests/kvm/demand_paging_test.c
> +++ b/tools/testing/selftests/kvm/demand_paging_test.c
> @@ -103,7 +103,6 @@ static void guest_code(uint32_t vcpu_id)
> for (i = 0; i < pages; i++) {
> uint64_t addr = gva + (i * guest_page_size);
>
> - addr &= ~(host_page_size - 1);
> *(uint64_t *)addr = 0x0123456789ABCDEF;
> }
>
> --
> 2.29.1.341.ge80a0c044ae-goog
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2020-11-04 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 23:49 [PATCH v2 0/5] Add a dirty logging performance test Ben Gardon
2020-11-03 23:49 ` [PATCH v2 1/5] KVM: selftests: Remove address rounding in guest code Ben Gardon
2020-11-04 10:54 ` Andrew Jones [this message]
2020-11-03 23:49 ` [PATCH v2 2/5] KVM: selftests: Factor code out of demand_paging_test Ben Gardon
2020-11-04 12:16 ` Andrew Jones
2020-11-04 15:00 ` Peter Xu
2020-11-04 15:28 ` Andrew Jones
2020-11-04 17:01 ` Ben Gardon
2020-11-03 23:49 ` [PATCH v2 3/5] KVM: selftests: Simplify demand_paging_test with timespec_diff_now Ben Gardon
2020-11-03 23:49 ` [PATCH v2 4/5] KVM: selftests: Add wrfract to common guest code Ben Gardon
2020-11-03 23:49 ` [PATCH v2 5/5] KVM: selftests: Introduce the dirty log perf test Ben Gardon
2020-11-11 12:34 ` [PATCH v2 0/5] Add a dirty logging performance test Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104105450.t2frosra4mvixrwi@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=bgardon@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pfeiner@google.com \
--cc=pshier@google.com \
--cc=sean.j.christopherson@intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).