* [PATCH -next] s390/protvirt: fix error return code in uv_info_init()
@ 2021-04-07 12:38 zhongbaisong
2021-04-07 12:45 ` weiyongjun (A)
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: zhongbaisong @ 2021-04-07 12:38 UTC (permalink / raw)
To: Christian Borntraeger, Janosch Frank, Vasily Gorbik, Heiko Carstens
Cc: kvm, linux-s390, kernel-janitors, zhongbaisong
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
---
arch/s390/kernel/uv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index cbfbeab57c3b..370f664580af 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -460,8 +460,10 @@ static int __init uv_info_init(void)
goto out_kobj;
uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
- if (!uv_query_kset)
+ if (!uv_query_kset) {
+ rc = -ENOMEM;
goto out_ind_files;
+ }
rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
if (!rc)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/protvirt: fix error return code in uv_info_init()
2021-04-07 12:38 [PATCH -next] s390/protvirt: fix error return code in uv_info_init() zhongbaisong
@ 2021-04-07 12:45 ` weiyongjun (A)
2021-04-07 12:48 ` weiyongjun (A)
2021-04-13 14:15 ` Dan Carpenter
2 siblings, 0 replies; 5+ messages in thread
From: weiyongjun (A) @ 2021-04-07 12:45 UTC (permalink / raw)
To: zhongbaisong, Christian Borntraeger, Janosch Frank,
Vasily Gorbik, Heiko Carstens
Cc: kvm, linux-s390, kernel-janitors
格式不对，不要用outlook发
在 2021/4/7 20:38, zhongbaisong 写道:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> ---
> arch/s390/kernel/uv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index cbfbeab57c3b..370f664580af 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
> goto out_kobj;
>
> uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> - if (!uv_query_kset)
> + if (!uv_query_kset) {
> + rc = -ENOMEM;
> goto out_ind_files;
> + }
>
> rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
> if (!rc)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/protvirt: fix error return code in uv_info_init()
2021-04-07 12:38 [PATCH -next] s390/protvirt: fix error return code in uv_info_init() zhongbaisong
2021-04-07 12:45 ` weiyongjun (A)
@ 2021-04-07 12:48 ` weiyongjun (A)
2021-04-07 13:06 ` Heiko Carstens
2021-04-13 14:15 ` Dan Carpenter
2 siblings, 1 reply; 5+ messages in thread
From: weiyongjun (A) @ 2021-04-07 12:48 UTC (permalink / raw)
To: zhongbaisong, Christian Borntraeger, Janosch Frank,
Vasily Gorbik, Heiko Carstens
Cc: kvm, linux-s390, kernel-janitors
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> ---
> arch/s390/kernel/uv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index cbfbeab57c3b..370f664580af 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
> goto out_kobj;
>
> uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> - if (!uv_query_kset)
> + if (!uv_query_kset) {
> + rc = -ENOMEM;
> goto out_ind_files;
> + }
Your patch is corrupted, please resend with correct format.
>
> rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
> if (!rc)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/protvirt: fix error return code in uv_info_init()
2021-04-07 12:48 ` weiyongjun (A)
@ 2021-04-07 13:06 ` Heiko Carstens
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Carstens @ 2021-04-07 13:06 UTC (permalink / raw)
To: weiyongjun (A)
Cc: zhongbaisong, Christian Borntraeger, Janosch Frank,
Vasily Gorbik, kvm, linux-s390, kernel-janitors
On Wed, Apr 07, 2021 at 08:48:19PM +0800, weiyongjun (A) wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> > ---
> > arch/s390/kernel/uv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> > index cbfbeab57c3b..370f664580af 100644
> > --- a/arch/s390/kernel/uv.c
> > +++ b/arch/s390/kernel/uv.c
> > @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
> > goto out_kobj;
> >
> > uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> > - if (!uv_query_kset)
> > + if (!uv_query_kset) {
> > + rc = -ENOMEM;
> > goto out_ind_files;
> > + }
>
> Your patch is corrupted, please resend with correct format.
Fixed up, and applied anyway. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/protvirt: fix error return code in uv_info_init()
2021-04-07 12:38 [PATCH -next] s390/protvirt: fix error return code in uv_info_init() zhongbaisong
2021-04-07 12:45 ` weiyongjun (A)
2021-04-07 12:48 ` weiyongjun (A)
@ 2021-04-13 14:15 ` Dan Carpenter
2 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-04-13 14:15 UTC (permalink / raw)
To: zhongbaisong
Cc: Christian Borntraeger, Janosch Frank, Vasily Gorbik,
Heiko Carstens, kvm, linux-s390, kernel-janitors
On Wed, Apr 07, 2021 at 08:38:55PM +0800, zhongbaisong wrote:
^^^^^^^^^^^^
Heiko Carstens already fixed and applied the patch but it's best to fix
this From line so it says "Baisong Zhong" like your Signed-off-by line.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-13 14:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-07 12:38 [PATCH -next] s390/protvirt: fix error return code in uv_info_init() zhongbaisong
2021-04-07 12:45 ` weiyongjun (A)
2021-04-07 12:48 ` weiyongjun (A)
2021-04-07 13:06 ` Heiko Carstens
2021-04-13 14:15 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).