[kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Alex Bennée]

Hi,

Sorry this has been sitting in my tree so long. The changes are fairly
minor from v2. I no longer split the tests up into TCG and KVM
versions and instead just ensure that ERRATA_FORCE is always set when
run under TCG.

Alex Bennée (3):
  arm64: remove invalid check from its-trigger test
  arm64: enable its-migration tests for TCG
  arch-run: do not process ERRATA when running under TCG

 scripts/arch-run.bash |  4 +++-
 arm/gic.c             | 16 ++++++----------
 arm/unittests.cfg     |  3 ---
 3 files changed, 9 insertions(+), 14 deletions(-)

-- 
2.30.2

[kvm-unit-tests PATCH v3 1/3] arm64: remove invalid check from its-trigger test

[Alex Bennée]

While an IRQ is not "guaranteed to be visible until an appropriate
invalidation" it doesn't stop the actual implementation delivering it
earlier if it wants to. This is the case for QEMU's TCG and as tests
should only be checking architectural compliance this check is
invalid.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Cc: Shashi Mallela <shashi.mallela@linaro.org>
Message-Id: <20210525172628.2088-2-alex.bennee@linaro.org>

---
v3
  - reflow the comment, drop "willingly do not call" as per Eric's suggestion
---
 arm/gic.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/arm/gic.c b/arm/gic.c
index 98135ef..1e3ea80 100644
--- a/arm/gic.c
+++ b/arm/gic.c
@@ -732,21 +732,17 @@ static void test_its_trigger(void)
 			"dev2/eventid=20 does not trigger any LPI");
 
 	/*
-	 * re-enable the LPI but willingly do not call invall
-	 * so the change in config is not taken into account.
-	 * The LPI should not hit
+	 * re-enable the LPI. While "A change to the LPI configuration
+	 * is not guaranteed to be visible until an appropriate
+	 * invalidation operation has completed" hardware that doesn't
+	 * implement caches may have delivered the event at any point
+	 * after the enabling. Check the LPI has hit by the time the
+	 * invall is done.
 	 */
 	gicv3_lpi_set_config(8195, LPI_PROP_DEFAULT);
 	stats_reset();
 	cpumask_clear(&mask);
 	its_send_int(dev2, 20);
-	wait_for_interrupts(&mask);
-	report(check_acked(&mask, -1, -1),
-			"dev2/eventid=20 still does not trigger any LPI");
-
-	/* Now call the invall and check the LPI hits */
-	stats_reset();
-	cpumask_clear(&mask);
 	cpumask_set_cpu(3, &mask);
 	its_send_invall(col3);
 	wait_for_interrupts(&mask);
-- 
2.30.2

[kvm-unit-tests PATCH v3 2/3] arm64: enable its-migration tests for TCG

[Alex Bennée]

With the support for TCG emulated GIC we can also test these now.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Cc: Shashi Mallela <shashi.mallela@linaro.org>
Message-Id: <20210525172628.2088-4-alex.bennee@linaro.org>

---
v3
  - add its-migrate-unmapped-collection
---
 arm/unittests.cfg | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arm/unittests.cfg b/arm/unittests.cfg
index f776b66..21474b8 100644
--- a/arm/unittests.cfg
+++ b/arm/unittests.cfg
@@ -194,7 +194,6 @@ arch = arm64
 [its-migration]
 file = gic.flat
 smp = $MAX_SMP
-accel = kvm
 extra_params = -machine gic-version=3 -append 'its-migration'
 groups = its migration
 arch = arm64
@@ -202,7 +201,6 @@ arch = arm64
 [its-pending-migration]
 file = gic.flat
 smp = $MAX_SMP
-accel = kvm
 extra_params = -machine gic-version=3 -append 'its-pending-migration'
 groups = its migration
 arch = arm64
@@ -210,7 +208,6 @@ arch = arm64
 [its-migrate-unmapped-collection]
 file = gic.flat
 smp = $MAX_SMP
-accel = kvm
 extra_params = -machine gic-version=3 -append 'its-migrate-unmapped-collection'
 groups = its migration
 arch = arm64
-- 
2.30.2

[kvm-unit-tests PATCH v3 3/3] arch-run: do not process ERRATA when running under TCG

[Alex Bennée]

All the errata checking looks at the current host kernel version. For
TCG runs this is entirely irrelevant as the host kernel has no impact
on the behaviour of the guest. In fact we should set ERRATA_FORCE to
ensure we run those tests as QEMU doesn't attempt to model
non-confirming architectures.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 scripts/arch-run.bash | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
index 43da998..f1f4456 100644
--- a/scripts/arch-run.bash
+++ b/scripts/arch-run.bash
@@ -267,7 +267,9 @@ env_file ()
 
 env_errata ()
 {
-	if [ "$ERRATATXT" ] && [ ! -f "$ERRATATXT" ]; then
+	if [ "$ACCEL" = "tcg" ]; then
+		eval export "ERRATA_FORCE=y"
+	elif [ "$ERRATATXT" ] && [ ! -f "$ERRATATXT" ]; then
 		echo "$ERRATATXT not found. (ERRATATXT=$ERRATATXT)" >&2
 		return 2
 	elif [ "$ERRATATXT" ]; then
-- 
2.30.2

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Andrew Jones]

On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
> Hi,
> 
> Sorry this has been sitting in my tree so long. The changes are fairly
> minor from v2. I no longer split the tests up into TCG and KVM
> versions and instead just ensure that ERRATA_FORCE is always set when
> run under TCG.
> 
> Alex Bennée (3):
>   arm64: remove invalid check from its-trigger test
>   arm64: enable its-migration tests for TCG
>   arch-run: do not process ERRATA when running under TCG
> 
>  scripts/arch-run.bash |  4 +++-
>  arm/gic.c             | 16 ++++++----------
>  arm/unittests.cfg     |  3 ---
>  3 files changed, 9 insertions(+), 14 deletions(-)
> 
> -- 
> 2.30.2
> 
> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Hi Alex,

Thanks for this. I've applied to arm/queue, but I see that

FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received

consistently fails for me. Is that expected? Does it work for you?

Thanks,
drew

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Alex Bennée]

Andrew Jones <drjones@redhat.com> writes:

> On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
>> Hi,
>> 
>> Sorry this has been sitting in my tree so long. The changes are fairly
>> minor from v2. I no longer split the tests up into TCG and KVM
>> versions and instead just ensure that ERRATA_FORCE is always set when
>> run under TCG.
>> 
>> Alex Bennée (3):
>>   arm64: remove invalid check from its-trigger test
>>   arm64: enable its-migration tests for TCG
>>   arch-run: do not process ERRATA when running under TCG
>> 
>>  scripts/arch-run.bash |  4 +++-
>>  arm/gic.c             | 16 ++++++----------
>>  arm/unittests.cfg     |  3 ---
>>  3 files changed, 9 insertions(+), 14 deletions(-)
>> 
>> -- 
>> 2.30.2
>> 
>> _______________________________________________
>> kvmarm mailing list
>> kvmarm@lists.cs.columbia.edu
>> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
>
> Hi Alex,
>
> Thanks for this. I've applied to arm/queue, but I see that
>
> FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
>
> consistently fails for me. Is that expected? Does it work for you?

doh - looks like I cocked up the merge conflict...

Did it fail for TCG or for KVM (or both)?

-- 
Alex Bennée

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Alex Bennée]

Andrew Jones <drjones@redhat.com> writes:

> On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
>> Hi,
>> 
>> Sorry this has been sitting in my tree so long. The changes are fairly
>> minor from v2. I no longer split the tests up into TCG and KVM
>> versions and instead just ensure that ERRATA_FORCE is always set when
>> run under TCG.
>> 
>> Alex Bennée (3):
>>   arm64: remove invalid check from its-trigger test
>>   arm64: enable its-migration tests for TCG
>>   arch-run: do not process ERRATA when running under TCG
>> 
>>  scripts/arch-run.bash |  4 +++-
>>  arm/gic.c             | 16 ++++++----------
>>  arm/unittests.cfg     |  3 ---
>>  3 files changed, 9 insertions(+), 14 deletions(-)
>> 
>> -- 
>> 2.30.2
>> 
>> _______________________________________________
>> kvmarm mailing list
>> kvmarm@lists.cs.columbia.edu
>> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
>
> Hi Alex,
>
> Thanks for this. I've applied to arm/queue, but I see that
>
> FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
>
> consistently fails for me. Is that expected? Does it work for you?

Hmm so it works with KVM so I suspect it's showing up an error in the
TCG ITS implementation which I didn't see in earlier runs.

>
> Thanks,
> drew


-- 
Alex Bennée

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Andrew Jones]

On Fri, Nov 12, 2021 at 02:08:01PM +0000, Alex Bennée wrote:
> 
> Andrew Jones <drjones@redhat.com> writes:
> 
> > On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
> >> Hi,
> >> 
> >> Sorry this has been sitting in my tree so long. The changes are fairly
> >> minor from v2. I no longer split the tests up into TCG and KVM
> >> versions and instead just ensure that ERRATA_FORCE is always set when
> >> run under TCG.
> >> 
> >> Alex Bennée (3):
> >>   arm64: remove invalid check from its-trigger test
> >>   arm64: enable its-migration tests for TCG
> >>   arch-run: do not process ERRATA when running under TCG
> >> 
> >>  scripts/arch-run.bash |  4 +++-
> >>  arm/gic.c             | 16 ++++++----------
> >>  arm/unittests.cfg     |  3 ---
> >>  3 files changed, 9 insertions(+), 14 deletions(-)
> >> 
> >> -- 
> >> 2.30.2
> >> 
> >> _______________________________________________
> >> kvmarm mailing list
> >> kvmarm@lists.cs.columbia.edu
> >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
> >
> > Hi Alex,
> >
> > Thanks for this. I've applied to arm/queue, but I see that
> >
> > FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
> >
> > consistently fails for me. Is that expected? Does it work for you?
> 
> doh - looks like I cocked up the merge conflict...
> 
> Did it fail for TCG or for KVM (or both)?

Just TCG, which was why I was wondering if it was expected. I've never run
these tests with TCG before.

Thanks,
drew

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Alex Bennée]

Andrew Jones <drjones@redhat.com> writes:

> On Fri, Nov 12, 2021 at 02:08:01PM +0000, Alex Bennée wrote:
>> 
>> Andrew Jones <drjones@redhat.com> writes:
>> 
>> > On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
>> >> Hi,
>> >> 
>> >> Sorry this has been sitting in my tree so long. The changes are fairly
>> >> minor from v2. I no longer split the tests up into TCG and KVM
>> >> versions and instead just ensure that ERRATA_FORCE is always set when
>> >> run under TCG.
>> >> 
>> >> Alex Bennée (3):
>> >>   arm64: remove invalid check from its-trigger test
>> >>   arm64: enable its-migration tests for TCG
>> >>   arch-run: do not process ERRATA when running under TCG
>> >> 
>> >>  scripts/arch-run.bash |  4 +++-
>> >>  arm/gic.c             | 16 ++++++----------
>> >>  arm/unittests.cfg     |  3 ---
>> >>  3 files changed, 9 insertions(+), 14 deletions(-)
>> >> 
>> >> -- 
>> >> 2.30.2
>> >> 
>> >> _______________________________________________
>> >> kvmarm mailing list
>> >> kvmarm@lists.cs.columbia.edu
>> >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
>> >
>> > Hi Alex,
>> >
>> > Thanks for this. I've applied to arm/queue, but I see that
>> >
>> > FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
>> >
>> > consistently fails for me. Is that expected? Does it work for you?
>> 
>> doh - looks like I cocked up the merge conflict...
>> 
>> Did it fail for TCG or for KVM (or both)?
>
> Just TCG, which was why I was wondering if it was expected. I've never run
> these tests with TCG before.

Hmm I think expecting the IRQ at all is broken so I think I should
delete the whole pending test.

>
> Thanks,
> drew


-- 
Alex Bennée

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Andrew Jones]

On Fri, Nov 19, 2021 at 04:30:47PM +0000, Alex Bennée wrote:
> 
> Andrew Jones <drjones@redhat.com> writes:
> 
> > On Fri, Nov 12, 2021 at 02:08:01PM +0000, Alex Bennée wrote:
> >> 
> >> Andrew Jones <drjones@redhat.com> writes:
> >> 
> >> > On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
> >> >> Hi,
> >> >> 
> >> >> Sorry this has been sitting in my tree so long. The changes are fairly
> >> >> minor from v2. I no longer split the tests up into TCG and KVM
> >> >> versions and instead just ensure that ERRATA_FORCE is always set when
> >> >> run under TCG.
> >> >> 
> >> >> Alex Bennée (3):
> >> >>   arm64: remove invalid check from its-trigger test
> >> >>   arm64: enable its-migration tests for TCG
> >> >>   arch-run: do not process ERRATA when running under TCG
> >> >> 
> >> >>  scripts/arch-run.bash |  4 +++-
> >> >>  arm/gic.c             | 16 ++++++----------
> >> >>  arm/unittests.cfg     |  3 ---
> >> >>  3 files changed, 9 insertions(+), 14 deletions(-)
> >> >> 
> >> >> -- 
> >> >> 2.30.2
> >> >> 
> >> >> _______________________________________________
> >> >> kvmarm mailing list
> >> >> kvmarm@lists.cs.columbia.edu
> >> >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
> >> >
> >> > Hi Alex,
> >> >
> >> > Thanks for this. I've applied to arm/queue, but I see that
> >> >
> >> > FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
> >> >
> >> > consistently fails for me. Is that expected? Does it work for you?
> >> 
> >> doh - looks like I cocked up the merge conflict...
> >> 
> >> Did it fail for TCG or for KVM (or both)?
> >
> > Just TCG, which was why I was wondering if it was expected. I've never run
> > these tests with TCG before.
> 
> Hmm I think expecting the IRQ at all is broken so I think I should
> delete the whole pending test.

Feel free to repost. I'll update the patches in arm/queue before my next
MR.

Thanks,
drew

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Alex Bennée]

Andrew Jones <drjones@redhat.com> writes:

> On Fri, Nov 19, 2021 at 04:30:47PM +0000, Alex Bennée wrote:
>> 
>> Andrew Jones <drjones@redhat.com> writes:
>> 
>> > On Fri, Nov 12, 2021 at 02:08:01PM +0000, Alex Bennée wrote:
>> >> 
>> >> Andrew Jones <drjones@redhat.com> writes:
>> >> 
>> >> > On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
>> >> >> Hi,
>> >> >> 
>> >> >> Sorry this has been sitting in my tree so long. The changes are fairly
>> >> >> minor from v2. I no longer split the tests up into TCG and KVM
>> >> >> versions and instead just ensure that ERRATA_FORCE is always set when
>> >> >> run under TCG.
>> >> >> 
>> >> >> Alex Bennée (3):
>> >> >>   arm64: remove invalid check from its-trigger test
>> >> >>   arm64: enable its-migration tests for TCG
>> >> >>   arch-run: do not process ERRATA when running under TCG
>> >> >> 
>> >> >>  scripts/arch-run.bash |  4 +++-
>> >> >>  arm/gic.c             | 16 ++++++----------
>> >> >>  arm/unittests.cfg     |  3 ---
>> >> >>  3 files changed, 9 insertions(+), 14 deletions(-)
>> >> >> 
>> >> >> -- 
>> >> >> 2.30.2
>> >> >> 
>> >> >> _______________________________________________
>> >> >> kvmarm mailing list
>> >> >> kvmarm@lists.cs.columbia.edu
>> >> >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
>> >> >
>> >> > Hi Alex,
>> >> >
>> >> > Thanks for this. I've applied to arm/queue, but I see that
>> >> >
>> >> > FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
>> >> >
>> >> > consistently fails for me. Is that expected? Does it work for you?
>> >> 
>> >> doh - looks like I cocked up the merge conflict...
>> >> 
>> >> Did it fail for TCG or for KVM (or both)?
>> >
>> > Just TCG, which was why I was wondering if it was expected. I've never run
>> > these tests with TCG before.
>> 
>> Hmm I think expecting the IRQ at all is broken so I think I should
>> delete the whole pending test.
>
> Feel free to repost. I'll update the patches in arm/queue before my next
> MR.

Actually I think the problem was with a regression in the TCG ITS
support (now fixed in master). So I believe as of v3 everything is
correct (and v4 should be ignored).

Are you happy to apply this series or do you want me to repost it as v5?

>
> Thanks,
> drew


-- 
Alex Bennée

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Andrew Jones]

On Tue, Nov 30, 2021 at 02:11:34PM +0000, Alex Bennée wrote:
> 
> Andrew Jones <drjones@redhat.com> writes:
> 
> > On Fri, Nov 19, 2021 at 04:30:47PM +0000, Alex Bennée wrote:
> >> 
> >> Andrew Jones <drjones@redhat.com> writes:
> >> 
> >> > On Fri, Nov 12, 2021 at 02:08:01PM +0000, Alex Bennée wrote:
> >> >> 
> >> >> Andrew Jones <drjones@redhat.com> writes:
> >> >> 
> >> >> > On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
> >> >> >> Hi,
> >> >> >> 
> >> >> >> Sorry this has been sitting in my tree so long. The changes are fairly
> >> >> >> minor from v2. I no longer split the tests up into TCG and KVM
> >> >> >> versions and instead just ensure that ERRATA_FORCE is always set when
> >> >> >> run under TCG.
> >> >> >> 
> >> >> >> Alex Bennée (3):
> >> >> >>   arm64: remove invalid check from its-trigger test
> >> >> >>   arm64: enable its-migration tests for TCG
> >> >> >>   arch-run: do not process ERRATA when running under TCG
> >> >> >> 
> >> >> >>  scripts/arch-run.bash |  4 +++-
> >> >> >>  arm/gic.c             | 16 ++++++----------
> >> >> >>  arm/unittests.cfg     |  3 ---
> >> >> >>  3 files changed, 9 insertions(+), 14 deletions(-)
> >> >> >> 
> >> >> >> -- 
> >> >> >> 2.30.2
> >> >> >> 
> >> >> >> _______________________________________________
> >> >> >> kvmarm mailing list
> >> >> >> kvmarm@lists.cs.columbia.edu
> >> >> >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
> >> >> >
> >> >> > Hi Alex,
> >> >> >
> >> >> > Thanks for this. I've applied to arm/queue, but I see that
> >> >> >
> >> >> > FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
> >> >> >
> >> >> > consistently fails for me. Is that expected? Does it work for you?
> >> >> 
> >> >> doh - looks like I cocked up the merge conflict...
> >> >> 
> >> >> Did it fail for TCG or for KVM (or both)?
> >> >
> >> > Just TCG, which was why I was wondering if it was expected. I've never run
> >> > these tests with TCG before.
> >> 
> >> Hmm I think expecting the IRQ at all is broken so I think I should
> >> delete the whole pending test.
> >
> > Feel free to repost. I'll update the patches in arm/queue before my next
> > MR.
> 
> Actually I think the problem was with a regression in the TCG ITS
> support (now fixed in master). So I believe as of v3 everything is
> correct (and v4 should be ignored).
> 
> Are you happy to apply this series or do you want me to repost it as v5?

No need to repost. I'll retest v3 with latest QEMU.

Thanks,
drew

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Alex Bennée]

Andrew Jones <drjones@redhat.com> writes:

> On Tue, Nov 30, 2021 at 02:11:34PM +0000, Alex Bennée wrote:
>> 
>> Andrew Jones <drjones@redhat.com> writes:
>> 
>> > On Fri, Nov 19, 2021 at 04:30:47PM +0000, Alex Bennée wrote:
>> >> 
>> >> Andrew Jones <drjones@redhat.com> writes:
>> >> 
>> >> > On Fri, Nov 12, 2021 at 02:08:01PM +0000, Alex Bennée wrote:
>> >> >> 
>> >> >> Andrew Jones <drjones@redhat.com> writes:
>> >> >> 
>> >> >> > On Fri, Nov 12, 2021 at 11:47:31AM +0000, Alex Bennée wrote:
>> >> >> >> Hi,
>> >> >> >> 
>> >> >> >> Sorry this has been sitting in my tree so long. The changes are fairly
>> >> >> >> minor from v2. I no longer split the tests up into TCG and KVM
>> >> >> >> versions and instead just ensure that ERRATA_FORCE is always set when
>> >> >> >> run under TCG.
>> >> >> >> 
>> >> >> >> Alex Bennée (3):
>> >> >> >>   arm64: remove invalid check from its-trigger test
>> >> >> >>   arm64: enable its-migration tests for TCG
>> >> >> >>   arch-run: do not process ERRATA when running under TCG
>> >> >> >> 
>> >> >> >>  scripts/arch-run.bash |  4 +++-
>> >> >> >>  arm/gic.c             | 16 ++++++----------
>> >> >> >>  arm/unittests.cfg     |  3 ---
>> >> >> >>  3 files changed, 9 insertions(+), 14 deletions(-)
>> >> >> >> 
>> >> >> >> -- 
>> >> >> >> 2.30.2
>> >> >> >> 
>> >> >> >> _______________________________________________
>> >> >> >> kvmarm mailing list
>> >> >> >> kvmarm@lists.cs.columbia.edu
>> >> >> >> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
>> >> >> >
>> >> >> > Hi Alex,
>> >> >> >
>> >> >> > Thanks for this. I've applied to arm/queue, but I see that
>> >> >> >
>> >> >> > FAIL: gicv3: its-trigger: inv/invall: dev2/eventid=20 pending LPI is received
>> >> >> >
>> >> >> > consistently fails for me. Is that expected? Does it work for you?
>> >> >> 
>> >> >> doh - looks like I cocked up the merge conflict...
>> >> >> 
>> >> >> Did it fail for TCG or for KVM (or both)?
>> >> >
>> >> > Just TCG, which was why I was wondering if it was expected. I've never run
>> >> > these tests with TCG before.
>> >> 
>> >> Hmm I think expecting the IRQ at all is broken so I think I should
>> >> delete the whole pending test.
>> >
>> > Feel free to repost. I'll update the patches in arm/queue before my next
>> > MR.
>> 
>> Actually I think the problem was with a regression in the TCG ITS
>> support (now fixed in master). So I believe as of v3 everything is
>> correct (and v4 should be ignored).
>> 
>> Are you happy to apply this series or do you want me to repost it as v5?
>
> No need to repost. I'll retest v3 with latest QEMU.

Gentle ping, I'm trying to clear this off my internal JIRA so let me
know if you want me to do anything to help.

>
> Thanks,
> drew


-- 
Alex Bennée

Re: [kvm-unit-tests PATCH v3 0/3] GIC ITS tests

[Andrew Jones]

On Tue, Feb 01, 2022 at 01:10:13PM +0000, Alex Bennée wrote:
> 
> Gentle ping, I'm trying to clear this off my internal JIRA so let me
> know if you want me to do anything to help.
>

Sorry Alex! I've been juggling too many balls lately and completely
dropped this one. I'll rebase arm/queue now and run it through some
sanity tests. If all it good, I'll do the MR right away.

Thanks,
drew