From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>,
Steffen Eiden <seiden@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/4] s390x: uv-host: Add attestation test
Date: Fri, 28 Jan 2022 10:58:26 +0100 [thread overview]
Message-ID: <20220128105826.731e617e@p-imbrenda> (raw)
In-Reply-To: <5ba3d0d1-ca47-2511-9e7d-2d0da26aa179@redhat.com>
On Fri, 28 Jan 2022 10:29:42 +0100
Thomas Huth <thuth@redhat.com> wrote:
> On 28/01/2022 10.00, Janosch Frank wrote:
> > On 1/27/22 15:15, Steffen Eiden wrote:
> >> Adds an invalid command test for attestation in the uv-host.
> >>
> >> Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
> >
> > Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> >
> >> ---
> >> lib/s390x/asm/uv.h | 24 +++++++++++++++++++++++-
> >> s390x/uv-host.c | 3 ++-
> >> 2 files changed, 25 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h
> >> index 97c90e81..38c322bf 100644
> >> --- a/lib/s390x/asm/uv.h
> >> +++ b/lib/s390x/asm/uv.h
> >> @@ -1,10 +1,11 @@
> >> /*
> >> * s390x Ultravisor related definitions
> >> *
> >> - * Copyright (c) 2020 IBM Corp
> >> + * Copyright (c) 2020, 2022 IBM Corp
> >
> > I'm not sure when we actually need/want to update this.
>
> IANAL, but IIRC you can add/update the second year in the copyright
> statement if there has been a major change to the file in that year, so that
> should be fine. Not sure whether you still need the "(c)" these days, though.
>
> Thomas
>
I think the format IBM wants is:
Copyright IBM Corp. 2020, 2022
next prev parent reply other threads:[~2022-01-28 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 14:15 [kvm-unit-tests PATCH 0/4] s390x: Attestation tests Steffen Eiden
2022-01-27 14:15 ` [kvm-unit-tests PATCH 1/4] s390x: uv-host: Add attestation test Steffen Eiden
2022-01-28 9:00 ` Janosch Frank
2022-01-28 9:29 ` Thomas Huth
2022-01-28 9:58 ` Claudio Imbrenda [this message]
2022-01-27 14:15 ` [kvm-unit-tests PATCH 2/4] s390x: lib: Add QUI getter Steffen Eiden
2022-01-28 9:02 ` Janosch Frank
2022-01-27 14:15 ` [kvm-unit-tests PATCH 3/4] s390x: uv-guest: remove duplicated checks Steffen Eiden
2022-01-28 9:06 ` Janosch Frank
2022-01-27 14:15 ` [kvm-unit-tests PATCH 4/4] s390x: uv-guest: Add attestation tests Steffen Eiden
2022-01-28 9:54 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128105826.731e617e@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).