* [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals
@ 2022-08-17 0:36 Peter Xu
2022-08-17 0:36 ` [PATCH v3 1/3] mm/gup: Add FOLL_INTERRUPTIBLE Peter Xu
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Peter Xu @ 2022-08-17 0:36 UTC (permalink / raw)
To: linux-kernel, kvm
Cc: Sean Christopherson, David Hildenbrand, Andrew Morton,
Andrea Arcangeli, peterx, Paolo Bonzini, Dr . David Alan Gilbert,
Linux MM Mailing List, John Hubbard
v3:
- Patch 1
- Added r-b for DavidH
- Added support for hugetlbfs
- Patch 2 & 3
- Comment fixes [Sean]
- Move introduction of "interruptible" parameter into patch 2 [Sean]
- Move sigpending handling into kvm_handle_bad_page [Sean]
- Renamed kvm_handle_bad_page() to kvm_handle_error_pfn() [Sean, DavidM]
- Use kvm_handle_signal_exit() [Sean]
rfc: https://lore.kernel.org/kvm/20220617014147.7299-1-peterx@redhat.com
v1: https://lore.kernel.org/kvm/20220622213656.81546-1-peterx@redhat.com
v2: https://lore.kernel.org/kvm/20220721000318.93522-1-peterx@redhat.com
One issue was reported that libvirt won't be able to stop the virtual
machine using QMP command "stop" during a paused postcopy migration [1].
It won't work because "stop the VM" operation requires the hypervisor to
kick all the vcpu threads out using SIG_IPI in QEMU (which is translated to
a SIGUSR1). However since during a paused postcopy, the vcpu threads are
hang death at handle_userfault() so there're simply not responding to the
kicks. Further, the "stop" command will further hang the QMP channel.
The mm has facility to process generic signal (FAULT_FLAG_INTERRUPTIBLE),
however it's only used in the PF handlers only, not in GUP. Unluckily, KVM
is a heavy GUP user on guest page faults. It means we won't be able to
interrupt a long page fault for KVM fetching guest pages with what we have
right now.
I think it's reasonable for GUP to only listen to fatal signals, as most of
the GUP users are not really ready to handle such case. But actually KVM
is not such an user, and KVM actually has rich infrastructure to handle
even generic signals, and properly deliver the signal to the userspace.
Then the page fault can be retried in the next KVM_RUN.
This patchset added FOLL_INTERRUPTIBLE to enable FAULT_FLAG_INTERRUPTIBLE,
and let KVM be the first one to use it. KVM and mm/gup can always be able
to respond to fatal signals, but not non-fatal ones until this patchset.
One thing to mention is that this is not allowing all KVM paths to be able
to respond to non fatal signals, but only on x86 slow page faults. In the
future when more code is ready for handling signal interruptions, we can
explore possibility to have more gup callers using FOLL_INTERRUPTIBLE.
Tests
=====
I created a postcopy environment, pause the migration by shutting down the
network to emulate a network failure (so the handle_userfault() will stuck
for a long time), then I tried three things:
(1) Sending QMP command "stop" to QEMU monitor,
(2) Hitting Ctrl-C from QEMU cmdline,
(3) GDB attach to the dest QEMU process.
Before this patchset, all three use case hang. After the patchset, all
work just like when there's not network failure at all.
Please have a look, thanks.
[1] https://gitlab.com/qemu-project/qemu/-/issues/1052
Peter Xu (3):
mm/gup: Add FOLL_INTERRUPTIBLE
kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING
kvm/x86: Allow to respond to generic signals during slow page faults
arch/arm64/kvm/mmu.c | 2 +-
arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +-
arch/x86/kvm/mmu/mmu.c | 18 ++++++++++----
include/linux/kvm_host.h | 14 +++++++++--
include/linux/mm.h | 1 +
mm/gup.c | 33 ++++++++++++++++++++++----
mm/hugetlb.c | 5 +++-
virt/kvm/kvm_main.c | 30 ++++++++++++++---------
virt/kvm/kvm_mm.h | 4 ++--
virt/kvm/pfncache.c | 2 +-
11 files changed, 85 insertions(+), 28 deletions(-)
--
2.32.0
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v3 1/3] mm/gup: Add FOLL_INTERRUPTIBLE 2022-08-17 0:36 [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu @ 2022-08-17 0:36 ` Peter Xu 2022-08-17 0:36 ` [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING Peter Xu ` (3 subsequent siblings) 4 siblings, 0 replies; 9+ messages in thread From: Peter Xu @ 2022-08-17 0:36 UTC (permalink / raw) To: linux-kernel, kvm Cc: Sean Christopherson, David Hildenbrand, Andrew Morton, Andrea Arcangeli, peterx, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard We have had FAULT_FLAG_INTERRUPTIBLE but it was never applied to GUPs. One issue with it is that not all GUP paths are able to handle signal delivers besides SIGKILL. That's not ideal for the GUP users who are actually able to handle these cases, like KVM. KVM uses GUP extensively on faulting guest pages, during which we've got existing infrastructures to retry a page fault at a later time. Allowing the GUP to be interrupted by generic signals can make KVM related threads to be more responsive. For examples: (1) SIGUSR1: which QEMU/KVM uses to deliver an inter-process IPI, e.g. when the admin issues a vm_stop QMP command, SIGUSR1 can be generated to kick the vcpus out of kernel context immediately, (2) SIGINT: which can be used with interactive hypervisor users to stop a virtual machine with Ctrl-C without any delays/hangs, (3) SIGTRAP: which grants GDB capability even during page faults that are stuck for a long time. Normally hypervisor will be able to receive these signals properly, but not if we're stuck in a GUP for a long time for whatever reason. It happens easily with a stucked postcopy migration when e.g. a network temp failure happens, then some vcpu threads can hang death waiting for the pages. With the new FOLL_INTERRUPTIBLE, we can allow GUP users like KVM to selectively enable the ability to trap these signals. Reviewed-by: John Hubbard <jhubbard@nvidia.com> Reviewed-by: David Hildenbrand <david@redhat.com> Signed-off-by: Peter Xu <peterx@redhat.com> --- include/linux/mm.h | 1 + mm/gup.c | 33 +++++++++++++++++++++++++++++---- mm/hugetlb.c | 5 ++++- 3 files changed, 34 insertions(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index cf3d0d673f6b..c09eccd5d553 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -2941,6 +2941,7 @@ struct page *follow_page(struct vm_area_struct *vma, unsigned long address, #define FOLL_SPLIT_PMD 0x20000 /* split huge pmd before returning */ #define FOLL_PIN 0x40000 /* pages must be released via unpin_user_page */ #define FOLL_FAST_ONLY 0x80000 /* gup_fast: prevent fall-back to slow gup */ +#define FOLL_INTERRUPTIBLE 0x100000 /* allow interrupts from generic signals */ /* * FOLL_PIN and FOLL_LONGTERM may be used in various combinations with each diff --git a/mm/gup.c b/mm/gup.c index 551264407624..f39cbe011cf1 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -933,8 +933,17 @@ static int faultin_page(struct vm_area_struct *vma, fault_flags |= FAULT_FLAG_WRITE; if (*flags & FOLL_REMOTE) fault_flags |= FAULT_FLAG_REMOTE; - if (locked) + if (locked) { fault_flags |= FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE; + /* + * FAULT_FLAG_INTERRUPTIBLE is opt-in. GUP callers must set + * FOLL_INTERRUPTIBLE to enable FAULT_FLAG_INTERRUPTIBLE. + * That's because some callers may not be prepared to + * handle early exits caused by non-fatal signals. + */ + if (*flags & FOLL_INTERRUPTIBLE) + fault_flags |= FAULT_FLAG_INTERRUPTIBLE; + } if (*flags & FOLL_NOWAIT) fault_flags |= FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_RETRY_NOWAIT; if (*flags & FOLL_TRIED) { @@ -1322,6 +1331,22 @@ int fixup_user_fault(struct mm_struct *mm, } EXPORT_SYMBOL_GPL(fixup_user_fault); +/* + * GUP always responds to fatal signals. When FOLL_INTERRUPTIBLE is + * specified, it'll also respond to generic signals. The caller of GUP + * that has FOLL_INTERRUPTIBLE should take care of the GUP interruption. + */ +static bool gup_signal_pending(unsigned int flags) +{ + if (fatal_signal_pending(current)) + return true; + + if (!(flags & FOLL_INTERRUPTIBLE)) + return false; + + return signal_pending(current); +} + /* * Please note that this function, unlike __get_user_pages will not * return 0 for nr_pages > 0 without FOLL_NOWAIT @@ -1403,11 +1428,11 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, * Repeat on the address that fired VM_FAULT_RETRY * with both FAULT_FLAG_ALLOW_RETRY and * FAULT_FLAG_TRIED. Note that GUP can be interrupted - * by fatal signals, so we need to check it before we + * by fatal signals of even common signals, depending on + * the caller's request. So we need to check it before we * start trying again otherwise it can loop forever. */ - - if (fatal_signal_pending(current)) { + if (gup_signal_pending(flags)) { if (!pages_done) pages_done = -EINTR; break; diff --git a/mm/hugetlb.c b/mm/hugetlb.c index a57e1be41401..4025a305d573 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6176,9 +6176,12 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma, fault_flags |= FAULT_FLAG_WRITE; else if (unshare) fault_flags |= FAULT_FLAG_UNSHARE; - if (locked) + if (locked) { fault_flags |= FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE; + if (flags & FOLL_INTERRUPTIBLE) + fault_flags |= FAULT_FLAG_INTERRUPTIBLE; + } if (flags & FOLL_NOWAIT) fault_flags |= FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_RETRY_NOWAIT; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING 2022-08-17 0:36 [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu 2022-08-17 0:36 ` [PATCH v3 1/3] mm/gup: Add FOLL_INTERRUPTIBLE Peter Xu @ 2022-08-17 0:36 ` Peter Xu 2022-10-07 1:39 ` Sean Christopherson 2022-08-17 0:36 ` [PATCH v3 3/3] kvm/x86: Allow to respond to generic signals during slow page faults Peter Xu ` (2 subsequent siblings) 4 siblings, 1 reply; 9+ messages in thread From: Peter Xu @ 2022-08-17 0:36 UTC (permalink / raw) To: linux-kernel, kvm Cc: Sean Christopherson, David Hildenbrand, Andrew Morton, Andrea Arcangeli, peterx, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard Add one new PFN error type to show when KVM got interrupted when fetching the PFN due to any kind of signal pending. Add a new "interruptible" flag showing that the caller is willing to be interrupted by signals during the __gfn_to_pfn_memslot() request. Wire it up with a FOLL_INTERRUPTIBLE flag that we've just introduced. This prepares KVM to be able to respond to SIGUSR1 (for QEMU that's the SIGIPI) even during e.g. handling an userfaultfd page fault. Since at it, renaming kvm_handle_bad_page to kvm_handle_error_pfn assuming that'll match better with what it does, e.g. KVM_PFN_ERR_SIGPENDING is not accurately a bad page but just one kind of errors. No functional change intended so far with the patch. Signed-off-by: Peter Xu <peterx@redhat.com> --- arch/arm64/kvm/mmu.c | 2 +- arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- arch/x86/kvm/mmu/mmu.c | 13 +++++++---- include/linux/kvm_host.h | 14 ++++++++++-- virt/kvm/kvm_main.c | 30 ++++++++++++++++---------- virt/kvm/kvm_mm.h | 4 ++-- virt/kvm/pfncache.c | 2 +- 8 files changed, 46 insertions(+), 23 deletions(-) diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index 87f1cd0df36e..8b730e809e9f 100644 --- a/arch/arm64/kvm/mmu.c +++ b/arch/arm64/kvm/mmu.c @@ -1204,7 +1204,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, */ smp_rmb(); - pfn = __gfn_to_pfn_memslot(memslot, gfn, false, NULL, + pfn = __gfn_to_pfn_memslot(memslot, gfn, false, false, NULL, write_fault, &writable, NULL); if (pfn == KVM_PFN_ERR_HWPOISON) { kvm_send_hwpoison_signal(hva, vma_shift); diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 514fd45c1994..7aed5ef6588e 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c @@ -598,7 +598,7 @@ int kvmppc_book3s_hv_page_fault(struct kvm_vcpu *vcpu, write_ok = true; } else { /* Call KVM generic code to do the slow-path check */ - pfn = __gfn_to_pfn_memslot(memslot, gfn, false, NULL, + pfn = __gfn_to_pfn_memslot(memslot, gfn, false, false, NULL, writing, &write_ok, NULL); if (is_error_noslot_pfn(pfn)) return -EFAULT; diff --git a/arch/powerpc/kvm/book3s_64_mmu_radix.c b/arch/powerpc/kvm/book3s_64_mmu_radix.c index 42851c32ff3b..9991f9d9ee59 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_radix.c +++ b/arch/powerpc/kvm/book3s_64_mmu_radix.c @@ -845,7 +845,7 @@ int kvmppc_book3s_instantiate_page(struct kvm_vcpu *vcpu, unsigned long pfn; /* Call KVM generic code to do the slow-path check */ - pfn = __gfn_to_pfn_memslot(memslot, gfn, false, NULL, + pfn = __gfn_to_pfn_memslot(memslot, gfn, false, false, NULL, writing, upgrade_p, NULL); if (is_error_noslot_pfn(pfn)) return -EFAULT; diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 3e1317325e1f..23dc46da2f18 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -3134,8 +3134,13 @@ static void kvm_send_hwpoison_signal(unsigned long address, struct task_struct * send_sig_mceerr(BUS_MCEERR_AR, (void __user *)address, PAGE_SHIFT, tsk); } -static int kvm_handle_bad_page(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) +static int kvm_handle_error_pfn(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) { + if (is_sigpending_pfn(pfn)) { + kvm_handle_signal_exit(vcpu); + return -EINTR; + } + /* * Do not cache the mmio info caused by writing the readonly gfn * into the spte otherwise read access on readonly gfn also can @@ -3157,7 +3162,7 @@ static int handle_abnormal_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fau { /* The pfn is invalid, report the error! */ if (unlikely(is_error_pfn(fault->pfn))) - return kvm_handle_bad_page(vcpu, fault->gfn, fault->pfn); + return kvm_handle_error_pfn(vcpu, fault->gfn, fault->pfn); if (unlikely(!fault->slot)) { gva_t gva = fault->is_tdp ? 0 : fault->addr; @@ -4155,7 +4160,7 @@ static int kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) } async = false; - fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, &async, + fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, false, &async, fault->write, &fault->map_writable, &fault->hva); if (!async) @@ -4172,7 +4177,7 @@ static int kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) } } - fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, NULL, + fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, false, NULL, fault->write, &fault->map_writable, &fault->hva); return RET_PF_CONTINUE; diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 1c480b1821e1..1d792f60cfda 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -96,6 +96,7 @@ #define KVM_PFN_ERR_FAULT (KVM_PFN_ERR_MASK) #define KVM_PFN_ERR_HWPOISON (KVM_PFN_ERR_MASK + 1) #define KVM_PFN_ERR_RO_FAULT (KVM_PFN_ERR_MASK + 2) +#define KVM_PFN_ERR_SIGPENDING (KVM_PFN_ERR_MASK + 3) /* * error pfns indicate that the gfn is in slot but faild to @@ -106,6 +107,15 @@ static inline bool is_error_pfn(kvm_pfn_t pfn) return !!(pfn & KVM_PFN_ERR_MASK); } +/* + * KVM_PFN_ERR_SIGPENDING indicates that fetching the PFN was interrupted + * by a pending signal. Note, the signal may or may not be fatal. + */ +static inline bool is_sigpending_pfn(kvm_pfn_t pfn) +{ + return pfn == KVM_PFN_ERR_SIGPENDING; +} + /* * error_noslot pfns indicate that the gfn can not be * translated to pfn - it is not in slot or failed to @@ -1141,8 +1151,8 @@ kvm_pfn_t gfn_to_pfn_prot(struct kvm *kvm, gfn_t gfn, bool write_fault, kvm_pfn_t gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn); kvm_pfn_t gfn_to_pfn_memslot_atomic(const struct kvm_memory_slot *slot, gfn_t gfn); kvm_pfn_t __gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn, - bool atomic, bool *async, bool write_fault, - bool *writable, hva_t *hva); + bool atomic, bool interruptible, bool *async, + bool write_fault, bool *writable, hva_t *hva); void kvm_release_pfn_clean(kvm_pfn_t pfn); void kvm_release_pfn_dirty(kvm_pfn_t pfn); diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 32896c845ffe..56dde0e141b4 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2498,7 +2498,7 @@ static bool hva_to_pfn_fast(unsigned long addr, bool write_fault, * 1 indicates success, -errno is returned if error is detected. */ static int hva_to_pfn_slow(unsigned long addr, bool *async, bool write_fault, - bool *writable, kvm_pfn_t *pfn) + bool interruptible, bool *writable, kvm_pfn_t *pfn) { unsigned int flags = FOLL_HWPOISON; struct page *page; @@ -2513,6 +2513,8 @@ static int hva_to_pfn_slow(unsigned long addr, bool *async, bool write_fault, flags |= FOLL_WRITE; if (async) flags |= FOLL_NOWAIT; + if (interruptible) + flags |= FOLL_INTERRUPTIBLE; npages = get_user_pages_unlocked(addr, 1, &page, flags); if (npages != 1) @@ -2622,6 +2624,7 @@ static int hva_to_pfn_remapped(struct vm_area_struct *vma, * Pin guest page in memory and return its pfn. * @addr: host virtual address which maps memory to the guest * @atomic: whether this function can sleep + * @interruptible: whether the process can be interrupted by non-fatal signals * @async: whether this function need to wait IO complete if the * host page is not in the memory * @write_fault: whether we should get a writable host page @@ -2632,8 +2635,8 @@ static int hva_to_pfn_remapped(struct vm_area_struct *vma, * 2): @write_fault = false && @writable, @writable will tell the caller * whether the mapping is writable. */ -kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, - bool write_fault, bool *writable) +kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool interruptible, + bool *async, bool write_fault, bool *writable) { struct vm_area_struct *vma; kvm_pfn_t pfn; @@ -2648,9 +2651,12 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, if (atomic) return KVM_PFN_ERR_FAULT; - npages = hva_to_pfn_slow(addr, async, write_fault, writable, &pfn); + npages = hva_to_pfn_slow(addr, async, write_fault, interruptible, + writable, &pfn); if (npages == 1) return pfn; + if (npages == -EINTR) + return KVM_PFN_ERR_SIGPENDING; mmap_read_lock(current->mm); if (npages == -EHWPOISON || @@ -2681,8 +2687,8 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, } kvm_pfn_t __gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn, - bool atomic, bool *async, bool write_fault, - bool *writable, hva_t *hva) + bool atomic, bool interruptible, bool *async, + bool write_fault, bool *writable, hva_t *hva) { unsigned long addr = __gfn_to_hva_many(slot, gfn, NULL, write_fault); @@ -2707,7 +2713,7 @@ kvm_pfn_t __gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn, writable = NULL; } - return hva_to_pfn(addr, atomic, async, write_fault, + return hva_to_pfn(addr, atomic, interruptible, async, write_fault, writable); } EXPORT_SYMBOL_GPL(__gfn_to_pfn_memslot); @@ -2715,20 +2721,22 @@ EXPORT_SYMBOL_GPL(__gfn_to_pfn_memslot); kvm_pfn_t gfn_to_pfn_prot(struct kvm *kvm, gfn_t gfn, bool write_fault, bool *writable) { - return __gfn_to_pfn_memslot(gfn_to_memslot(kvm, gfn), gfn, false, NULL, - write_fault, writable, NULL); + return __gfn_to_pfn_memslot(gfn_to_memslot(kvm, gfn), gfn, false, false, + NULL, write_fault, writable, NULL); } EXPORT_SYMBOL_GPL(gfn_to_pfn_prot); kvm_pfn_t gfn_to_pfn_memslot(const struct kvm_memory_slot *slot, gfn_t gfn) { - return __gfn_to_pfn_memslot(slot, gfn, false, NULL, true, NULL, NULL); + return __gfn_to_pfn_memslot(slot, gfn, false, false, NULL, true, + NULL, NULL); } EXPORT_SYMBOL_GPL(gfn_to_pfn_memslot); kvm_pfn_t gfn_to_pfn_memslot_atomic(const struct kvm_memory_slot *slot, gfn_t gfn) { - return __gfn_to_pfn_memslot(slot, gfn, true, NULL, true, NULL, NULL); + return __gfn_to_pfn_memslot(slot, gfn, true, false, NULL, true, + NULL, NULL); } EXPORT_SYMBOL_GPL(gfn_to_pfn_memslot_atomic); diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h index 41da467d99c9..a1ab15006af3 100644 --- a/virt/kvm/kvm_mm.h +++ b/virt/kvm/kvm_mm.h @@ -24,8 +24,8 @@ #define KVM_MMU_READ_UNLOCK(kvm) spin_unlock(&(kvm)->mmu_lock) #endif /* KVM_HAVE_MMU_RWLOCK */ -kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, - bool write_fault, bool *writable); +kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool interruptible, + bool *async, bool write_fault, bool *writable); #ifdef CONFIG_HAVE_KVM_PFNCACHE void gfn_to_pfn_cache_invalidate_start(struct kvm *kvm, diff --git a/virt/kvm/pfncache.c b/virt/kvm/pfncache.c index ab519f72f2cd..6dacb58bf4d0 100644 --- a/virt/kvm/pfncache.c +++ b/virt/kvm/pfncache.c @@ -181,7 +181,7 @@ static kvm_pfn_t hva_to_pfn_retry(struct kvm *kvm, struct gfn_to_pfn_cache *gpc) } /* We always request a writeable mapping */ - new_pfn = hva_to_pfn(gpc->uhva, false, NULL, true, NULL); + new_pfn = hva_to_pfn(gpc->uhva, false, false, NULL, true, NULL); if (is_error_noslot_pfn(new_pfn)) goto out_error; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING 2022-08-17 0:36 ` [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING Peter Xu @ 2022-10-07 1:39 ` Sean Christopherson 2022-10-07 15:03 ` Peter Xu 0 siblings, 1 reply; 9+ messages in thread From: Sean Christopherson @ 2022-10-07 1:39 UTC (permalink / raw) To: Peter Xu Cc: linux-kernel, kvm, David Hildenbrand, Andrew Morton, Andrea Arcangeli, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard On Tue, Aug 16, 2022, Peter Xu wrote: > Since at it, renaming kvm_handle_bad_page to kvm_handle_error_pfn assuming Please put parantheses after function names, e.g. kvm_handle_bad_page(). > that'll match better with what it does, e.g. KVM_PFN_ERR_SIGPENDING is not > accurately a bad page but just one kind of errors. ... > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index 3e1317325e1f..23dc46da2f18 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -3134,8 +3134,13 @@ static void kvm_send_hwpoison_signal(unsigned long address, struct task_struct * > send_sig_mceerr(BUS_MCEERR_AR, (void __user *)address, PAGE_SHIFT, tsk); > } > > -static int kvm_handle_bad_page(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) > +static int kvm_handle_error_pfn(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) > { > + if (is_sigpending_pfn(pfn)) { > + kvm_handle_signal_exit(vcpu); > + return -EINTR; > + } ... > @@ -2648,9 +2651,12 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, > if (atomic) > return KVM_PFN_ERR_FAULT; > > - npages = hva_to_pfn_slow(addr, async, write_fault, writable, &pfn); > + npages = hva_to_pfn_slow(addr, async, write_fault, interruptible, > + writable, &pfn); > if (npages == 1) > return pfn; > + if (npages == -EINTR) > + return KVM_PFN_ERR_SIGPENDING; This patch should be split into 3 parts: 1. Add KVM_PFN_ERR_SIGPENDING and the above code 2. Add the interruptible flag 3. Add handling in x86 and rename kvm_handle_bad_page() With #3 merged with patch 3. That was if there's oddball arch code that reacts poorly to KVM_PFN_ERR_SIGPENDING, those errors will bisect to #1. And if there's a typo in the plumbing, that bisects to #2. And if something goes sideways in x86, those bugs bisect to #3 (patch 3), and it's easy to revert just the x86 changes (though I can't imagine that's likely). ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING 2022-10-07 1:39 ` Sean Christopherson @ 2022-10-07 15:03 ` Peter Xu 0 siblings, 0 replies; 9+ messages in thread From: Peter Xu @ 2022-10-07 15:03 UTC (permalink / raw) To: Sean Christopherson Cc: linux-kernel, kvm, David Hildenbrand, Andrew Morton, Andrea Arcangeli, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard On Fri, Oct 07, 2022 at 01:39:17AM +0000, Sean Christopherson wrote: > On Tue, Aug 16, 2022, Peter Xu wrote: > > Since at it, renaming kvm_handle_bad_page to kvm_handle_error_pfn assuming > > Please put parantheses after function names, e.g. kvm_handle_bad_page(). > > > that'll match better with what it does, e.g. KVM_PFN_ERR_SIGPENDING is not > > accurately a bad page but just one kind of errors. > > ... > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > index 3e1317325e1f..23dc46da2f18 100644 > > --- a/arch/x86/kvm/mmu/mmu.c > > +++ b/arch/x86/kvm/mmu/mmu.c > > @@ -3134,8 +3134,13 @@ static void kvm_send_hwpoison_signal(unsigned long address, struct task_struct * > > send_sig_mceerr(BUS_MCEERR_AR, (void __user *)address, PAGE_SHIFT, tsk); > > } > > > > -static int kvm_handle_bad_page(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) > > +static int kvm_handle_error_pfn(struct kvm_vcpu *vcpu, gfn_t gfn, kvm_pfn_t pfn) > > { > > + if (is_sigpending_pfn(pfn)) { > > + kvm_handle_signal_exit(vcpu); > > + return -EINTR; > > + } > > ... > > > @@ -2648,9 +2651,12 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool *async, > > if (atomic) > > return KVM_PFN_ERR_FAULT; > > > > - npages = hva_to_pfn_slow(addr, async, write_fault, writable, &pfn); > > + npages = hva_to_pfn_slow(addr, async, write_fault, interruptible, > > + writable, &pfn); > > if (npages == 1) > > return pfn; > > + if (npages == -EINTR) > > + return KVM_PFN_ERR_SIGPENDING; > > This patch should be split into 3 parts: > > 1. Add KVM_PFN_ERR_SIGPENDING and the above code > 2. Add the interruptible flag > 3. Add handling in x86 and rename kvm_handle_bad_page() > > With #3 merged with patch 3. > > That was if there's oddball arch code that reacts poorly to KVM_PFN_ERR_SIGPENDING, > those errors will bisect to #1. > > And if there's a typo in the plumbing, that bisects to #2. > > And if something goes sideways in x86, those bugs bisect to #3 (patch 3), and it's > easy to revert just the x86 changes (though I can't imagine that's likely). Yeah the x86 change in this patch is indeed a bit weird with the generic subject. All points taken, thanks. -- Peter Xu ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 3/3] kvm/x86: Allow to respond to generic signals during slow page faults 2022-08-17 0:36 [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu 2022-08-17 0:36 ` [PATCH v3 1/3] mm/gup: Add FOLL_INTERRUPTIBLE Peter Xu 2022-08-17 0:36 ` [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING Peter Xu @ 2022-08-17 0:36 ` Peter Xu 2022-08-17 1:37 ` [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu 2022-10-06 20:47 ` Peter Xu 4 siblings, 0 replies; 9+ messages in thread From: Peter Xu @ 2022-08-17 0:36 UTC (permalink / raw) To: linux-kernel, kvm Cc: Sean Christopherson, David Hildenbrand, Andrew Morton, Andrea Arcangeli, peterx, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard Enable x86 slow page faults to be able to respond to non-fatal signals. Signed-off-by: Peter Xu <peterx@redhat.com> --- arch/x86/kvm/mmu/mmu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 23dc46da2f18..4a7d387a762a 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -4177,7 +4177,12 @@ static int kvm_faultin_pfn(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) } } - fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, false, NULL, + /* + * Allow gup to bail on pending non-fatal signals when it's also allowed + * to wait for IO. Note, gup always bails if it is unable to quickly + * get a page and a fatal signal, i.e. SIGKILL, is pending. + */ + fault->pfn = __gfn_to_pfn_memslot(slot, fault->gfn, false, true, NULL, fault->write, &fault->map_writable, &fault->hva); return RET_PF_CONTINUE; -- 2.32.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals 2022-08-17 0:36 [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu ` (2 preceding siblings ...) 2022-08-17 0:36 ` [PATCH v3 3/3] kvm/x86: Allow to respond to generic signals during slow page faults Peter Xu @ 2022-08-17 1:37 ` Peter Xu 2022-10-06 20:47 ` Peter Xu 4 siblings, 0 replies; 9+ messages in thread From: Peter Xu @ 2022-08-17 1:37 UTC (permalink / raw) To: linux-kernel, kvm Cc: Sean Christopherson, David Hildenbrand, Andrew Morton, Andrea Arcangeli, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard, David Matlack, Mike Kravetz On Tue, Aug 16, 2022 at 08:36:11PM -0400, Peter Xu wrote: > v3: > - Patch 1 > - Added r-b for DavidH > - Added support for hugetlbfs > - Patch 2 & 3 > - Comment fixes [Sean] > - Move introduction of "interruptible" parameter into patch 2 [Sean] > - Move sigpending handling into kvm_handle_bad_page [Sean] > - Renamed kvm_handle_bad_page() to kvm_handle_error_pfn() [Sean, DavidM] > - Use kvm_handle_signal_exit() [Sean] > > rfc: https://lore.kernel.org/kvm/20220617014147.7299-1-peterx@redhat.com > v1: https://lore.kernel.org/kvm/20220622213656.81546-1-peterx@redhat.com > v2: https://lore.kernel.org/kvm/20220721000318.93522-1-peterx@redhat.com Sorry, forgot to copy DavidM and Mike. -- Peter Xu ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals 2022-08-17 0:36 [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu ` (3 preceding siblings ...) 2022-08-17 1:37 ` [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu @ 2022-10-06 20:47 ` Peter Xu 2022-10-07 1:40 ` Sean Christopherson 4 siblings, 1 reply; 9+ messages in thread From: Peter Xu @ 2022-10-06 20:47 UTC (permalink / raw) To: linux-kernel, kvm Cc: Sean Christopherson, David Hildenbrand, Andrew Morton, Andrea Arcangeli, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard On Tue, Aug 16, 2022 at 08:36:11PM -0400, Peter Xu wrote: > v3: > - Patch 1 > - Added r-b for DavidH > - Added support for hugetlbfs > - Patch 2 & 3 > - Comment fixes [Sean] > - Move introduction of "interruptible" parameter into patch 2 [Sean] > - Move sigpending handling into kvm_handle_bad_page [Sean] > - Renamed kvm_handle_bad_page() to kvm_handle_error_pfn() [Sean, DavidM] > - Use kvm_handle_signal_exit() [Sean] Any further comments from kvm side? Thanks, -- Peter Xu ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals 2022-10-06 20:47 ` Peter Xu @ 2022-10-07 1:40 ` Sean Christopherson 0 siblings, 0 replies; 9+ messages in thread From: Sean Christopherson @ 2022-10-07 1:40 UTC (permalink / raw) To: Peter Xu Cc: linux-kernel, kvm, David Hildenbrand, Andrew Morton, Andrea Arcangeli, Paolo Bonzini, Dr . David Alan Gilbert, Linux MM Mailing List, John Hubbard On Thu, Oct 06, 2022, Peter Xu wrote: > On Tue, Aug 16, 2022 at 08:36:11PM -0400, Peter Xu wrote: > > v3: > > - Patch 1 > > - Added r-b for DavidH > > - Added support for hugetlbfs > > - Patch 2 & 3 > > - Comment fixes [Sean] > > - Move introduction of "interruptible" parameter into patch 2 [Sean] > > - Move sigpending handling into kvm_handle_bad_page [Sean] > > - Renamed kvm_handle_bad_page() to kvm_handle_error_pfn() [Sean, DavidM] > > - Use kvm_handle_signal_exit() [Sean] > > Any further comments from kvm side? Thanks, Code looks good, patch 2 just needs to be split up to better isolate the three changes in there. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-10-07 15:03 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-17 0:36 [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu 2022-08-17 0:36 ` [PATCH v3 1/3] mm/gup: Add FOLL_INTERRUPTIBLE Peter Xu 2022-08-17 0:36 ` [PATCH v3 2/3] kvm: Add new pfn error KVM_PFN_ERR_SIGPENDING Peter Xu 2022-10-07 1:39 ` Sean Christopherson 2022-10-07 15:03 ` Peter Xu 2022-08-17 0:36 ` [PATCH v3 3/3] kvm/x86: Allow to respond to generic signals during slow page faults Peter Xu 2022-08-17 1:37 ` [PATCH v3 0/3] kvm/mm: Allow GUP to respond to non fatal signals Peter Xu 2022-10-06 20:47 ` Peter Xu 2022-10-07 1:40 ` Sean Christopherson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).