From: Sean Christopherson <seanjc@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Like Xu <like.xu.linux@gmail.com>
Subject: [PATCH v5 0/8] KVM: x86: Intel LBR related perf cleanups
Date: Thu, 6 Oct 2022 00:03:06 +0000 [thread overview]
Message-ID: <20221006000314.73240-1-seanjc@google.com> (raw)
PeterZ, I dropped your ACK from v4 because the perf patches were completely
broken.
Fix a bug where KVM incorrectly advertises PMU_CAP_LBR_FMT to userspace if
perf has disabled LBRs, e.g. because probing one or more LBR MSRs during
setup hit a #GP.
The non-KVM patch cleans up a KVM-specific perf API to fix a benign bug
where KVM ignores the error return from the API.
The remaining patches clean up KVM's PERF_CAPABILITIES mess, which makes
everything far more complex than it needs to be by
v5:
- Drop perf patches that removed stubs. The stubs are sadly necessary
when CPU_SUP_INTEL=n && KVM_INTEL={m,y}, which is possible due to
KVM_INTEL effectively depending on INTEL || CENTAUR || ZHAOXIN.
[hint provided by kernel test robot].
- Add a patch to ignore guest CPUID on host userspace MSR writes.
- Add supported PERF_CAPABILITIES to kvm_caps to simplify code for all
parties.
v4
- https://lore.kernel.org/all/20220901173258.925729-1-seanjc@google.com:
- Make vmx_get_perf_capabilities() non-inline to avoid references to
x86_perf_get_lbr() when CPU_SUP_INTEL=n. [kernel test robot]
v3:
- https://lore.kernel.org/all/20220831000051.4015031-1-seanjc@google.com
- Drop patches for bug #1 (already merged).
- Drop misguided "clean up the capability check" patch. [Like]
v2:
- https://lore.kernel.org/all/20220803192658.860033-1-seanjc@google.com
- Add patches to fix bug #2. [Like]
- Add a patch to clean up the capability check.
- Tweak the changelog for the PMU refresh bug fix to call out that
KVM should disallow changing feature MSRs after KVM_RUN. [Like]
v1: https://lore.kernel.org/all/20220727233424.2968356-1-seanjc@google.com
Sean Christopherson (8):
perf/x86/core: Zero @lbr instead of returning -1 in x86_perf_get_lbr()
stub
KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs
KVM: VMX: Fold vmx_supported_debugctl() into vcpu_supported_debugctl()
KVM: VMX: Ignore guest CPUID for host userspace writes to DEBUGCTL
KVM: x86: Track supported PERF_CAPABILITIES in kvm_caps
KVM: x86: Init vcpu->arch.perf_capabilities in common x86 code
KVM: x86: Handle PERF_CAPABILITIES in common x86's
kvm_get_msr_feature()
KVM: x86: Directly query supported PERF_CAPABILITIES for WRMSR checks
arch/x86/events/intel/lbr.c | 6 +---
arch/x86/include/asm/perf_event.h | 6 ++--
arch/x86/kvm/svm/svm.c | 3 +-
arch/x86/kvm/vmx/capabilities.h | 37 ----------------------
arch/x86/kvm/vmx/pmu_intel.c | 1 -
arch/x86/kvm/vmx/vmx.c | 51 +++++++++++++++++++++++--------
arch/x86/kvm/x86.c | 14 ++++-----
arch/x86/kvm/x86.h | 1 +
8 files changed, 52 insertions(+), 67 deletions(-)
base-commit: e18d6152ff0f41b7f01f9817372022df04e0d354
--
2.38.0.rc1.362.ged0d419d3c-goog
next reply other threads:[~2022-10-06 0:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 0:03 Sean Christopherson [this message]
2022-10-06 0:03 ` [PATCH v5 1/8] perf/x86/core: Zero @lbr instead of returning -1 in x86_perf_get_lbr() stub Sean Christopherson
2022-10-06 0:03 ` [PATCH v5 2/8] KVM: VMX: Advertise PMU LBRs if and only if perf supports LBRs Sean Christopherson
2022-10-06 0:03 ` [PATCH v5 3/8] KVM: VMX: Fold vmx_supported_debugctl() into vcpu_supported_debugctl() Sean Christopherson
2022-10-06 0:03 ` [PATCH v5 4/8] KVM: VMX: Ignore guest CPUID for host userspace writes to DEBUGCTL Sean Christopherson
2022-10-06 0:03 ` [PATCH v5 5/8] KVM: x86: Track supported PERF_CAPABILITIES in kvm_caps Sean Christopherson
2022-10-14 9:25 ` Like Xu
2022-10-06 0:03 ` [PATCH v5 6/8] KVM: x86: Init vcpu->arch.perf_capabilities in common x86 code Sean Christopherson
2022-10-06 0:03 ` [PATCH v5 7/8] KVM: x86: Handle PERF_CAPABILITIES in common x86's kvm_get_msr_feature() Sean Christopherson
2022-10-06 0:03 ` [PATCH v5 8/8] KVM: x86: Directly query supported PERF_CAPABILITIES for WRMSR checks Sean Christopherson
2022-11-02 17:18 ` [PATCH v5 0/8] KVM: x86: Intel LBR related perf cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006000314.73240-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).