From: Timothy Pearson <tpearson@raptorengineering.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
Date: Tue, 7 Mar 2023 17:04:08 -0600 (CST) [thread overview]
Message-ID: <2041059418.17313605.1678230248429.JavaMail.zimbra@raptorengineeringinc.com> (raw)
In-Reply-To: <20230306175941.1b69bb14.alex.williamson@redhat.com>
----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 6:59:41 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
>
>> ----- Original Message -----
>> > From: "Alex Williamson" <alex.williamson@redhat.com>
>> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
>> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> > Sent: Monday, March 6, 2023 5:46:07 PM
>> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>
>> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
>> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
>> >
>> >> This patch series reenables VFIO support on POWER systems. It
>> >> is based on Alexey Kardashevskiys's patch series, rebased and
>> >> successfully tested under QEMU with a Marvell PCIe SATA controller
>> >> on a POWER9 Blackbird host.
>> >>
>> >> Alexey Kardashevskiy (3):
>> >> powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> >> powerpc/pci_64: Init pcibios subsys a bit later
>> >> powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> >> domains
>> >>
>> >> Timothy Pearson (1):
>> >> Add myself to MAINTAINERS for Power VFIO support
>> >>
>> >> MAINTAINERS | 5 +
>> >> arch/powerpc/include/asm/iommu.h | 6 +-
>> >> arch/powerpc/include/asm/pci-bridge.h | 7 +
>> >> arch/powerpc/kernel/iommu.c | 246 +++++++++++++++++++++-
>> >> arch/powerpc/kernel/pci_64.c | 2 +-
>> >> arch/powerpc/platforms/powernv/pci-ioda.c | 36 +++-
>> >> arch/powerpc/platforms/pseries/iommu.c | 27 +++
>> >> arch/powerpc/platforms/pseries/pseries.h | 4 +
>> >> arch/powerpc/platforms/pseries/setup.c | 3 +
>> >> drivers/vfio/vfio_iommu_spapr_tce.c | 96 ++-------
>> >> 10 files changed, 338 insertions(+), 94 deletions(-)
>> >>
>> >
>> > For vfio and MAINTAINERS portions,
>> >
>> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
>> >
>> > I'll note though that spapr_tce_take_ownership() looks like it copied a
>> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
>> > are tested before calling iommu_take_ownership() but not in the unwind
>> > loop, ie. tables we might have skipped on setup are unconditionally
>> > released on unwind. Thanks,
>> >
>> > Alex
>>
>> Thanks for that. I'll put together a patch to get rid of that
>> potential bug that can be applied after this series is merged, unless
>> you'd rather I resubmit a v3 with the issue fixed?
>
> Follow-up fix is fine by me. Thanks,
>
> Alex
Just sent that patch in. Thanks!
next prev parent reply other threads:[~2023-03-07 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 17:29 [PATCH v2 0/4] Reenable VFIO support on POWER systems Timothy Pearson
2023-03-06 23:46 ` Alex Williamson
2023-03-07 0:35 ` Timothy Pearson
2023-03-07 0:59 ` Alex Williamson
2023-03-07 23:04 ` Timothy Pearson [this message]
2023-03-07 0:51 ` Alexey Kardashevskiy
2023-03-09 11:38 ` Michael Ellerman
2023-03-09 11:40 ` Michael Ellerman
2023-03-09 19:28 ` Timothy Pearson
2023-03-18 19:06 ` Timothy Pearson
2023-03-21 10:33 ` Michael Ellerman
2023-03-21 13:18 ` Timothy Pearson
2023-03-21 21:43 ` Michael Ellerman
2023-03-23 6:49 ` Narayana Murty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2041059418.17313605.1678230248429.JavaMail.zimbra@raptorengineeringinc.com \
--to=tpearson@raptorengineering.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).