* [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM
@ 2020-07-11 16:14 Nadav Amit
2020-07-13 15:23 ` Thomas Huth
2020-07-13 23:01 ` Krish Sadhukhan
0 siblings, 2 replies; 4+ messages in thread
From: Nadav Amit @ 2020-07-11 16:14 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, Nadav Amit
FW_CFG_MAX_ENTRY should obviously be the last entry.
Signed-off-by: Nadav Amit <namit@vmware.com>
---
lib/x86/fwcfg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/x86/fwcfg.h b/lib/x86/fwcfg.h
index 64d4c6e..8095d8a 100644
--- a/lib/x86/fwcfg.h
+++ b/lib/x86/fwcfg.h
@@ -20,8 +20,8 @@
#define FW_CFG_NUMA 0x0d
#define FW_CFG_BOOT_MENU 0x0e
#define FW_CFG_MAX_CPUS 0x0f
-#define FW_CFG_MAX_ENTRY 0x10
-#define FW_CFG_MAX_RAM 0x11
+#define FW_CFG_MAX_RAM 0x10
+#define FW_CFG_MAX_ENTRY 0x11
#define FW_CFG_WRITE_CHANNEL 0x4000
#define FW_CFG_ARCH_LOCAL 0x8000
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM
2020-07-11 16:14 [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM Nadav Amit
@ 2020-07-13 15:23 ` Thomas Huth
2020-07-13 19:44 ` Nadav Amit
2020-07-13 23:01 ` Krish Sadhukhan
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2020-07-13 15:23 UTC (permalink / raw)
To: Nadav Amit, Paolo Bonzini; +Cc: kvm
On 11/07/2020 18.14, Nadav Amit wrote:
> FW_CFG_MAX_ENTRY should obviously be the last entry.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> lib/x86/fwcfg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/x86/fwcfg.h b/lib/x86/fwcfg.h
> index 64d4c6e..8095d8a 100644
> --- a/lib/x86/fwcfg.h
> +++ b/lib/x86/fwcfg.h
> @@ -20,8 +20,8 @@
> #define FW_CFG_NUMA 0x0d
> #define FW_CFG_BOOT_MENU 0x0e
> #define FW_CFG_MAX_CPUS 0x0f
> -#define FW_CFG_MAX_ENTRY 0x10
> -#define FW_CFG_MAX_RAM 0x11
> +#define FW_CFG_MAX_RAM 0x10
> +#define FW_CFG_MAX_ENTRY 0x11
That should hopefully also fix the problem with Clang that I've just seen:
https://gitlab.com/huth/kvm-unit-tests/-/jobs/635782173#L1372
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM
2020-07-13 15:23 ` Thomas Huth
@ 2020-07-13 19:44 ` Nadav Amit
0 siblings, 0 replies; 4+ messages in thread
From: Nadav Amit @ 2020-07-13 19:44 UTC (permalink / raw)
To: Thomas Huth; +Cc: Paolo Bonzini, kvm
> On Jul 13, 2020, at 8:23 AM, Thomas Huth <thuth@redhat.com> wrote:
>
> On 11/07/2020 18.14, Nadav Amit wrote:
>> FW_CFG_MAX_ENTRY should obviously be the last entry.
>>
>> Signed-off-by: Nadav Amit <namit@vmware.com>
>> ---
>> lib/x86/fwcfg.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/x86/fwcfg.h b/lib/x86/fwcfg.h
>> index 64d4c6e..8095d8a 100644
>> --- a/lib/x86/fwcfg.h
>> +++ b/lib/x86/fwcfg.h
>> @@ -20,8 +20,8 @@
>> #define FW_CFG_NUMA 0x0d
>> #define FW_CFG_BOOT_MENU 0x0e
>> #define FW_CFG_MAX_CPUS 0x0f
>> -#define FW_CFG_MAX_ENTRY 0x10
>> -#define FW_CFG_MAX_RAM 0x11
>> +#define FW_CFG_MAX_RAM 0x10
>> +#define FW_CFG_MAX_ENTRY 0x11
>
> That should hopefully also fix the problem with Clang that I've just seen:
>
> https://gitlab.com/huth/kvm-unit-tests/-/jobs/635782173#L1372
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Indeed. Sorry for that. It happened since I cut some corners due to the long
cycles of rebooting and testing bare-metal machine (bad excuse).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM
2020-07-11 16:14 [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM Nadav Amit
2020-07-13 15:23 ` Thomas Huth
@ 2020-07-13 23:01 ` Krish Sadhukhan
1 sibling, 0 replies; 4+ messages in thread
From: Krish Sadhukhan @ 2020-07-13 23:01 UTC (permalink / raw)
To: Nadav Amit, Paolo Bonzini; +Cc: kvm
On 7/11/20 9:14 AM, Nadav Amit wrote:
> FW_CFG_MAX_ENTRY should obviously be the last entry.
>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
> lib/x86/fwcfg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/x86/fwcfg.h b/lib/x86/fwcfg.h
> index 64d4c6e..8095d8a 100644
> --- a/lib/x86/fwcfg.h
> +++ b/lib/x86/fwcfg.h
> @@ -20,8 +20,8 @@
> #define FW_CFG_NUMA 0x0d
> #define FW_CFG_BOOT_MENU 0x0e
> #define FW_CFG_MAX_CPUS 0x0f
> -#define FW_CFG_MAX_ENTRY 0x10
> -#define FW_CFG_MAX_RAM 0x11
> +#define FW_CFG_MAX_RAM 0x10
> +#define FW_CFG_MAX_ENTRY 0x11
>
> #define FW_CFG_WRITE_CHANNEL 0x4000
> #define FW_CFG_ARCH_LOCAL 0x8000
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-13 23:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-11 16:14 [kvm-unit-tests PATCH] x86: reverse FW_CFG_MAX_ENTRY and FW_CFG_MAX_RAM Nadav Amit
2020-07-13 15:23 ` Thomas Huth
2020-07-13 19:44 ` Nadav Amit
2020-07-13 23:01 ` Krish Sadhukhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).