From: Pierre Morel <pmorel@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com,
david@redhat.com, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 2/9] s390x: Define the PSW bits
Date: Mon, 9 Dec 2019 09:53:22 +0100 [thread overview]
Message-ID: <36847ac9-fef4-1eea-8b3a-d8a94a989a6e@linux.ibm.com> (raw)
In-Reply-To: <4d034f27-0449-08ea-5b45-be91a788bd6d@redhat.com>
On 2019-12-06 17:29, Thomas Huth wrote:
> On 06/12/2019 17.26, Pierre Morel wrote:
>> Let's define the PSW bits explicitly, it will clarify their
>> usage.
>>
>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>> ---
>> lib/s390x/asm/arch_def.h | 127 +++++++++++++++++++++------------------
>> s390x/cstart64.S | 13 ++--
>> 2 files changed, 74 insertions(+), 66 deletions(-)
>>
>> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
>> index cf6e1ca..1293640 100644
>> --- a/lib/s390x/asm/arch_def.h
>> +++ b/lib/s390x/asm/arch_def.h
>> @@ -10,20 +10,81 @@
>> #ifndef _ASM_S390X_ARCH_DEF_H_
>> #define _ASM_S390X_ARCH_DEF_H_
>>
>> -struct psw {
>> - uint64_t mask;
>> - uint64_t addr;
>> -};
>> -
>> #define PSW_MASK_EXT 0x0100000000000000UL
>> #define PSW_MASK_DAT 0x0400000000000000UL
>> #define PSW_MASK_PSTATE 0x0001000000000000UL
>> +#define PSW_MASK_IO 0x0200000000000000
>> +#define PSW_MASK_EA 0x0000000100000000
>> +#define PSW_MASK_BA 0x0000000080000000
>> +
>> +#define PSW_EXCEPTION_MASK (PSW_MASK_EA|PSW_MASK_BA)
>>
>> #define CR0_EXTM_SCLP 0X0000000000000200UL
>> #define CR0_EXTM_EXTC 0X0000000000002000UL
>> #define CR0_EXTM_EMGC 0X0000000000004000UL
>> #define CR0_EXTM_MASK 0X0000000000006200UL
>>
>> +#define PGM_INT_CODE_OPERATION 0x01
>> +#define PGM_INT_CODE_PRIVILEGED_OPERATION 0x02
>> +#define PGM_INT_CODE_EXECUTE 0x03
>> +#define PGM_INT_CODE_PROTECTION 0x04
>> +#define PGM_INT_CODE_ADDRESSING 0x05
>> +#define PGM_INT_CODE_SPECIFICATION 0x06
>> +#define PGM_INT_CODE_DATA 0x07
>> +#define PGM_INT_CODE_FIXED_POINT_OVERFLOW 0x08
>> +#define PGM_INT_CODE_FIXED_POINT_DIVIDE 0x09
>> +#define PGM_INT_CODE_DECIMAL_OVERFLOW 0x0a
>> +#define PGM_INT_CODE_DECIMAL_DIVIDE 0x0b
>> +#define PGM_INT_CODE_HFP_EXPONENT_OVERFLOW 0x0c
>> +#define PGM_INT_CODE_HFP_EXPONENT_UNDERFLOW 0x0d
>> +#define PGM_INT_CODE_HFP_SIGNIFICANCE 0x0e
>> +#define PGM_INT_CODE_HFP_DIVIDE 0x0f
>> +#define PGM_INT_CODE_SEGMENT_TRANSLATION 0x10
>> +#define PGM_INT_CODE_PAGE_TRANSLATION 0x11
>> +#define PGM_INT_CODE_TRANSLATION_SPEC 0x12
>> +#define PGM_INT_CODE_SPECIAL_OPERATION 0x13
>> +#define PGM_INT_CODE_OPERAND 0x15
>> +#define PGM_INT_CODE_TRACE_TABLE 0x16
>> +#define PGM_INT_CODE_VECTOR_PROCESSING 0x1b
>> +#define PGM_INT_CODE_SPACE_SWITCH_EVENT 0x1c
>> +#define PGM_INT_CODE_HFP_SQUARE_ROOT 0x1d
>> +#define PGM_INT_CODE_PC_TRANSLATION_SPEC 0x1f
>> +#define PGM_INT_CODE_AFX_TRANSLATION 0x20
>> +#define PGM_INT_CODE_ASX_TRANSLATION 0x21
>> +#define PGM_INT_CODE_LX_TRANSLATION 0x22
>> +#define PGM_INT_CODE_EX_TRANSLATION 0x23
>> +#define PGM_INT_CODE_PRIMARY_AUTHORITY 0x24
>> +#define PGM_INT_CODE_SECONDARY_AUTHORITY 0x25
>> +#define PGM_INT_CODE_LFX_TRANSLATION 0x26
>> +#define PGM_INT_CODE_LSX_TRANSLATION 0x27
>> +#define PGM_INT_CODE_ALET_SPECIFICATION 0x28
>> +#define PGM_INT_CODE_ALEN_TRANSLATION 0x29
>> +#define PGM_INT_CODE_ALE_SEQUENCE 0x2a
>> +#define PGM_INT_CODE_ASTE_VALIDITY 0x2b
>> +#define PGM_INT_CODE_ASTE_SEQUENCE 0x2c
>> +#define PGM_INT_CODE_EXTENDED_AUTHORITY 0x2d
>> +#define PGM_INT_CODE_LSTE_SEQUENCE 0x2e
>> +#define PGM_INT_CODE_ASTE_INSTANCE 0x2f
>> +#define PGM_INT_CODE_STACK_FULL 0x30
>> +#define PGM_INT_CODE_STACK_EMPTY 0x31
>> +#define PGM_INT_CODE_STACK_SPECIFICATION 0x32
>> +#define PGM_INT_CODE_STACK_TYPE 0x33
>> +#define PGM_INT_CODE_STACK_OPERATION 0x34
>> +#define PGM_INT_CODE_ASCE_TYPE 0x38
>> +#define PGM_INT_CODE_REGION_FIRST_TRANS 0x39
>> +#define PGM_INT_CODE_REGION_SECOND_TRANS 0x3a
>> +#define PGM_INT_CODE_REGION_THIRD_TRANS 0x3b
>> +#define PGM_INT_CODE_MONITOR_EVENT 0x40
>> +#define PGM_INT_CODE_PER 0x80
>> +#define PGM_INT_CODE_CRYPTO_OPERATION 0x119
>> +#define PGM_INT_CODE_TX_ABORTED_EVENT 0x200
>> +
>> +#ifndef __ASSEMBLER__
>> +struct psw {
>> + uint64_t mask;
>> + uint64_t addr;
>> +};
>> +
>> struct lowcore {
>> uint8_t pad_0x0000[0x0080 - 0x0000]; /* 0x0000 */
>> uint32_t ext_int_param; /* 0x0080 */
>> @@ -101,61 +162,6 @@ struct lowcore {
>> } __attribute__ ((__packed__));
>> _Static_assert(sizeof(struct lowcore) == 0x1900, "Lowcore size");
>>
>> -#define PGM_INT_CODE_OPERATION 0x01
>> -#define PGM_INT_CODE_PRIVILEGED_OPERATION 0x02
>> -#define PGM_INT_CODE_EXECUTE 0x03
>> -#define PGM_INT_CODE_PROTECTION 0x04
>> -#define PGM_INT_CODE_ADDRESSING 0x05
>> -#define PGM_INT_CODE_SPECIFICATION 0x06
>> -#define PGM_INT_CODE_DATA 0x07
>> -#define PGM_INT_CODE_FIXED_POINT_OVERFLOW 0x08
>> -#define PGM_INT_CODE_FIXED_POINT_DIVIDE 0x09
>> -#define PGM_INT_CODE_DECIMAL_OVERFLOW 0x0a
>> -#define PGM_INT_CODE_DECIMAL_DIVIDE 0x0b
>> -#define PGM_INT_CODE_HFP_EXPONENT_OVERFLOW 0x0c
>> -#define PGM_INT_CODE_HFP_EXPONENT_UNDERFLOW 0x0d
>> -#define PGM_INT_CODE_HFP_SIGNIFICANCE 0x0e
>> -#define PGM_INT_CODE_HFP_DIVIDE 0x0f
>> -#define PGM_INT_CODE_SEGMENT_TRANSLATION 0x10
>> -#define PGM_INT_CODE_PAGE_TRANSLATION 0x11
>> -#define PGM_INT_CODE_TRANSLATION_SPEC 0x12
>> -#define PGM_INT_CODE_SPECIAL_OPERATION 0x13
>> -#define PGM_INT_CODE_OPERAND 0x15
>> -#define PGM_INT_CODE_TRACE_TABLE 0x16
>> -#define PGM_INT_CODE_VECTOR_PROCESSING 0x1b
>> -#define PGM_INT_CODE_SPACE_SWITCH_EVENT 0x1c
>> -#define PGM_INT_CODE_HFP_SQUARE_ROOT 0x1d
>> -#define PGM_INT_CODE_PC_TRANSLATION_SPEC 0x1f
>> -#define PGM_INT_CODE_AFX_TRANSLATION 0x20
>> -#define PGM_INT_CODE_ASX_TRANSLATION 0x21
>> -#define PGM_INT_CODE_LX_TRANSLATION 0x22
>> -#define PGM_INT_CODE_EX_TRANSLATION 0x23
>> -#define PGM_INT_CODE_PRIMARY_AUTHORITY 0x24
>> -#define PGM_INT_CODE_SECONDARY_AUTHORITY 0x25
>> -#define PGM_INT_CODE_LFX_TRANSLATION 0x26
>> -#define PGM_INT_CODE_LSX_TRANSLATION 0x27
>> -#define PGM_INT_CODE_ALET_SPECIFICATION 0x28
>> -#define PGM_INT_CODE_ALEN_TRANSLATION 0x29
>> -#define PGM_INT_CODE_ALE_SEQUENCE 0x2a
>> -#define PGM_INT_CODE_ASTE_VALIDITY 0x2b
>> -#define PGM_INT_CODE_ASTE_SEQUENCE 0x2c
>> -#define PGM_INT_CODE_EXTENDED_AUTHORITY 0x2d
>> -#define PGM_INT_CODE_LSTE_SEQUENCE 0x2e
>> -#define PGM_INT_CODE_ASTE_INSTANCE 0x2f
>> -#define PGM_INT_CODE_STACK_FULL 0x30
>> -#define PGM_INT_CODE_STACK_EMPTY 0x31
>> -#define PGM_INT_CODE_STACK_SPECIFICATION 0x32
>> -#define PGM_INT_CODE_STACK_TYPE 0x33
>> -#define PGM_INT_CODE_STACK_OPERATION 0x34
>> -#define PGM_INT_CODE_ASCE_TYPE 0x38
>> -#define PGM_INT_CODE_REGION_FIRST_TRANS 0x39
>> -#define PGM_INT_CODE_REGION_SECOND_TRANS 0x3a
>> -#define PGM_INT_CODE_REGION_THIRD_TRANS 0x3b
>> -#define PGM_INT_CODE_MONITOR_EVENT 0x40
>> -#define PGM_INT_CODE_PER 0x80
>> -#define PGM_INT_CODE_CRYPTO_OPERATION 0x119
>> -#define PGM_INT_CODE_TX_ABORTED_EVENT 0x200
>
> This patch definitely does more than you've mentioned in the patch
> description. Please avoid the movement of the PGM definitions here and
> move that into a separate patch (if it is really necessary).
>
> Thomas
>
OK, thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2019-12-09 8:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 16:26 [kvm-unit-tests PATCH v3 0/9] s390x: Testing the Channel Subsystem I/O Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 1/9] s390x: saving regs for interrupts Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 2/9] s390x: Define the PSW bits Pierre Morel
2019-12-06 16:29 ` Thomas Huth
2019-12-09 8:53 ` Pierre Morel [this message]
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 3/9] s390: interrupt registration Pierre Morel
2019-12-09 11:40 ` Thomas Huth
2019-12-09 16:44 ` Pierre Morel
2019-12-09 11:48 ` David Hildenbrand
2019-12-09 16:44 ` Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 4/9] s390x: export the clock get_clock_ms() utility Pierre Morel
2019-12-09 11:42 ` Thomas Huth
2019-12-09 11:49 ` David Hildenbrand
2019-12-09 16:43 ` Pierre Morel
2019-12-09 16:44 ` Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 5/9] s390x: Library resources for CSS tests Pierre Morel
2019-12-09 11:49 ` Thomas Huth
2019-12-09 16:43 ` Pierre Morel
2019-12-10 10:07 ` Pierre Morel
2019-12-10 10:28 ` Thomas Huth
2019-12-10 11:22 ` Pierre Morel
2019-12-10 11:27 ` Thomas Huth
2019-12-10 11:28 ` Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 6/9] s390x: css: stsch, enumeration test Pierre Morel
2019-12-09 11:52 ` Thomas Huth
2019-12-09 16:42 ` Pierre Morel
2019-12-09 16:49 ` Cornelia Huck
2019-12-10 8:56 ` Pierre Morel
2019-12-10 11:37 ` Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 7/9] s390x: css: msch, enable test Pierre Morel
2019-12-09 16:54 ` Cornelia Huck
2019-12-10 9:01 ` Pierre Morel
2019-12-10 9:09 ` Cornelia Huck
2019-12-10 17:35 ` Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 8/9] s390x: css: ssch/tsch with sense and interrupt Pierre Morel
2019-12-09 17:22 ` Cornelia Huck
2019-12-10 9:12 ` Pierre Morel
2019-12-06 16:26 ` [kvm-unit-tests PATCH v3 9/9] s390x: css: ping pong Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36847ac9-fef4-1eea-8b3a-d8a94a989a6e@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).