From: gengdongjiu <gengdongjiu@huawei.com>
To: Igor Mammedov <imammedo@redhat.com>,
Xiang Zheng <zhengxiang9@huawei.com>
Cc: <pbonzini@redhat.com>, <mst@redhat.com>,
<shannon.zhaosl@gmail.com>, <peter.maydell@linaro.org>,
<lersek@redhat.com>, <james.morse@arm.com>, <mtosatti@redhat.com>,
<rth@twiddle.net>, <ehabkost@redhat.com>,
<jonathan.cameron@huawei.com>, <xuwei5@huawei.com>,
<kvm@vger.kernel.org>, <qemu-devel@nongnu.org>,
<qemu-arm@nongnu.org>, <linuxarm@huawei.com>,
<wanghaibin.wang@huawei.com>
Subject: Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM
Date: Sat, 21 Dec 2019 20:35:44 +0800 [thread overview]
Message-ID: <38f13f15-960d-3e56-78f5-42b1ec61a322@huawei.com> (raw)
In-Reply-To: <20191115173713.795e5f63@redhat.com>
On 2019/11/16 0:37, Igor Mammedov wrote:
>> +
>> + /* zero means OSPM does not acknowledge the error */
>> + if (!read_ack_register) {
>> + if (loop < 3) {
>> + usleep(100 * 1000);
>> + loop++;
>> + goto retry;
> as minimum this loop can stall guest repeatedly for 0.3s if guest triggers BQL,
> until it handles error.
I think reparations for 0.3s is reasonable.
1. 0.3s is the worst case to repeat, if guest acknowledge it in before 0.3s, the guest can not stall
2. if the previous error is not acknowledged, the next error will be lost, error handling(safety) is more important than others.
>
> (not sure what to suggest here though)
>
> (not sure what to suggest here though)
>
next prev parent reply other threads:[~2019-12-21 12:37 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 1:40 [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU Xiang Zheng
2019-11-11 1:40 ` [RESEND PATCH v21 1/6] hw/arm/virt: Introduce a RAS machine option Xiang Zheng
2019-12-02 18:22 ` Peter Maydell
2019-12-07 12:10 ` gengdongjiu
2019-11-11 1:40 ` [RESEND PATCH v21 2/6] docs: APEI GHES generation and CPER record description Xiang Zheng
2019-11-15 9:44 ` Igor Mammedov
2019-11-27 1:37 ` Xiang Zheng
2019-11-27 8:12 ` Igor Mammedov
2019-11-11 1:40 ` [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Xiang Zheng
2019-11-15 9:38 ` Igor Mammedov
2019-11-18 12:49 ` gengdongjiu
2019-11-18 13:18 ` gengdongjiu
2019-11-18 13:21 ` Michael S. Tsirkin
2019-11-18 13:57 ` gengdongjiu
2019-11-25 9:48 ` Igor Mammedov
2019-11-27 11:16 ` gengdongjiu
2019-11-22 15:44 ` Beata Michalska
2019-11-22 15:42 ` Beata Michalska
2019-11-25 9:23 ` Igor Mammedov
2019-11-11 1:40 ` [RESEND PATCH v21 4/6] KVM: Move hwpoison page related functions into kvm-all.c Xiang Zheng
2019-12-02 18:23 ` Peter Maydell
2019-11-11 1:40 ` [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Xiang Zheng
2019-11-15 16:37 ` Igor Mammedov
2019-11-22 15:47 ` Beata Michalska
2019-11-25 9:37 ` Igor Mammedov
2019-11-27 1:40 ` Xiang Zheng
2019-11-27 10:43 ` Igor Mammedov
2019-12-21 12:35 ` gengdongjiu [this message]
2019-11-22 15:47 ` Beata Michalska
2019-11-27 12:47 ` Xiang Zheng
2019-11-27 13:02 ` Igor Mammedov
2019-11-27 14:17 ` Beata Michalska
2019-12-03 3:35 ` Xiang Zheng
2019-11-27 14:17 ` Beata Michalska
2019-12-03 3:35 ` Xiang Zheng
2019-12-07 9:33 ` gengdongjiu
2019-12-09 13:05 ` Beata Michalska
2019-12-09 14:12 ` gengdongjiu
2019-11-11 1:40 ` [RESEND PATCH v21 6/6] MAINTAINERS: Add APCI/APEI/GHES entries Xiang Zheng
2019-12-02 18:27 ` [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU Peter Maydell
2019-12-03 2:09 ` gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f13f15-960d-3e56-78f5-42b1ec61a322@huawei.com \
--to=gengdongjiu@huawei.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
--cc=xuwei5@huawei.com \
--cc=zhengxiang9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).