Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test

From: Dor Laor <dlaor@redhat.com>
To: Jiri Zupka <jzupka@redhat.com>
Cc: kvm@vger.kernel.org, autotest@test.kernel.org,
	Lukas Doktor <ldoktor@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test
Date: Wed, 16 Sep 2009 11:56:40 +0300	[thread overview]
Message-ID: <4AB0A848.70309@redhat.com> (raw)
In-Reply-To: <214789605.186631253041136557.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>

On 09/15/2009 09:58 PM, Jiri Zupka wrote:
>> After a quick review I have the following questions:
>> 1. Why did you implement the guest tool in 'c' and not in python?
>>    Python is much simpler and you can share some code with the server.
>>    This 'test protocol' would also be easier to understand this way.
>
> We need speed and the precise control of allocate memory in pages.
>
>> 2. IMHO there is no need to use select, you can do blocking read.
>
> We replace socket communication by interactive program communication via ssh/telnet
>
>> 3. Also you can use plain malloc without the more complex ( a bit) mmap.
>
> We need address exactly the memory pages. We can't allow shift of the data in memory.

You can use the tmpfs+dd idea instead of the specific program as I 
detailed before. Maybe some other binary can be used. My intention is to 
simplify the test/environment as much as possible.

> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html