kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Zupka <jzupka@redhat.com>
To: kvm@vger.kernel.org, autotest@test.kernel.org
Cc: Lukas Doktor <ldoktor@redhat.com>, dlaor@redhat.com
Subject: Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test
Date: Tue, 15 Sep 2009 14:58:56 -0400 (EDT)	[thread overview]
Message-ID: <214789605.186631253041136557.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1785968988.186531253041095308.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>

> After a quick review I have the following questions:
> 1. Why did you implement the guest tool in 'c' and not in python?
>   Python is much simpler and you can share some code with the server.
>   This 'test protocol' would also be easier to understand this way.

We need speed and the precise control of allocate memory in pages. 

> 2. IMHO there is no need to use select, you can do blocking read.

We replace socket communication by interactive program communication via ssh/telnet

> 3. Also you can use plain malloc without the more complex ( a bit) mmap.

We need address exactly the memory pages. We can't allow shift of the data in memory. 

       reply	other threads:[~2009-09-15 18:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1785968988.186531253041095308.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-09-15 18:58 ` Jiri Zupka [this message]
2009-09-16  8:56   ` [KVM-AUTOTEST PATCH 1/2] Add KSM test Dor Laor
     [not found] <830286859.775301253870289468.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-09-25  9:22 ` Jiri Zupka
2009-09-29 15:50   ` Lucas Meneghel Rodrigues
2009-09-30 12:23     ` Dor Laor
     [not found] <83259492.232221253106465155.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-09-16 13:09 ` Jiri Zupka
2009-09-16 13:21   ` Dor Laor
2009-08-31  9:29 [KVM-AUTOTEST PATCH 0/2] " Lukáš Doktor
2009-08-31  9:35 ` [KVM-AUTOTEST PATCH 1/2] " Lukáš Doktor
2009-09-01  8:49   ` Lukáš Doktor
2009-09-07 12:03   ` Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=214789605.186631253041136557.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com \
    --to=jzupka@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=dlaor@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ldoktor@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).