* [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable
@ 2021-10-07 7:21 Thomas Huth
2021-10-07 7:31 ` Claudio Imbrenda
2021-10-07 8:14 ` Janosch Frank
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2021-10-07 7:21 UTC (permalink / raw)
To: kvm, Janosch Frank; +Cc: linux-s390, Claudio Imbrenda, David Hildenbrand
The guest_instr variable is not used, which was likely a
copy-n-paste issue from the s390x/sie.c test.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
s390x/mvpg-sie.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
index ccc273b..5adcec1 100644
--- a/s390x/mvpg-sie.c
+++ b/s390x/mvpg-sie.c
@@ -21,7 +21,6 @@
#include <sie.h>
static u8 *guest;
-static u8 *guest_instr;
static struct vm vm;
static uint8_t *src;
@@ -94,8 +93,6 @@ static void setup_guest(void)
/* Allocate 1MB as guest memory */
guest = alloc_pages(8);
- /* The first two pages are the lowcore */
- guest_instr = guest + PAGE_SIZE * 2;
sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable
2021-10-07 7:21 [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable Thomas Huth
@ 2021-10-07 7:31 ` Claudio Imbrenda
2021-10-07 8:14 ` Janosch Frank
1 sibling, 0 replies; 3+ messages in thread
From: Claudio Imbrenda @ 2021-10-07 7:31 UTC (permalink / raw)
To: Thomas Huth; +Cc: kvm, Janosch Frank, linux-s390, David Hildenbrand
On Thu, 7 Oct 2021 09:21:36 +0200
Thomas Huth <thuth@redhat.com> wrote:
> The guest_instr variable is not used, which was likely a
> copy-n-paste issue from the s390x/sie.c test.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/mvpg-sie.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index ccc273b..5adcec1 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -21,7 +21,6 @@
> #include <sie.h>
>
> static u8 *guest;
> -static u8 *guest_instr;
> static struct vm vm;
>
> static uint8_t *src;
> @@ -94,8 +93,6 @@ static void setup_guest(void)
>
> /* Allocate 1MB as guest memory */
> guest = alloc_pages(8);
> - /* The first two pages are the lowcore */
> - guest_instr = guest + PAGE_SIZE * 2;
>
> sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable
2021-10-07 7:21 [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable Thomas Huth
2021-10-07 7:31 ` Claudio Imbrenda
@ 2021-10-07 8:14 ` Janosch Frank
1 sibling, 0 replies; 3+ messages in thread
From: Janosch Frank @ 2021-10-07 8:14 UTC (permalink / raw)
To: Thomas Huth, kvm; +Cc: linux-s390, Claudio Imbrenda, David Hildenbrand
On 10/7/21 09:21, Thomas Huth wrote:
> The guest_instr variable is not used, which was likely a
> copy-n-paste issue from the s390x/sie.c test.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Janosch Fran <frankja@linux.ibm.com>
Thanks, picked.
Weird that the compiler didn't complain with a set but not used message...
> ---
> s390x/mvpg-sie.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index ccc273b..5adcec1 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -21,7 +21,6 @@
> #include <sie.h>
>
> static u8 *guest;
> -static u8 *guest_instr;
> static struct vm vm;
>
> static uint8_t *src;
> @@ -94,8 +93,6 @@ static void setup_guest(void)
>
> /* Allocate 1MB as guest memory */
> guest = alloc_pages(8);
> - /* The first two pages are the lowcore */
> - guest_instr = guest + PAGE_SIZE * 2;
>
> sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-07 8:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 7:21 [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable Thomas Huth
2021-10-07 7:31 ` Claudio Imbrenda
2021-10-07 8:14 ` Janosch Frank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).