* [PATCH] vhost: Fix vhost_vq_reset()
@ 2021-03-12 14:09 Laurent Vivier
2021-03-15 8:31 ` Jason Wang
2021-03-17 8:26 ` Stefano Garzarella
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-03-12 14:09 UTC (permalink / raw)
To: linux-kernel; +Cc: virtualization, Jason Wang, netdev, Michael S. Tsirkin, kvm
vhost_reset_is_le() is vhost_init_is_le(), and in the case of
cross-endian legacy, vhost_init_is_le() depends on vq->user_be.
vq->user_be is set by vhost_disable_cross_endian().
But in vhost_vq_reset(), we have:
vhost_reset_is_le(vq);
vhost_disable_cross_endian(vq);
And so user_be is used before being set.
To fix that, reverse the lines order as there is no other dependency
between them.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
drivers/vhost/vhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index a262e12c6dc2..5ccb0705beae 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -332,8 +332,8 @@ static void vhost_vq_reset(struct vhost_dev *dev,
vq->error_ctx = NULL;
vq->kick = NULL;
vq->log_ctx = NULL;
- vhost_reset_is_le(vq);
vhost_disable_cross_endian(vq);
+ vhost_reset_is_le(vq);
vq->busyloop_timeout = 0;
vq->umem = NULL;
vq->iotlb = NULL;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: Fix vhost_vq_reset()
2021-03-12 14:09 [PATCH] vhost: Fix vhost_vq_reset() Laurent Vivier
@ 2021-03-15 8:31 ` Jason Wang
2021-03-17 8:26 ` Stefano Garzarella
1 sibling, 0 replies; 3+ messages in thread
From: Jason Wang @ 2021-03-15 8:31 UTC (permalink / raw)
To: Laurent Vivier, linux-kernel
Cc: virtualization, netdev, Michael S. Tsirkin, kvm
在 2021/3/12 下午10:09, Laurent Vivier 写道:
> vhost_reset_is_le() is vhost_init_is_le(), and in the case of
> cross-endian legacy, vhost_init_is_le() depends on vq->user_be.
>
> vq->user_be is set by vhost_disable_cross_endian().
>
> But in vhost_vq_reset(), we have:
>
> vhost_reset_is_le(vq);
> vhost_disable_cross_endian(vq);
>
> And so user_be is used before being set.
>
> To fix that, reverse the lines order as there is no other dependency
> between them.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vhost/vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index a262e12c6dc2..5ccb0705beae 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -332,8 +332,8 @@ static void vhost_vq_reset(struct vhost_dev *dev,
> vq->error_ctx = NULL;
> vq->kick = NULL;
> vq->log_ctx = NULL;
> - vhost_reset_is_le(vq);
> vhost_disable_cross_endian(vq);
> + vhost_reset_is_le(vq);
> vq->busyloop_timeout = 0;
> vq->umem = NULL;
> vq->iotlb = NULL;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: Fix vhost_vq_reset()
2021-03-12 14:09 [PATCH] vhost: Fix vhost_vq_reset() Laurent Vivier
2021-03-15 8:31 ` Jason Wang
@ 2021-03-17 8:26 ` Stefano Garzarella
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2021-03-17 8:26 UTC (permalink / raw)
To: Laurent Vivier
Cc: linux-kernel, virtualization, Jason Wang, netdev,
Michael S. Tsirkin, kvm
On Fri, Mar 12, 2021 at 03:09:13PM +0100, Laurent Vivier wrote:
>vhost_reset_is_le() is vhost_init_is_le(), and in the case of
>cross-endian legacy, vhost_init_is_le() depends on vq->user_be.
>
>vq->user_be is set by vhost_disable_cross_endian().
>
>But in vhost_vq_reset(), we have:
>
> vhost_reset_is_le(vq);
> vhost_disable_cross_endian(vq);
>
>And so user_be is used before being set.
>
>To fix that, reverse the lines order as there is no other dependency
>between them.
>
>Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>---
> drivers/vhost/vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-17 8:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 14:09 [PATCH] vhost: Fix vhost_vq_reset() Laurent Vivier
2021-03-15 8:31 ` Jason Wang
2021-03-17 8:26 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).