From: Jingyi Wang <wangjingyi11@huawei.com>
To: Zenghui Yu <yuzenghui@huawei.com>, <drjones@redhat.com>,
<kvm@vger.kernel.org>, <kvmarm@lists.cs.columbia.edu>
Cc: <maz@kernel.org>, <wanghaibin.wang@huawei.com>, <eric.auger@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 1/6] arm64: microbench: get correct ipi recieved num
Date: Fri, 22 May 2020 10:32:25 +0800 [thread overview]
Message-ID: <8b9d51f2-3906-9e0a-38ae-564424c38ff5@huawei.com> (raw)
In-Reply-To: <8e011659-4e4d-7312-4466-5ed3ea54cc9b@huawei.com>
On 5/21/2020 10:00 PM, Zenghui Yu wrote:
> On 2020/5/17 18:08, Jingyi Wang wrote:
>> If ipi_exec() fails because of timeout, we shouldn't increase
>> the number of ipi received.
>>
>> Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com>
>> ---
>> arm/micro-bench.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arm/micro-bench.c b/arm/micro-bench.c
>> index 4612f41..ca022d9 100644
>> --- a/arm/micro-bench.c
>> +++ b/arm/micro-bench.c
>> @@ -103,7 +103,9 @@ static void ipi_exec(void)
>> while (!ipi_received && tries--)
>> cpu_relax();
>> - ++received;
>> + if (ipi_recieved)
>
> I think you may want *ipi_received* ;-) Otherwise it can not even
> compile!
>
>> + ++received;
>> +
>> assert_msg(ipi_received, "failed to receive IPI in time, but
>> received %d successfully\n", received);
>> }
>
> With this fixed, this looks good to me,
>
> Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
>
>
> Thanks.
>
> .
This variable name is modified in the next patch, so I ignored that
mistake, thanks.
Thanks,
Jingyi
next prev parent reply other threads:[~2020-05-22 2:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 10:08 [kvm-unit-tests PATCH 0/6] arm64: add IPI/LPI/vtimer latency Jingyi Wang
2020-05-17 10:08 ` [kvm-unit-tests PATCH 1/6] arm64: microbench: get correct ipi recieved num Jingyi Wang
2020-05-21 14:00 ` Zenghui Yu
2020-05-22 2:32 ` Jingyi Wang [this message]
2020-05-22 5:34 ` Andrew Jones
2020-05-17 10:08 ` [kvm-unit-tests PATCH 2/6] arm64: microbench: Use the funcions for ipi test as the general functions for gic(ipi/lpi/timer) test Jingyi Wang
2020-05-17 10:08 ` [kvm-unit-tests PATCH 3/6] arm64: microbench: gic: Add gicv4.1 support for ipi latency test Jingyi Wang
2020-05-17 10:08 ` [kvm-unit-tests PATCH 4/6] arm64: its: Handle its command queue wrapping Jingyi Wang
2020-05-17 10:08 ` [kvm-unit-tests PATCH 5/6] arm64: microbench: its: Add LPI latency test Jingyi Wang
2020-05-17 10:09 ` [kvm-unit-tests PATCH 6/6] arm64: microbench: Add vtimer " Jingyi Wang
2020-05-18 7:05 ` Andrew Jones
2020-05-20 4:16 ` Jingyi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b9d51f2-3906-9e0a-38ae-564424c38ff5@huawei.com \
--to=wangjingyi11@huawei.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
--cc=wanghaibin.wang@huawei.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).