From: Bill Wendling <morbo@google.com>
To: "Jim Mattson" <jmattson@google.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>
Subject: Re: [kvm-unit-tests PATCH] lib: use an argument which doesn't require default argument promotion
Date: Mon, 30 Sep 2019 14:59:34 -0700 [thread overview]
Message-ID: <CAGG=3QWN8+b0pB9xWnhJsCqPmu+8VDDEdCeSbi=HJCZfRW-8jg@mail.gmail.com> (raw)
In-Reply-To: <CALMp9eTm4sbr2GK+mM_ibazA9i9d4-eBcMhtZmfTf6HQbbD_Bg@mail.gmail.com>
On Tue, Sep 10, 2019 at 9:43 AM Jim Mattson <jmattson@google.com> wrote:
>
> On Mon, Sep 9, 2019 at 4:12 PM Bill Wendling <morbo@google.com> wrote:
> >
> > Clang warns that passing an object that undergoes default argument
> > promotion to "va_start" is undefined behavior:
> >
> > lib/report.c:106:15: error: passing an object that undergoes default
> > argument promotion to 'va_start' has undefined behavior
> > [-Werror,-Wvarargs]
> > va_start(va, pass);
> >
> > Using an "unsigned" type removes the need for argument promotion.
> >
> > Signed-off-by: Bill Wendling <morbo@google.com>
> Reviewed-by: Jim Mattson <jmattson@google.com>
next prev parent reply other threads:[~2019-09-30 21:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 23:11 [kvm-unit-tests PATCH] lib: use an argument which doesn't require default argument promotion Bill Wendling
2019-09-10 16:43 ` Jim Mattson
2019-09-30 21:59 ` Bill Wendling [this message]
2019-10-09 10:13 ` Paolo Bonzini
2019-10-11 14:19 ` David Hildenbrand
2019-10-11 16:24 ` Thomas Huth
2019-10-11 16:36 ` Thomas Huth
2019-10-11 18:36 ` Bill Wendling
2019-10-14 7:57 ` Thomas Huth
2019-10-14 8:12 ` David Hildenbrand
2019-10-14 8:14 ` Bill Wendling
2019-10-14 9:32 ` Thomas Huth
2019-10-14 11:04 ` Paolo Bonzini
2019-10-17 12:32 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGG=3QWN8+b0pB9xWnhJsCqPmu+8VDDEdCeSbi=HJCZfRW-8jg@mail.gmail.com' \
--to=morbo@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).