Re: [PATCH 1/2] kvm: x86: Include multiple indices with CPUID leaf 0x8000001d

Re: [PATCH 1/2] kvm: x86: Include multiple indices with CPUID leaf 0x8000001d

[Jim Mattson]

On Mon, Apr 1, 2019 at 10:06 AM Borislav Petkov <bp@suse.de> wrote:
>
> On Wed, Mar 27, 2019 at 01:15:36PM -0700, Jim Mattson wrote:
> > Per the APM, "CPUID Fn8000_001D_E[D,C,B,A]X reports cache topology
> > information for the cache enumerated by the value passed to the
> > instruction in ECX, referred to as Cache n in the following
> > description. To gather information for all cache levels, software must
> > repeatedly execute CPUID with 8000_001Dh in EAX and ECX set to
> > increasing values beginning with 0 until a value of 00h is returned in
> > the field CacheType (EAX[4:0]) indicating no more cache descriptions
> > are available for this processor."
> >
> > The termination condition is the same as leaf 4, so we can reuse that
> > code block for leaf 0x8000001d.
> >
> > Fixes: 8765d75329a38 ("KVM: X86: Extend CPUID range to include new leaf")
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Signed-off-by: Jim Mattson <jmattson@google.com>
> > Reviewed-by: Marc Orr <marcorr@google.com>
> > ---
> >  arch/x86/kvm/cpuid.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
>
> Reviewed-by: Borislav Petkov <bp@suse.de>

Paolo?

Re: [PATCH 2/2] kvm: x86: Include CPUID leaf 0x8000001e in kvm's supported CPUID

[Jim Mattson]

On Mon, Apr 1, 2019 at 10:13 AM Borislav Petkov <bp@suse.de> wrote:
>
> On Wed, Mar 27, 2019 at 01:15:37PM -0700, Jim Mattson wrote:
> > Kvm now supports extended CPUID functions through 0x8000001f.  CPUID
> > leaf 0x8000001e is AMD's Processor Topology Information leaf. This
> > contains similar information to CPUID leaf 0xb (Intel's Extended
> > Topology Enumeration leaf), and should be included in the output of
> > KVM_GET_SUPPORTED_CPUID, even though userspace is likely to override
> > some of this information based upon the configuration of the
> > particular VM.
> >
> > Cc: Brijesh Singh <brijesh.singh@amd.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Fixes: 8765d75329a38 ("KVM: X86: Extend CPUID range to include new leaf")
> > Signed-off-by: Jim Mattson <jmattson@google.com>
> > Reviewed-by: Marc Orr <marcorr@google.com>
> > ---
> >  arch/x86/kvm/cpuid.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Reviewed-by: Borislav Petkov <bp@suse.de>

Paolo?

Re: [PATCH 2/2] kvm: x86: Include CPUID leaf 0x8000001e in kvm's supported CPUID

[Paolo Bonzini]

On 17/05/19 19:48, Jim Mattson wrote:
> On Mon, Apr 1, 2019 at 10:13 AM Borislav Petkov <bp@suse.de> wrote:
>>
>> On Wed, Mar 27, 2019 at 01:15:37PM -0700, Jim Mattson wrote:
>>> Kvm now supports extended CPUID functions through 0x8000001f.  CPUID
>>> leaf 0x8000001e is AMD's Processor Topology Information leaf. This
>>> contains similar information to CPUID leaf 0xb (Intel's Extended
>>> Topology Enumeration leaf), and should be included in the output of
>>> KVM_GET_SUPPORTED_CPUID, even though userspace is likely to override
>>> some of this information based upon the configuration of the
>>> particular VM.
>>>
>>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>>> Cc: Borislav Petkov <bp@suse.de>
>>> Fixes: 8765d75329a38 ("KVM: X86: Extend CPUID range to include new leaf")
>>> Signed-off-by: Jim Mattson <jmattson@google.com>
>>> Reviewed-by: Marc Orr <marcorr@google.com>
>>> ---
>>>  arch/x86/kvm/cpuid.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Reviewed-by: Borislav Petkov <bp@suse.de>
> 
> Paolo?
> 

Queued both (for 5.2-rc2), thanks.

Paolo