From: Jim Mattson <jmattson@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sandipan Das <sandipan.das@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] KVM: x86/cpuid: Add AMD CPUID ExtPerfMonAndDbg leaf 0x80000022
Date: Tue, 6 Sep 2022 21:11:51 -0700 [thread overview]
Message-ID: <CALMp9eSXTpkKpmqJiS=0NuQOjCFKDeOqjN3wWfyPCBhx-H=Vsw@mail.gmail.com> (raw)
In-Reply-To: <d63e79d8-fcbc-9def-4a90-e7a4614493bb@gmail.com>
On Tue, Sep 6, 2022 at 8:59 PM Like Xu <like.xu.linux@gmail.com> wrote:
>
> On 7/9/2022 4:08 am, Jim Mattson wrote:
> > On Tue, Sep 6, 2022 at 5:53 AM Like Xu <like.xu.linux@gmail.com> wrote:
> >>
> >> On 6/9/2022 1:36 am, Jim Mattson wrote:
> >>> On Mon, Sep 5, 2022 at 5:45 AM Like Xu <like.xu.linux@gmail.com> wrote:
> >>>>
> >>>> From: Sandipan Das <sandipan.das@amd.com>
> >>>>
> >>>> CPUID leaf 0x80000022 i.e. ExtPerfMonAndDbg advertises some
> >>>> new performance monitoring features for AMD processors.
> >>>>
> >>>> Bit 0 of EAX indicates support for Performance Monitoring
> >>>> Version 2 (PerfMonV2) features. If found to be set during
> >>>> PMU initialization, the EBX bits of the same CPUID function
> >>>> can be used to determine the number of available PMCs for
> >>>> different PMU types.
> >>>>
> >>>> Expose the relevant bits via KVM_GET_SUPPORTED_CPUID so
> >>>> that guests can make use of the PerfMonV2 features.
> >>>>
> >>>> Co-developed-by: Like Xu <likexu@tencent.com>
> >>>> Signed-off-by: Like Xu <likexu@tencent.com>
> >>>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> >>>> ---
> >>>> arch/x86/include/asm/perf_event.h | 8 ++++++++
> >>>> arch/x86/kvm/cpuid.c | 21 ++++++++++++++++++++-
> >>>> 2 files changed, 28 insertions(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_event.h
> >>>> index f6fc8dd51ef4..c848f504e467 100644
> >>>> --- a/arch/x86/include/asm/perf_event.h
> >>>> +++ b/arch/x86/include/asm/perf_event.h
> >>>> @@ -214,6 +214,14 @@ union cpuid_0x80000022_ebx {
> >>>> unsigned int full;
> >>>> };
> >>>>
> >>>> +union cpuid_0x80000022_eax {
> >>>> + struct {
> >>>> + /* Performance Monitoring Version 2 Supported */
> >>>> + unsigned int perfmon_v2:1;
> >>>> + } split;
> >>>> + unsigned int full;
> >>>> +};
> >>>> +
> >>>> struct x86_pmu_capability {
> >>>> int version;
> >>>> int num_counters_gp;
> >>>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> >>>> index 75dcf7a72605..08a29ab096d2 100644
> >>>> --- a/arch/x86/kvm/cpuid.c
> >>>> +++ b/arch/x86/kvm/cpuid.c
> >>>> @@ -1094,7 +1094,7 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
> >>>> entry->edx = 0;
> >>>> break;
> >>>> case 0x80000000:
> >>>> - entry->eax = min(entry->eax, 0x80000021);
> >>>> + entry->eax = min(entry->eax, 0x80000022);
> >>>> /*
> >>>> * Serializing LFENCE is reported in a multitude of ways, and
> >>>> * NullSegClearsBase is not reported in CPUID on Zen2; help
> >>>> @@ -1203,6 +1203,25 @@ static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
> >>>> if (!static_cpu_has_bug(X86_BUG_NULL_SEG))
> >>>> entry->eax |= BIT(6);
> >>>> break;
> >>>> + /* AMD Extended Performance Monitoring and Debug */
> >>>> + case 0x80000022: {
> >>>> + union cpuid_0x80000022_eax eax;
> >>>> + union cpuid_0x80000022_ebx ebx;
> >>>> +
> >>>> + entry->eax = entry->ebx = entry->ecx = entry->edx = 0;
> >>>> + if (!enable_pmu)
> >>>> + break;
> >>>> +
> >>>> + if (kvm_pmu_cap.version > 1) {
> >>>> + /* AMD PerfMon is only supported up to V2 in the KVM. */
> >>>> + eax.split.perfmon_v2 = 1;
> >>>> + ebx.split.num_core_pmc = min(kvm_pmu_cap.num_counters_gp,
> >>>> + KVM_AMD_PMC_MAX_GENERIC);
> >>>
> >>> Note that the number of core PMCs has to be at least 6 if
> >>> guest_cpuid_has(vcpu, X86_FEATURE_PERFCTR_CORE). I suppose this leaf
> >>> could claim fewer, but the first 6 PMCs must work, per the v1 PMU
> >>> spec. That is, software that knows about PERFCTR_CORE, but not about
> >>> PMU v2, can rightfully expect 6 PMCs.
> >>
> >> I thought the NumCorePmc number would only make sense if
> >> CPUID.80000022.eax.perfmon_v2
> >> bit was present, but considering that the user space is perfectly fine with just
> >> configuring the
> >> NumCorePmc number without setting perfmon_v2 bit at all, so how about:
> >
> > CPUID.80000022H might only make sense if X86_FEATURE_PERFCTR_CORE is
> > present. It's hard to know in the absence of documentation.
>
> Whenever this happens, we may always leave the definition of behavior to the
> hypervisor.
I disagree. If CPUID.0H reports "AuthenticAMD," then AMD is the sole
authority on behavior.
> >
> >> /* AMD Extended Performance Monitoring and Debug */
> >> case 0x80000022: {
> >> union cpuid_0x80000022_eax eax;
> >> union cpuid_0x80000022_ebx ebx;
> >> bool perfctr_core;
> >>
> >> entry->eax = entry->ebx = entry->ecx = entry->edx = 0;
> >> if (!enable_pmu)
> >> break;
> >>
> >> perfctr_core = kvm_cpu_cap_has(X86_FEATURE_PERFCTR_CORE);
> >> if (!perfctr_core)
> >> ebx.split.num_core_pmc = AMD64_NUM_COUNTERS;
> >> if (kvm_pmu_cap.version > 1) {
> >> /* AMD PerfMon is only supported up to V2 in the KVM. */
> >> eax.split.perfmon_v2 = 1;
> >> ebx.split.num_core_pmc = min(kvm_pmu_cap.num_counters_gp,
> >> KVM_AMD_PMC_MAX_GENERIC);
> >> }
> >> if (perfctr_core) {
> >> ebx.split.num_core_pmc = max(ebx.split.num_core_pmc,
> >> AMD64_NUM_COUNTERS_CORE);
> >> }
> >
> > This still isn't quite right. All AMD CPUs must support a minimum of 4 PMCs.
>
> K7 at least. I could not confirm that all antique AMD CPUs have 4 counters w/o
> perfctr_core.
The APM says, "All implementations support the base set of four
performance counter / event-select pairs." That is unequivocal.
> >
> >>
> >> entry->eax = eax.full;
> >> entry->ebx = ebx.full;
> >> break;
> >> }
> >>
> >> ?
> >>
> >> Once 0x80000022 appears, ebx.split.num_core_pmc will report only
> >> the real "Number of Core Performance Counters" regardless of perfmon_v2.
> >>
> >>>
> >>>
> >>>> + }
> >>>> + entry->eax = eax.full;
> >>>> + entry->ebx = ebx.full;
> >>>> + break;
> >>>> + }
> >>>> /*Add support for Centaur's CPUID instruction*/
> >>>> case 0xC0000000:
> >>>> /*Just support up to 0xC0000004 now*/
> >>>> --
> >>>> 2.37.3
> >>>>
next prev parent reply other threads:[~2022-09-07 4:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 12:39 [PATCH 0/4] KVM: x86/svm/pmu: Add AMD Guest PerfMonV2 support Like Xu
2022-09-05 12:39 ` [PATCH 1/4] KVM: x86/svm/pmu: Limit the maximum number of supported GP counters Like Xu
2022-09-05 17:26 ` Jim Mattson
2022-09-06 12:38 ` Like Xu
2022-09-05 12:39 ` [PATCH 2/4] KVM: x86/pmu: Make part of the Intel v2 PMU MSRs handling x86 generic Like Xu
2022-09-05 12:39 ` [PATCH 3/4] KVM: x86/svm/pmu: Add AMD PerfMonV2 support Like Xu
2022-09-05 18:00 ` Jim Mattson
2022-09-06 12:45 ` Like Xu
2022-09-06 20:19 ` Jim Mattson
2022-09-07 3:50 ` Like Xu
2022-09-07 4:15 ` Jim Mattson
2022-09-05 12:39 ` [PATCH 4/4] KVM: x86/cpuid: Add AMD CPUID ExtPerfMonAndDbg leaf 0x80000022 Like Xu
2022-09-05 17:36 ` Jim Mattson
2022-09-06 12:53 ` Like Xu
2022-09-06 20:08 ` Jim Mattson
2022-09-07 3:59 ` Like Xu
2022-09-07 4:11 ` Jim Mattson [this message]
2022-09-07 5:52 ` Sandipan Das
2022-09-07 6:39 ` Like Xu
2022-09-08 6:00 ` Sandipan Das
2022-09-08 23:14 ` Jim Mattson
2022-09-05 12:39 ` [kvm-unit-tests PATCH 1/2] x86/pmu: Update rdpmc testcase to cover #GP and emulation path Like Xu
2022-10-05 21:36 ` Sean Christopherson
2022-10-19 8:50 ` Like Xu
2022-09-05 12:39 ` [kvm-unit-tests PATCH 2/2] x86/pmu: Add AMD Guest PerfMonV2 testcases Like Xu
2022-10-05 22:08 ` Sean Christopherson
2022-10-19 9:40 ` Like Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALMp9eSXTpkKpmqJiS=0NuQOjCFKDeOqjN3wWfyPCBhx-H=Vsw@mail.gmail.com' \
--to=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).