* [PATCH v1] KVM: stats: Decouple stats name string from its field name in structure
@ 2021-10-19 0:04 Jing Zhang
2021-10-19 15:02 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Jing Zhang @ 2021-10-19 0:04 UTC (permalink / raw)
To: KVM, Paolo Bonzini, David Matlack, Oliver Upton; +Cc: Jing Zhang
There are situations we need to group some stats in a structure (like
the VM/VCPU generic stats). Improve stats macros to decouple the
exported stats name from its field name in C structure. This also
removes the specific macros for VM/VCPU generic stats.
Signed-off-by: Jing Zhang <jingzhangos@google.com>
---
include/linux/kvm_host.h | 147 ++++++++++++++++++++-------------------
1 file changed, 75 insertions(+), 72 deletions(-)
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 60a35d9fe259..72f189c9c8f0 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -1364,102 +1364,105 @@ struct _kvm_stats_desc {
.size = sz, \
.bucket_size = bsz
-#define VM_GENERIC_STATS_DESC(stat, type, unit, base, exp, sz, bsz) \
- { \
- { \
- STATS_DESC_COMMON(type, unit, base, exp, sz, bsz), \
- .offset = offsetof(struct kvm_vm_stat, generic.stat) \
- }, \
- .name = #stat, \
- }
-#define VCPU_GENERIC_STATS_DESC(stat, type, unit, base, exp, sz, bsz) \
- { \
- { \
- STATS_DESC_COMMON(type, unit, base, exp, sz, bsz), \
- .offset = offsetof(struct kvm_vcpu_stat, generic.stat) \
- }, \
- .name = #stat, \
- }
-#define VM_STATS_DESC(stat, type, unit, base, exp, sz, bsz) \
+#define VM_STATS_DESC(stat, type, unit, base, exp, sz, bsz, nm) \
{ \
{ \
STATS_DESC_COMMON(type, unit, base, exp, sz, bsz), \
.offset = offsetof(struct kvm_vm_stat, stat) \
}, \
- .name = #stat, \
+ .name = nm, \
}
-#define VCPU_STATS_DESC(stat, type, unit, base, exp, sz, bsz) \
+#define VCPU_STATS_DESC(stat, type, unit, base, exp, sz, bsz, nm) \
{ \
{ \
STATS_DESC_COMMON(type, unit, base, exp, sz, bsz), \
.offset = offsetof(struct kvm_vcpu_stat, stat) \
}, \
- .name = #stat, \
+ .name = nm, \
}
-/* SCOPE: VM, VM_GENERIC, VCPU, VCPU_GENERIC */
-#define STATS_DESC(SCOPE, stat, type, unit, base, exp, sz, bsz) \
- SCOPE##_STATS_DESC(stat, type, unit, base, exp, sz, bsz)
-
-#define STATS_DESC_CUMULATIVE(SCOPE, name, unit, base, exponent) \
- STATS_DESC(SCOPE, name, KVM_STATS_TYPE_CUMULATIVE, \
- unit, base, exponent, 1, 0)
-#define STATS_DESC_INSTANT(SCOPE, name, unit, base, exponent) \
- STATS_DESC(SCOPE, name, KVM_STATS_TYPE_INSTANT, \
- unit, base, exponent, 1, 0)
-#define STATS_DESC_PEAK(SCOPE, name, unit, base, exponent) \
- STATS_DESC(SCOPE, name, KVM_STATS_TYPE_PEAK, \
- unit, base, exponent, 1, 0)
-#define STATS_DESC_LINEAR_HIST(SCOPE, name, unit, base, exponent, sz, bsz) \
- STATS_DESC(SCOPE, name, KVM_STATS_TYPE_LINEAR_HIST, \
- unit, base, exponent, sz, bsz)
-#define STATS_DESC_LOG_HIST(SCOPE, name, unit, base, exponent, sz) \
- STATS_DESC(SCOPE, name, KVM_STATS_TYPE_LOG_HIST, \
- unit, base, exponent, sz, 0)
+
+/* SCOPE: VM, VCPU */
+#define STATS_DESC(SCOPE, stat, type, unit, base, exp, sz, bsz, nm) \
+ SCOPE##_STATS_DESC(stat, type, unit, base, exp, sz, bsz, nm)
+
+#define STATS_DESC_CUMULATIVE(SCOPE, stat, unit, base, exp, name) \
+ STATS_DESC(SCOPE, stat, KVM_STATS_TYPE_CUMULATIVE, \
+ unit, base, exp, 1, 0, name)
+#define STATS_DESC_INSTANT(SCOPE, stat, unit, base, exp, name) \
+ STATS_DESC(SCOPE, stat, KVM_STATS_TYPE_INSTANT, \
+ unit, base, exp, 1, 0, name)
+#define STATS_DESC_PEAK(SCOPE, stat, unit, base, exp, name) \
+ STATS_DESC(SCOPE, stat, KVM_STATS_TYPE_PEAK, \
+ unit, base, exp, 1, 0, name)
+#define STATS_DESC_LINEAR_HIST(SCOPE, stat, unit, base, exp, sz, bsz, name) \
+ STATS_DESC(SCOPE, stat, KVM_STATS_TYPE_LINEAR_HIST, \
+ unit, base, exp, sz, bsz, name)
+#define STATS_DESC_LOG_HIST(SCOPE, stat, unit, base, exp, sz, name) \
+ STATS_DESC(SCOPE, stat, KVM_STATS_TYPE_LOG_HIST, \
+ unit, base, exp, sz, 0, name)
/* Cumulative counter, read/write */
-#define STATS_DESC_COUNTER(SCOPE, name) \
- STATS_DESC_CUMULATIVE(SCOPE, name, KVM_STATS_UNIT_NONE, \
- KVM_STATS_BASE_POW10, 0)
+#define _STATS_DESC_COUNTER(SCOPE, stat, name) \
+ STATS_DESC_CUMULATIVE(SCOPE, stat, KVM_STATS_UNIT_NONE, \
+ KVM_STATS_BASE_POW10, 0, name)
+#define STATS_DESC_COUNTER(SCOPE, stat) \
+ _STATS_DESC_COUNTER(SCOPE, stat, #stat)
/* Instantaneous counter, read only */
-#define STATS_DESC_ICOUNTER(SCOPE, name) \
- STATS_DESC_INSTANT(SCOPE, name, KVM_STATS_UNIT_NONE, \
- KVM_STATS_BASE_POW10, 0)
+#define _STATS_DESC_ICOUNTER(SCOPE, stat, name) \
+ STATS_DESC_INSTANT(SCOPE, stat, KVM_STATS_UNIT_NONE, \
+ KVM_STATS_BASE_POW10, 0, name)
+#define STATS_DESC_ICOUNTER(SCOPE, stat) \
+ _STATS_DESC_ICOUNTER(SCOPE, stat, #stat) \
/* Peak counter, read/write */
-#define STATS_DESC_PCOUNTER(SCOPE, name) \
- STATS_DESC_PEAK(SCOPE, name, KVM_STATS_UNIT_NONE, \
- KVM_STATS_BASE_POW10, 0)
+#define _STATS_DESC_PCOUNTER(SCOPE, stat, name) \
+ STATS_DESC_PEAK(SCOPE, stat, KVM_STATS_UNIT_NONE, \
+ KVM_STATS_BASE_POW10, 0, name)
+#define STATS_DESC_PCOUNTER(SCOPE, stat) \
+ _STATS_DESC_PCOUNTER(SCOPE, stat, #stat) \
/* Cumulative time in nanosecond */
-#define STATS_DESC_TIME_NSEC(SCOPE, name) \
- STATS_DESC_CUMULATIVE(SCOPE, name, KVM_STATS_UNIT_SECONDS, \
- KVM_STATS_BASE_POW10, -9)
+#define _STATS_DESC_TIME_NSEC(SCOPE, stat, name) \
+ STATS_DESC_CUMULATIVE(SCOPE, stat, KVM_STATS_UNIT_SECONDS, \
+ KVM_STATS_BASE_POW10, -9, name)
+#define STATS_DESC_TIME_NSEC(SCOPE, stat) \
+ _STATS_DESC_TIME_NSEC(SCOPE, stat, #stat) \
/* Linear histogram for time in nanosecond */
-#define STATS_DESC_LINHIST_TIME_NSEC(SCOPE, name, sz, bsz) \
- STATS_DESC_LINEAR_HIST(SCOPE, name, KVM_STATS_UNIT_SECONDS, \
- KVM_STATS_BASE_POW10, -9, sz, bsz)
+#define _STATS_DESC_LINHIST_TIME_NSEC(SCOPE, stat, sz, bsz, name) \
+ STATS_DESC_LINEAR_HIST(SCOPE, stat, KVM_STATS_UNIT_SECONDS, \
+ KVM_STATS_BASE_POW10, -9, sz, bsz, name)
+#define STATS_DESC_LINHIST_TIME_NSEC(SCOPE, stat, sz, bsz) \
+ _STATS_DESC_LINHIST_TIME_NSEC(SCOPE, stat, sz, bsz, #stat) \
/* Logarithmic histogram for time in nanosecond */
-#define STATS_DESC_LOGHIST_TIME_NSEC(SCOPE, name, sz) \
- STATS_DESC_LOG_HIST(SCOPE, name, KVM_STATS_UNIT_SECONDS, \
- KVM_STATS_BASE_POW10, -9, sz)
+#define _STATS_DESC_LOGHIST_TIME_NSEC(SCOPE, stat, sz, name) \
+ STATS_DESC_LOG_HIST(SCOPE, stat, KVM_STATS_UNIT_SECONDS, \
+ KVM_STATS_BASE_POW10, -9, sz, name)
+#define STATS_DESC_LOGHIST_TIME_NSEC(SCOPE, stat, sz) \
+ _STATS_DESC_LOGHIST_TIME_NSEC(SCOPE, stat, sz, #stat) \
#define KVM_GENERIC_VM_STATS() \
- STATS_DESC_COUNTER(VM_GENERIC, remote_tlb_flush), \
- STATS_DESC_COUNTER(VM_GENERIC, remote_tlb_flush_requests)
+ _STATS_DESC_COUNTER(VM, generic.remote_tlb_flush, "remote_tlb_flush"), \
+ _STATS_DESC_COUNTER(VM, generic.remote_tlb_flush_requests, \
+ "remote_tlb_flush_requests")
#define KVM_GENERIC_VCPU_STATS() \
- STATS_DESC_COUNTER(VCPU_GENERIC, halt_successful_poll), \
- STATS_DESC_COUNTER(VCPU_GENERIC, halt_attempted_poll), \
- STATS_DESC_COUNTER(VCPU_GENERIC, halt_poll_invalid), \
- STATS_DESC_COUNTER(VCPU_GENERIC, halt_wakeup), \
- STATS_DESC_TIME_NSEC(VCPU_GENERIC, halt_poll_success_ns), \
- STATS_DESC_TIME_NSEC(VCPU_GENERIC, halt_poll_fail_ns), \
- STATS_DESC_TIME_NSEC(VCPU_GENERIC, halt_wait_ns), \
- STATS_DESC_LOGHIST_TIME_NSEC(VCPU_GENERIC, halt_poll_success_hist, \
- HALT_POLL_HIST_COUNT), \
- STATS_DESC_LOGHIST_TIME_NSEC(VCPU_GENERIC, halt_poll_fail_hist, \
- HALT_POLL_HIST_COUNT), \
- STATS_DESC_LOGHIST_TIME_NSEC(VCPU_GENERIC, halt_wait_hist, \
- HALT_POLL_HIST_COUNT)
+ _STATS_DESC_COUNTER(VCPU, generic.halt_successful_poll, \
+ "halt_successful_poll"), \
+ _STATS_DESC_COUNTER(VCPU, generic.halt_attempted_poll, \
+ "halt_attempted_poll"), \
+ _STATS_DESC_COUNTER(VCPU, generic.halt_poll_invalid, \
+ "halt_poll_invalid"), \
+ _STATS_DESC_COUNTER(VCPU, generic.halt_wakeup, "halt_wakeup"), \
+ _STATS_DESC_TIME_NSEC(VCPU, generic.halt_poll_success_ns, \
+ "halt_poll_success_ns"), \
+ _STATS_DESC_TIME_NSEC(VCPU, generic.halt_poll_fail_ns, \
+ "halt_poll_fail_ns"), \
+ _STATS_DESC_TIME_NSEC(VCPU, generic.halt_wait_ns, "halt_wait_ns"), \
+ _STATS_DESC_LOGHIST_TIME_NSEC(VCPU, generic.halt_poll_success_hist, \
+ HALT_POLL_HIST_COUNT, "halt_poll_success_hist"), \
+ _STATS_DESC_LOGHIST_TIME_NSEC(VCPU, generic.halt_poll_fail_hist, \
+ HALT_POLL_HIST_COUNT, "halt_poll_fail_hist"), \
+ _STATS_DESC_LOGHIST_TIME_NSEC(VCPU, generic.halt_wait_hist, \
+ HALT_POLL_HIST_COUNT, "halt_wait_hist")
extern struct dentry *kvm_debugfs_dir;
base-commit: 73f122c4f06f650ddf7f7410d8510db1a92a16a0
--
2.33.0.1079.g6e70778dc9-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] KVM: stats: Decouple stats name string from its field name in structure
2021-10-19 0:04 [PATCH v1] KVM: stats: Decouple stats name string from its field name in structure Jing Zhang
@ 2021-10-19 15:02 ` Paolo Bonzini
2021-10-19 15:41 ` David Matlack
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2021-10-19 15:02 UTC (permalink / raw)
To: Jing Zhang, KVM, David Matlack, Oliver Upton
On 19/10/21 02:04, Jing Zhang wrote:
> There are situations we need to group some stats in a structure (like
> the VM/VCPU generic stats). Improve stats macros to decouple the
> exported stats name from its field name in C structure. This also
> removes the specific macros for VM/VCPU generic stats.
Do you have other uses in mind than generic stats? I didn't like the
"generic" macros very much either, but not being able to use "#" at all
is also not nice.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] KVM: stats: Decouple stats name string from its field name in structure
2021-10-19 15:02 ` Paolo Bonzini
@ 2021-10-19 15:41 ` David Matlack
0 siblings, 0 replies; 3+ messages in thread
From: David Matlack @ 2021-10-19 15:41 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Jing Zhang, KVM, Oliver Upton
On Tue, Oct 19, 2021 at 8:02 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 19/10/21 02:04, Jing Zhang wrote:
> > There are situations we need to group some stats in a structure (like
> > the VM/VCPU generic stats). Improve stats macros to decouple the
> > exported stats name from its field name in C structure. This also
> > removes the specific macros for VM/VCPU generic stats.
>
> Do you have other uses in mind than generic stats?
Yeah we have stats internally (that are in our queue to send upstream
:) which store stats in sub-structs so that we can compute the same
stats in multiple ways (e.g. snapshot vs. cumulative). When Jing was
upgrading these stats from our internal API to the fd-based API I
suggested breaking out the name to keep the stat names consistent
across the upgrade. Then we noticed this would also clean up the
VM/VCPU_GENERIC stuff as well.
> I didn't like the
> "generic" macros very much either, but not being able to use "#" at all
> is also not nice.
>
> Paolo
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-19 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 0:04 [PATCH v1] KVM: stats: Decouple stats name string from its field name in structure Jing Zhang
2021-10-19 15:02 ` Paolo Bonzini
2021-10-19 15:41 ` David Matlack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).