KVM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] vhost: do not reference a file that does not exist
@ 2019-08-08  0:52 egranata
  2019-08-10  8:15 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: egranata @ 2019-08-08  0:52 UTC (permalink / raw)
  To: linux-kernel
  Cc: mst, jasowang, kvm, virtualization, netdev, trivial, egranata

From: Enrico Granata <egranata@google.com>

lguest was removed from the mainline kernel in late 2017.

Signed-off-by: Enrico Granata <egranata@google.com>
---
 drivers/vhost/vhost.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 0536f8526359..2c376cb66971 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -4,8 +4,8 @@
  *
  * Author: Michael S. Tsirkin <mst@redhat.com>
  *
- * Inspiration, some code, and most witty comments come from
- * Documentation/virtual/lguest/lguest.c, by Rusty Russell
+ * Inspiration, some code, and most witty comments come from lguest.c
+ * by Rusty Russell
  *
  * Generic code for virtio server in host kernel.
  */
-- 
2.22.0.770.g0f2c4a37fd-goog


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] vhost: do not reference a file that does not exist
  2019-08-08  0:52 [PATCH] vhost: do not reference a file that does not exist egranata
@ 2019-08-10  8:15 ` Christoph Hellwig
  2019-08-12 20:55   ` Enrico Granata
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2019-08-10  8:15 UTC (permalink / raw)
  To: egranata
  Cc: linux-kernel, mst, jasowang, kvm, virtualization, netdev,
	trivial, egranata

On Wed, Aug 07, 2019 at 05:52:55PM -0700, egranata@chromium.org wrote:
> From: Enrico Granata <egranata@google.com>
> 
> lguest was removed from the mainline kernel in late 2017.
> 
> Signed-off-by: Enrico Granata <egranata@google.com>

But this particular file even has an override in the script looking
for dead references, which together with the content of the overal
contents makes me thing the dangling reference is somewhat intentional.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] vhost: do not reference a file that does not exist
  2019-08-10  8:15 ` Christoph Hellwig
@ 2019-08-12 20:55   ` Enrico Granata
  0 siblings, 0 replies; 3+ messages in thread
From: Enrico Granata @ 2019-08-12 20:55 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Enrico Granata, Linux Kernel Mailing List, mst, jasowang, kvm,
	virtualization, netdev, trivial

Fair enough, yeah.

I think what I found confusing was that the file had a precise
(directly actionable in a file browser, if you will) path. If it was
just listed as a filename, or a project name, it might have been more
obvious that one shouldn't expect to find it within the kernel tree
and just go look it up in your favorite search engine.

The right incantation to get your hands on that file is a web search,
not a local file navigation, and to my perception a full and seemingly
valid path pointed in the direction of doing the wrong thing.

It's not a huge deal, obviously, and it may be that I was the only one
confused by that. If so, feel free to disregard the patch.

Thanks,
- Enrico

Thanks,
- Enrico


On Sat, Aug 10, 2019 at 1:15 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Aug 07, 2019 at 05:52:55PM -0700, egranata@chromium.org wrote:
> > From: Enrico Granata <egranata@google.com>
> >
> > lguest was removed from the mainline kernel in late 2017.
> >
> > Signed-off-by: Enrico Granata <egranata@google.com>
>
> But this particular file even has an override in the script looking
> for dead references, which together with the content of the overal
> contents makes me thing the dangling reference is somewhat intentional.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08  0:52 [PATCH] vhost: do not reference a file that does not exist egranata
2019-08-10  8:15 ` Christoph Hellwig
2019-08-12 20:55   ` Enrico Granata

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org kvm@archiver.kernel.org
	public-inbox-index kvm


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/ public-inbox