From: "Liu, Yi L" <yi.l.liu@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: "joro@8bytes.org" <joro@8bytes.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
"peterx@redhat.com" <peterx@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Subject: RE: [PATCH v2 1/5] iommufd: Add nesting related data structures for Intel VT-d
Date: Tue, 21 Mar 2023 06:06:25 +0000 [thread overview]
Message-ID: <DS0PR11MB752963483E616EC55F372D82C3819@DS0PR11MB7529.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ZBhkf8ugXFPi8dej@nvidia.com>
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Monday, March 20, 2023 9:50 PM
>
> On Thu, Mar 09, 2023 at 12:22:03AM -0800, Yi Liu wrote:
>
> > +struct iommu_hwpt_invalidate_intel_vtd {
> > + __u8 granularity;
> > + __u8 padding[7];
> > + __u32 flags;
> > + __u32 __reserved;
> > + __u64 addr;
> > + __u64 granule_size;
> > + __u64 nb_granules;
> > +};
>
> Is there a reason this has such a weird layout? Put the granularity in
> the __reserved slot?
No special reason. This layout was from the previous merged version.
Will modify it as you suggested.
> Consider the discussion on ARM if you prefer to use the native HW
> command structure instead?
Yes, will think about it. at least granule_size and nb_granules are not
necessary. They was added in the previous abstracted invalidation
uapi structure.
Regards,
Yi Liu
next prev parent reply other threads:[~2023-03-21 6:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 8:22 [PATCH v2 0/5] Add Intel VT-d nested translation Yi Liu
2023-03-09 8:22 ` [PATCH v2 1/5] iommufd: Add nesting related data structures for Intel VT-d Yi Liu
2023-03-15 13:50 ` Liu, Jingqi
2023-03-21 6:31 ` Liu, Yi L
2023-03-20 13:49 ` Jason Gunthorpe
2023-03-21 6:06 ` Liu, Yi L [this message]
2023-03-09 8:22 ` [PATCH v2 2/5] iommu/vt-d: Implement hw_info for iommu capability query Yi Liu
2023-03-09 8:22 ` [PATCH v2 3/5] iommu/vt-d: Extend dmar_domain to support nested domain Yi Liu
2023-03-20 13:54 ` Jason Gunthorpe
2023-03-21 1:58 ` Baolu Lu
2023-03-09 8:22 ` [PATCH v2 4/5] iommu/vt-d: Add helper to setup pasid nested translation Yi Liu
2023-03-09 8:22 ` [PATCH v2 5/5] iommu/vt-d: Add nested domain support Yi Liu
2023-03-13 13:51 ` Liu, Jingqi
[not found] ` <bf434709-4bb3-a7bd-4b5a-9f495bd3a104@intel.com>
2023-03-14 1:21 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR11MB752963483E616EC55F372D82C3819@DS0PR11MB7529.namprd11.prod.outlook.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).