* Re: [RFC: timer passthrough 0/9] Support timer passthrough for VM
[not found] <20201228091559.25745-1-fengzhimin@bytedance.com>
@ 2020-12-28 23:28 ` Sean Christopherson
0 siblings, 0 replies; only message in thread
From: Sean Christopherson @ 2020-12-28 23:28 UTC (permalink / raw)
To: Zhimin Feng
Cc: zhouyibo, zhanghaozhong, Paolo Bonzini, Vitaly Kuznetsov,
Wanpeng Li, Jim Mattson, Joerg Roedel, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, x86, H. Peter Anvin,
Frederic Weisbecker, kvm, linux-kernel
On Mon, Dec 28, 2020, Zhimin Feng wrote:
> The main motivation for this patch is to improve the performance of VM.
Do you have numbers that show when this improves performance, and by how much?
This adds hundreds of cycles of overhead (VMWRITEs, WRMSRs, RDMSRs, etc...) to
_every_ VM-Exit roundtrip, and the timer IRQ still incurs a VM-Exit. It's not
obvious that this is a net win, and it adds a fair amount of complexity and
subtlety, e.g. there are multiple corner cases this gets wrong. I suspect
you'll have a tough time getting this reviewed, let alone merged, without hard
numbers to justify the complexity and review effort.
^ permalink raw reply [flat|nested] only message in thread