* Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 [not found] <20181031234928.144206-1-marcorr@google.com> @ 2021-05-21 20:58 ` Jim Mattson 2021-05-24 12:50 ` Paolo Bonzini 0 siblings, 1 reply; 5+ messages in thread From: Jim Mattson @ 2021-05-21 20:58 UTC (permalink / raw) To: Marc Orr Cc: kvm list, David Rientjes, Konrad Rzeszutek Wilk, linux-mm, Andrew Morton, Paolo Bonzini, Radim Krčmář, Matthew Wilcox, Dave Hansen, Wanpeng Li On Wed, Oct 31, 2018 at 4:49 PM Marc Orr <marcorr@google.com> wrote: > > Compared to the last version, I've: > (1) dropped the vmalloc patches > (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch > struct to be sized according to fpu_kernel_xstate_size > (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory > corruption issues. > > Marc Orr (2): > kvm: x86: Use task structs fpu field for user > kvm: x86: Dynamically allocate guest_fpu > > arch/x86/include/asm/kvm_host.h | 10 +++--- > arch/x86/kvm/svm.c | 10 ++++++ > arch/x86/kvm/vmx.c | 10 ++++++ > arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- > 4 files changed, 65 insertions(+), 20 deletions(-) > > -- Whatever happened to this series? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 2021-05-21 20:58 ` [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 Jim Mattson @ 2021-05-24 12:50 ` Paolo Bonzini 2021-05-24 22:44 ` Sean Christopherson 0 siblings, 1 reply; 5+ messages in thread From: Paolo Bonzini @ 2021-05-24 12:50 UTC (permalink / raw) To: Jim Mattson, Marc Orr Cc: kvm list, David Rientjes, Konrad Rzeszutek Wilk, linux-mm, Andrew Morton, Radim Krčmář, Matthew Wilcox, Dave Hansen, Wanpeng Li On 21/05/21 22:58, Jim Mattson wrote: > On Wed, Oct 31, 2018 at 4:49 PM Marc Orr <marcorr@google.com> wrote: >> >> Compared to the last version, I've: >> (1) dropped the vmalloc patches >> (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch >> struct to be sized according to fpu_kernel_xstate_size >> (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory >> corruption issues. >> >> Marc Orr (2): >> kvm: x86: Use task structs fpu field for user >> kvm: x86: Dynamically allocate guest_fpu >> >> arch/x86/include/asm/kvm_host.h | 10 +++--- >> arch/x86/kvm/svm.c | 10 ++++++ >> arch/x86/kvm/vmx.c | 10 ++++++ >> arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- >> 4 files changed, 65 insertions(+), 20 deletions(-) >> >> -- > > Whatever happened to this series? There was a question about the usage of kmem_cache_create_usercopy, and a v7 was never sent. Paolo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 2021-05-24 12:50 ` Paolo Bonzini @ 2021-05-24 22:44 ` Sean Christopherson 2021-05-24 23:01 ` Jim Mattson 0 siblings, 1 reply; 5+ messages in thread From: Sean Christopherson @ 2021-05-24 22:44 UTC (permalink / raw) To: Paolo Bonzini Cc: Jim Mattson, Marc Orr, kvm list, David Rientjes, Konrad Rzeszutek Wilk, linux-mm, Andrew Morton, Radim Krčmář, Matthew Wilcox, Dave Hansen, Wanpeng Li On Mon, May 24, 2021, Paolo Bonzini wrote: > On 21/05/21 22:58, Jim Mattson wrote: > > On Wed, Oct 31, 2018 at 4:49 PM Marc Orr <marcorr@google.com> wrote: > > > > > > Compared to the last version, I've: > > > (1) dropped the vmalloc patches > > > (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch > > > struct to be sized according to fpu_kernel_xstate_size > > > (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory > > > corruption issues. > > > > > > Marc Orr (2): > > > kvm: x86: Use task structs fpu field for user > > > kvm: x86: Dynamically allocate guest_fpu > > > > > > arch/x86/include/asm/kvm_host.h | 10 +++--- > > > arch/x86/kvm/svm.c | 10 ++++++ > > > arch/x86/kvm/vmx.c | 10 ++++++ > > > arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- > > > 4 files changed, 65 insertions(+), 20 deletions(-) > > > > > > -- > > > > Whatever happened to this series? > > There was a question about the usage of kmem_cache_create_usercopy, and a v7 > was never sent. What's that go to do with anything? :-D b666a4b69739 ("kvm: x86: Dynamically allocate guest_fpu") 240c35a3783a ("kvm: x86: Use task structs fpu field for user") ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 2021-05-24 22:44 ` Sean Christopherson @ 2021-05-24 23:01 ` Jim Mattson 2021-05-25 0:00 ` Sean Christopherson 0 siblings, 1 reply; 5+ messages in thread From: Jim Mattson @ 2021-05-24 23:01 UTC (permalink / raw) To: Sean Christopherson Cc: Paolo Bonzini, Marc Orr, kvm list, David Rientjes, Konrad Rzeszutek Wilk, linux-mm, Andrew Morton, Radim Krčmář, Matthew Wilcox, Dave Hansen, Wanpeng Li On Mon, May 24, 2021 at 3:44 PM Sean Christopherson <seanjc@google.com> wrote: > > On Mon, May 24, 2021, Paolo Bonzini wrote: > > On 21/05/21 22:58, Jim Mattson wrote: > > > On Wed, Oct 31, 2018 at 4:49 PM Marc Orr <marcorr@google.com> wrote: > > > > > > > > Compared to the last version, I've: > > > > (1) dropped the vmalloc patches > > > > (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch > > > > struct to be sized according to fpu_kernel_xstate_size > > > > (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory > > > > corruption issues. > > > > > > > > Marc Orr (2): > > > > kvm: x86: Use task structs fpu field for user > > > > kvm: x86: Dynamically allocate guest_fpu > > > > > > > > arch/x86/include/asm/kvm_host.h | 10 +++--- > > > > arch/x86/kvm/svm.c | 10 ++++++ > > > > arch/x86/kvm/vmx.c | 10 ++++++ > > > > arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- > > > > 4 files changed, 65 insertions(+), 20 deletions(-) > > > > > > > > -- > > > > > > Whatever happened to this series? > > > > There was a question about the usage of kmem_cache_create_usercopy, and a v7 > > was never sent. > > What's that go to do with anything? :-D > > b666a4b69739 ("kvm: x86: Dynamically allocate guest_fpu") > 240c35a3783a ("kvm: x86: Use task structs fpu field for user") So, that's what the series was trimmed down to. Thanks! Did we still manage to get down to order 2? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 2021-05-24 23:01 ` Jim Mattson @ 2021-05-25 0:00 ` Sean Christopherson 0 siblings, 0 replies; 5+ messages in thread From: Sean Christopherson @ 2021-05-25 0:00 UTC (permalink / raw) To: Jim Mattson Cc: Paolo Bonzini, Marc Orr, kvm list, David Rientjes, Konrad Rzeszutek Wilk, linux-mm, Andrew Morton, Radim Krčmář, Matthew Wilcox, Dave Hansen, Wanpeng Li On Mon, May 24, 2021, Jim Mattson wrote: > On Mon, May 24, 2021 at 3:44 PM Sean Christopherson <seanjc@google.com> wrote: > > > > On Mon, May 24, 2021, Paolo Bonzini wrote: > > > On 21/05/21 22:58, Jim Mattson wrote: > > > > On Wed, Oct 31, 2018 at 4:49 PM Marc Orr <marcorr@google.com> wrote: > > > > > > > > > > Compared to the last version, I've: > > > > > (1) dropped the vmalloc patches > > > > > (2) updated the kmem cache for the guest_fpu field in the kvm_vcpu_arch > > > > > struct to be sized according to fpu_kernel_xstate_size > > > > > (3) Added minimum FPU checks in KVM's x86 init logic to avoid memory > > > > > corruption issues. > > > > > > > > > > Marc Orr (2): > > > > > kvm: x86: Use task structs fpu field for user > > > > > kvm: x86: Dynamically allocate guest_fpu > > > > > > > > > > arch/x86/include/asm/kvm_host.h | 10 +++--- > > > > > arch/x86/kvm/svm.c | 10 ++++++ > > > > > arch/x86/kvm/vmx.c | 10 ++++++ > > > > > arch/x86/kvm/x86.c | 55 ++++++++++++++++++++++++--------- > > > > > 4 files changed, 65 insertions(+), 20 deletions(-) > > > > > > > > > > -- > > > > > > > > Whatever happened to this series? > > > > > > There was a question about the usage of kmem_cache_create_usercopy, and a v7 > > > was never sent. > > > > What's that go to do with anything? :-D > > > > b666a4b69739 ("kvm: x86: Dynamically allocate guest_fpu") > > 240c35a3783a ("kvm: x86: Use task structs fpu field for user") > > So, that's what the series was trimmed down to. Thanks! > > Did we still manage to get down to order 2? Yep, almost made it to order-1! Current size (without 8 bytes from CONFIG_HYPERV=y) is 9728. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-25 0:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181031234928.144206-1-marcorr@google.com>
2021-05-21 20:58 ` [kvm PATCH v6 0/2] shrink vcpu_vmx down to order 2 Jim Mattson
2021-05-24 12:50 ` Paolo Bonzini
2021-05-24 22:44 ` Sean Christopherson
2021-05-24 23:01 ` Jim Mattson
2021-05-25 0:00 ` Sean Christopherson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).