From: Sean Christopherson <seanjc@google.com>
To: Maxim Levitsky <mlevitsk@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Li RongQing <lirongqing@baidu.com>
Subject: Re: [PATCH 07/19] KVM: SVM: Drop buggy and redundant AVIC "single logical dest" check
Date: Wed, 31 Aug 2022 16:37:37 +0000 [thread overview]
Message-ID: <Yw+OUa3l1Rg036fb@google.com> (raw)
In-Reply-To: <dd8c92855762258d87486f719bf7e52e36169ef2.camel@redhat.com>
On Wed, Aug 31, 2022, Maxim Levitsky wrote:
> On Wed, 2022-08-31 at 00:34 +0000, Sean Christopherson wrote:
> > Use the already-calculated-and-sanity-checked destination bitmap when
> > processing a fast AVIC kick in logical mode, and drop the logical path's
> > flawed logic. The intent of the check is to ensure the bitmap is a power
> > of two, whereas "icrh != (1 << avic)" effectively checks that the bitmap
> > is a power of two _and_ the target cluster is '0'.
> >
> > Note, the flawed check isn't a functional issue, it simply means that KVM
> > will go down the slow path if the target cluster is non-zero.
> >
> > Fixes: 8c9e639da435 ("KVM: SVM: Use target APIC ID to complete x2AVIC IRQs when possible")
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > ---
> > arch/x86/kvm/svm/avic.c | 10 +---------
> > 1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
> > index 3c333cd2e752..14f567550a1e 100644
> > --- a/arch/x86/kvm/svm/avic.c
> > +++ b/arch/x86/kvm/svm/avic.c
> > @@ -411,15 +411,7 @@ static int avic_kick_target_vcpus_fast(struct kvm *kvm, struct kvm_lapic *source
> > * Instead, calculate physical ID from logical ID in ICRH.
> > */
> > int cluster = (icrh & 0xffff0000) >> 16;
> > - int apic = ffs(icrh & 0xffff) - 1;
> > -
> > - /*
> > - * If the x2APIC logical ID sub-field (i.e. icrh[15:0])
> > - * contains anything but a single bit, we cannot use the
> > - * fast path, because it is limited to a single vCPU.
> > - */
> > - if (apic < 0 || icrh != (1 << apic))
> > - return -EINVAL;
> > + int apic = ffs(bitmap) - 1;
> >
> > l1_physical_id = (cluster << 4) + apic;
> > }
>
> Oh, I didn't notice this bug. However isn't removing the check is wrong as well?
>
> What if we do have multiple bits set in the bitmap? After you remove this code,
> we will set IPI only to APIC which matches the 1st bit, no?
The common code (out of sight here) already ensures the bitmap has exactly one bit set:
if (unlikely(!bitmap))
/* guest bug: nobody to send the logical interrupt to */
return 0;
if (!is_power_of_2(bitmap))
/* multiple logical destinations, use slow path */
return -EINVAL;
logid_index = cluster + __ffs(bitmap);
next prev parent reply other threads:[~2022-08-31 16:37 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 0:34 [PATCH 00/19] KVM: x86: AVIC and local APIC fixes+cleanups Sean Christopherson
2022-08-31 0:34 ` [PATCH 01/19] KVM: SVM: Process ICR on AVIC IPI delivery failure due to invalid target Sean Christopherson
2022-08-31 9:18 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 02/19] KVM: SVM: Don't put/load AVIC when setting virtual APIC mode Sean Christopherson
2022-08-31 9:24 ` Maxim Levitsky
2022-08-31 16:33 ` Sean Christopherson
2022-08-31 0:34 ` [PATCH 03/19] Revert "KVM: SVM: Introduce hybrid-AVIC mode" Sean Christopherson
2022-08-31 5:59 ` Maxim Levitsky
2022-08-31 6:45 ` Maxim Levitsky
2022-08-31 16:29 ` Sean Christopherson
2022-08-31 17:46 ` Maxim Levitsky
2022-08-31 17:58 ` Jim Mattson
2022-08-31 18:01 ` Maxim Levitsky
2022-08-31 19:12 ` Sean Christopherson
2022-09-01 10:25 ` Maxim Levitsky
2022-09-01 11:47 ` Jim Mattson
2022-09-01 13:29 ` Sean Christopherson
2022-09-01 13:53 ` Sean Christopherson
2022-09-01 15:08 ` Sean Christopherson
2022-08-31 16:19 ` Sean Christopherson
2022-08-31 17:47 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 04/19] KVM: SVM: Replace "avic_mode" enum with "x2avic_enabled" boolean Sean Christopherson
2022-08-31 9:36 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 05/19] KVM: SVM: Compute dest based on sender's x2APIC status for AVIC kick Sean Christopherson
2022-08-31 9:38 ` Maxim Levitsky
2022-09-01 2:56 ` Li,Rongqing
2022-08-31 0:34 ` [PATCH 06/19] KVM: SVM: Get x2APIC logical dest bitmap from ICRH[15:0], not ICHR[31:16] Sean Christopherson
2022-08-31 6:09 ` Maxim Levitsky
2022-08-31 9:43 ` Maxim Levitsky
2022-08-31 16:35 ` Sean Christopherson
2022-08-31 18:18 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 07/19] KVM: SVM: Drop buggy and redundant AVIC "single logical dest" check Sean Christopherson
2022-08-31 6:19 ` Maxim Levitsky
2022-08-31 16:37 ` Sean Christopherson [this message]
2022-08-31 18:10 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 08/19] KVM: SVM: Remove redundant cluster calculation that also creates a shadow Sean Christopherson
2022-08-31 10:19 ` Maxim Levitsky
2022-09-01 20:02 ` Sean Christopherson
2022-08-31 0:34 ` [PATCH 09/19] KVM: SVM: Drop duplicate calcuation of AVIC/x2AVIC "logical index" Sean Christopherson
2022-08-31 0:34 ` [PATCH 10/19] KVM: SVM: Document that vCPU ID == APIC ID in AVIC kick fastpatch Sean Christopherson
2022-08-31 10:22 ` Maxim Levitsky
2022-08-31 16:16 ` Sean Christopherson
2022-08-31 17:49 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 11/19] KVM: SVM: Add helper to perform final AVIC "kick" of single vCPU Sean Christopherson
2022-08-31 10:25 ` Maxim Levitsky
2022-08-31 15:08 ` Sean Christopherson
2022-08-31 18:12 ` Maxim Levitsky
2022-08-31 0:34 ` [PATCH 12/19] KVM: x86: Disable APIC logical map if logical ID covers multiple MDAs Sean Christopherson
2022-08-31 13:23 ` Maxim Levitsky
2022-08-31 0:35 ` [PATCH 13/19] KVM: x86: Disable APIC logical map if vCPUs are aliased in logical mode Sean Christopherson
2022-08-31 13:24 ` Maxim Levitsky
2022-08-31 0:35 ` [PATCH 14/19] KVM: x86: Honor architectural behavior for aliased 8-bit APIC IDs Sean Christopherson
2022-08-31 13:37 ` Maxim Levitsky
2022-08-31 16:41 ` Sean Christopherson
2022-08-31 17:51 ` Maxim Levitsky
2022-08-31 0:35 ` [PATCH 15/19] KVM: x86: Explicitly skip optimized logical map setup if vCPU's LDR==0 Sean Christopherson
2022-08-31 13:41 ` Maxim Levitsky
2022-08-31 16:47 ` Sean Christopherson
2022-08-31 0:35 ` [PATCH 16/19] KVM: x86: Explicitly track all possibilities for APIC map's logical modes Sean Christopherson
2022-08-31 13:43 ` Maxim Levitsky
2022-08-31 16:56 ` Sean Christopherson
2022-08-31 17:53 ` Maxim Levitsky
2022-09-16 18:58 ` Sean Christopherson
2022-08-31 18:42 ` Maxim Levitsky
2022-08-31 19:17 ` Sean Christopherson
2022-08-31 0:35 ` [PATCH 17/19] KVM: SVM: Handle multiple logical targets in AVIC kick fastpath Sean Christopherson
2022-08-31 13:57 ` Maxim Levitsky
2022-08-31 18:19 ` Sean Christopherson
2022-08-31 18:25 ` Maxim Levitsky
2022-08-31 0:35 ` [PATCH 18/19] KVM: SVM: Ignore writes to Remote Read Data on AVIC write traps Sean Christopherson
2022-08-31 10:40 ` Maxim Levitsky
2022-08-31 0:35 ` [PATCH 19/19] Revert "KVM: SVM: Do not throw warning when calling avic_vcpu_load on a running vcpu" Sean Christopherson
2022-08-31 6:07 ` Maxim Levitsky
2022-08-31 7:03 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yw+OUa3l1Rg036fb@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).