From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Jim Mattson <jmattson@google.com>,
konrad.wilk@oracle.com
Subject: Re: [PATCH 2/3] KVM: x86: always expose VIRT_SSBD to guests
Date: Sun, 6 Oct 2019 18:08:24 +0200 [thread overview]
Message-ID: <a15e4b77-22ca-e92d-b170-e40b845a5bd1@redhat.com> (raw)
In-Reply-To: <20191001221646.GN4084@habkost.net>
On 02/10/19 00:16, Eduardo Habkost wrote:
> Wasn't the old code at arch/x86/kvm/cpuid.c:__do_cpuid_func()
> supposed to be deleted?
>
> /*
> * The preference is to use SPEC CTRL MSR instead of the
> * VIRT_SPEC MSR.
> */
> if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) &&
> !boot_cpu_has(X86_FEATURE_AMD_SSBD))
> entry->ebx |= F(VIRT_SSBD);
Yeah, it's harmless but also useless.
Paolo
next prev parent reply other threads:[~2019-10-06 16:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 8:26 [PATCH v2 0/3] KVM: x86: fixes for speculation bug feature reporting Paolo Bonzini
2019-08-21 8:26 ` [PATCH 1/3] KVM: x86: fix reporting of AMD speculation bug CPUID leaf Paolo Bonzini
2019-08-21 19:45 ` Jim Mattson
2019-08-22 18:46 ` Konrad Rzeszutek Wilk
2019-11-30 23:27 ` Eric Biggers
2019-12-09 17:55 ` Eric Biggers
2019-12-13 22:27 ` Eduardo Habkost
2019-08-21 8:26 ` [PATCH 2/3] KVM: x86: always expose VIRT_SSBD to guests Paolo Bonzini
2019-08-21 19:47 ` Jim Mattson
2019-08-22 18:44 ` Konrad Rzeszutek Wilk
2019-10-01 22:16 ` Eduardo Habkost
2019-10-06 16:08 ` Paolo Bonzini [this message]
2019-08-21 8:26 ` [PATCH 3/3] KVM: x86: use Intel speculation bugs and features as derived in generic x86 code Paolo Bonzini
2019-08-21 19:48 ` Jim Mattson
2019-08-22 18:45 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a15e4b77-22ca-e92d-b170-e40b845a5bd1@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jmattson@google.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).