From: Janosch Frank <frankja@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 8/9] s390x: smp: Test all CRs on initial reset
Date: Mon, 20 Jan 2020 15:49:28 +0100 [thread overview]
Message-ID: <d866273e-5108-e634-4e92-93aa66bbed57@linux.ibm.com> (raw)
In-Reply-To: <15f8b733-1b81-4a1b-22fe-53099878c013@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 2265 bytes --]
On 1/20/20 1:10 PM, David Hildenbrand wrote:
> On 17.01.20 11:46, Janosch Frank wrote:
>> All CRs are set to 0 and CRs 0 and 14 are set to pre-defined values,
>> so we also need to test 1-13 and 15 for 0.
>>
>> And while we're at it, let's also set some values to cr 1, 7 and 13, so
>> we can actually be sure that they will be zeroed.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> s390x/smp.c | 18 +++++++++++++++++-
>> 1 file changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/s390x/smp.c b/s390x/smp.c
>> index c12a3db..1385488 100644
>> --- a/s390x/smp.c
>> +++ b/s390x/smp.c
>> @@ -169,16 +169,30 @@ static void test_emcall(void)
>> report_prefix_pop();
>> }
>>
>> +/* Used to dirty registers of cpu #1 before it is reset */
>> +static void test_func_initial(void)
>> +{
>> + lctlg(1, 0x42000UL);
>> + lctlg(7, 0x43000UL);
>> + lctlg(13, 0x44000UL);
>> + mb();
>> + testflag = 1;
>> +}
>> +
>> static void test_reset_initial(void)
>> {
>> struct cpu_status *status = alloc_pages(0);
>> + uint64_t nullp[12] = {};
>> struct psw psw;
>>
>> psw.mask = extract_psw_mask();
>> - psw.addr = (unsigned long)test_func;
>> + psw.addr = (unsigned long)test_func_initial;
>>
>> report_prefix_push("reset initial");
>> + testflag = 0;
>> + mb();
>
> maybe use a set_flag() function like
>
> mb();
> testflag = val;
> mb();
>
> and use it everywhere you set the flag? (e.g., in test_func_initial())
Hmm, so basically a set_test_flag() function in a new patch :)
Ok, I'll have a look.
>
> Apart from that
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
>> smp_cpu_start(1, psw);
>> + wait_for_flag();
>>
>> sigp_retry(1, SIGP_INITIAL_CPU_RESET, 0, NULL);
>> sigp(1, SIGP_STORE_STATUS_AT_ADDRESS, (uintptr_t)status, NULL);
>> @@ -189,6 +203,8 @@ static void test_reset_initial(void)
>> report(!status->fpc, "fpc");
>> report(!status->cputm, "cpu timer");
>> report(!status->todpr, "todpr");
>> + report(!memcmp(&status->crs[1], nullp, sizeof(status->crs[1]) * 12), "cr1-13 == 0");
>> + report(status->crs[15] == 0, "cr15 == 0");
>> report_prefix_pop();
>>
>> report_prefix_push("initialized");
>>
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-20 14:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 10:46 [kvm-unit-tests PATCH v3 0/9] s390x: smp: Improve smp code and reset checks Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 1/9] s390x: smp: Cleanup smp.c Janosch Frank
2020-01-20 12:02 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 2/9] s390x: smp: Only use smp_cpu_setup once Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 3/9] s390x: Add cpu id to interrupt error prints Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 4/9] s390x: smp: Rework cpu start and active tracking Janosch Frank
2020-01-20 12:06 ` David Hildenbrand
2020-01-20 13:16 ` Thomas Huth
2020-01-20 13:20 ` David Hildenbrand
2020-01-20 14:47 ` Janosch Frank
2020-01-20 14:53 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 5/9] s390x: smp: Wait for cpu setup to finish Janosch Frank
2020-01-20 11:04 ` Cornelia Huck
2020-01-20 12:07 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 6/9] s390x: smp: Loop if secondary cpu returns into cpu setup again Janosch Frank
2020-01-20 11:27 ` Cornelia Huck
2020-01-20 12:07 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 7/9] s390x: smp: Remove unneeded cpu loops Janosch Frank
2020-01-20 11:29 ` Cornelia Huck
2020-01-20 14:41 ` Janosch Frank
2020-01-20 16:11 ` Cornelia Huck
2020-01-21 12:46 ` Janosch Frank
2020-01-21 12:59 ` Cornelia Huck
2020-01-21 13:07 ` Janosch Frank
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 8/9] s390x: smp: Test all CRs on initial reset Janosch Frank
2020-01-20 11:44 ` Cornelia Huck
2020-01-20 12:10 ` David Hildenbrand
2020-01-20 14:49 ` Janosch Frank [this message]
2020-01-20 14:53 ` David Hildenbrand
2020-01-17 10:46 ` [kvm-unit-tests PATCH v3 9/9] s390x: smp: Dirty fpc before initial reset test Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d866273e-5108-e634-4e92-93aa66bbed57@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).