kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] vfio-ccw: make convert_ccw0_to_ccw1 static
@ 2019-06-24  9:07 Cornelia Huck
  2019-06-24 11:55 ` Christian Borntraeger
  0 siblings, 1 reply; 2+ messages in thread
From: Cornelia Huck @ 2019-06-24  9:07 UTC (permalink / raw)
  To: Farhan Ali, Eric Farman
  Cc: Heiko Carstens, Vasily Gorbik, Christian Borntraeger,
	Halil Pasic, linux-s390, kvm, Cornelia Huck

Reported by sparse.

Fixes: 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
On top of my vfio-ccw branch.

s390 arch maintainers: let me know if I should queue it and send
a pull request, or if you prefer to apply it directly.
---
 drivers/s390/cio/vfio_ccw_cp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
index 9cddc1288059..a7b9dfd5b464 100644
--- a/drivers/s390/cio/vfio_ccw_cp.c
+++ b/drivers/s390/cio/vfio_ccw_cp.c
@@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words(
 	idaws[0] += pa->pa_iova & (PAGE_SIZE - 1);
 }
 
-void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
+static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
 {
 	struct ccw0 ccw0;
 	struct ccw1 *pccw1 = source;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] vfio-ccw: make convert_ccw0_to_ccw1 static
  2019-06-24  9:07 [PATCH] vfio-ccw: make convert_ccw0_to_ccw1 static Cornelia Huck
@ 2019-06-24 11:55 ` Christian Borntraeger
  0 siblings, 0 replies; 2+ messages in thread
From: Christian Borntraeger @ 2019-06-24 11:55 UTC (permalink / raw)
  To: Cornelia Huck, Farhan Ali, Eric Farman
  Cc: Heiko Carstens, Vasily Gorbik, Halil Pasic, linux-s390, kvm


On 24.06.19 11:07, Cornelia Huck wrote:
> Reported by sparse.
> 
> Fixes: 7f8e89a8f2fd ("vfio-ccw: Factor out the ccw0-to-ccw1 transition")
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> On top of my vfio-ccw branch.
> 
> s390 arch maintainers: let me know if I should queue it and send
> a pull request, or if you prefer to apply it directly.

I still have to sort out some tooling for the s390 tree and I applied it directly.
Thanks

> ---
>  drivers/s390/cio/vfio_ccw_cp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_cp.c b/drivers/s390/cio/vfio_ccw_cp.c
> index 9cddc1288059..a7b9dfd5b464 100644
> --- a/drivers/s390/cio/vfio_ccw_cp.c
> +++ b/drivers/s390/cio/vfio_ccw_cp.c
> @@ -161,7 +161,7 @@ static inline void pfn_array_idal_create_words(
>  	idaws[0] += pa->pa_iova & (PAGE_SIZE - 1);
>  }
>  
> -void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
> +static void convert_ccw0_to_ccw1(struct ccw1 *source, unsigned long len)
>  {
>  	struct ccw0 ccw0;
>  	struct ccw1 *pccw1 = source;
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-24 11:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-24  9:07 [PATCH] vfio-ccw: make convert_ccw0_to_ccw1 static Cornelia Huck
2019-06-24 11:55 ` Christian Borntraeger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).