From: Paolo Bonzini <pbonzini@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>, alex.williamson@redhat.com
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, arei.gonglei@huawei.com
Subject: Re: [PATCH v5 4/6] kvm: irqchip: extract kvm_irqchip_add_deferred_msi_route
Date: Fri, 12 Nov 2021 10:31:50 +0100 [thread overview]
Message-ID: <e4b6e45f-dddd-8401-8d7b-9d9cc4f1def0@redhat.com> (raw)
In-Reply-To: <20211103081657.1945-5-longpeng2@huawei.com>
On 11/3/21 09:16, Longpeng(Mike) wrote:
> Extract a common helper that add MSI route for specific vector
> but does not commit immediately.
>
> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
I think adding the new function is not necessary; I have no problem
moving the call to kvm_irqchip_commit_routes to the callers. Perhaps
you can have an API like this:
typedef struct KVMRouteChange {
KVMState *s;
int changes;
} KVMRouteChange;
KVMRouteChange kvm_irqchip_begin_route_changes(KVMState *s)
{
return (KVMRouteChange) { .s = s, .changes = 0 };
}
void kvm_irqchip_commit_route_changes(KVMRouteChange *c)
{
if (c->changes) {
kvm_irqchip_commit_routes(c->s);
c->changes = 0;
}
}
int kvm_irqchip_add_msi_route(KVMRouteChange *c, int vector, PCIDevice *dev)
{
KVMState *s = c->s;
...
kvm_add_routing_entry(s, &kroute);
kvm_arch_add_msi_route_post(&kroute, vector, dev);
c->changes++;
return virq;
}
so it's harder for the callers to "forget" kvm_irqchip_commit_route_changes.
Paolo
> ---
> accel/kvm/kvm-all.c | 15 +++++++++++++--
> include/sysemu/kvm.h | 6 ++++++
> 2 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index db8d83b..8627f7c 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -1953,7 +1953,7 @@ int kvm_irqchip_send_msi(KVMState *s, MSIMessage msg)
> return kvm_set_irq(s, route->kroute.gsi, 1);
> }
>
> -int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev)
> +int kvm_irqchip_add_deferred_msi_route(KVMState *s, int vector, PCIDevice *dev)
> {
> struct kvm_irq_routing_entry kroute = {};
> int virq;
> @@ -1996,7 +1996,18 @@ int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev)
>
> kvm_add_routing_entry(s, &kroute);
> kvm_arch_add_msi_route_post(&kroute, vector, dev);
> - kvm_irqchip_commit_routes(s);
> +
> + return virq;
> +}
> +
> +int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev)
> +{
> + int virq;
> +
> + virq = kvm_irqchip_add_deferred_msi_route(s, vector, dev);
> + if (virq >= 0) {
> + kvm_irqchip_commit_routes(s);
> + }
>
> return virq;
> }
> diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
> index a1ab1ee..8de0d9a 100644
> --- a/include/sysemu/kvm.h
> +++ b/include/sysemu/kvm.h
> @@ -476,6 +476,12 @@ void kvm_init_cpu_signals(CPUState *cpu);
> * @return: virq (>=0) when success, errno (<0) when failed.
> */
> int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev);
> +/**
> + * Add MSI route for specific vector but does not commit to KVM
> + * immediately
> + */
> +int kvm_irqchip_add_deferred_msi_route(KVMState *s, int vector,
> + PCIDevice *dev);
> int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg,
> PCIDevice *dev);
> void kvm_irqchip_commit_routes(KVMState *s);
>
next prev parent reply other threads:[~2021-11-12 9:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 8:16 [PATCH v5 0/6] optimize the downtime for vfio migration Longpeng(Mike)
2021-11-03 8:16 ` [PATCH v5 1/6] vfio: simplify the conditional statements in vfio_msi_enable Longpeng(Mike)
2021-11-03 8:16 ` [PATCH v5 2/6] vfio: move re-enabling INTX out of the common helper Longpeng(Mike)
2021-11-03 8:16 ` [PATCH v5 3/6] vfio: simplify the failure path in vfio_msi_enable Longpeng(Mike)
2021-11-03 8:16 ` [PATCH v5 4/6] kvm: irqchip: extract kvm_irqchip_add_deferred_msi_route Longpeng(Mike)
2021-11-12 3:59 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-11-12 9:31 ` Paolo Bonzini [this message]
2021-11-13 9:21 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-11-03 8:16 ` [PATCH v5 5/6] Revert "vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration" Longpeng(Mike)
2021-11-03 8:16 ` [PATCH v5 6/6] vfio: defer to commit kvm irq routing when enable msi/msix Longpeng(Mike)
2021-11-03 20:36 ` [PATCH v5 0/6] optimize the downtime for vfio migration Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b6e45f-dddd-8401-8d7b-9d9cc4f1def0@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).