* "KVM: x86: enable -Werror" breaks W=1 compilation
@ 2020-02-13 13:50 Qian Cai
2020-02-13 17:23 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Qian Cai @ 2020-02-13 13:50 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: joe, kvm, linux-kernel
People have been running W=1 to catch additional compilation warnings with an
expectation that not all of warnings will be fixed, but the linux-next commit
ead68df94d24 ("KVM: x86: enable -Werror") breaks the build for them.
arch/x86/kvm/../../../virt/kvm/kvm_main.c:663:12: error: no previous prototype
for ‘kvm_arch_post_init_vm’ [-Werror=missing-prototypes]
int __weak kvm_arch_post_init_vm(struct kvm *kvm)
^~~~~~~~~~~~~~~~~~~~~
arch/x86/kvm/../../../virt/kvm/kvm_main.c:672:13: error: no previous prototype
for ‘kvm_arch_pre_destroy_vm’ [-Werror=missing-prototypes]
void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: "KVM: x86: enable -Werror" breaks W=1 compilation
2020-02-13 13:50 "KVM: x86: enable -Werror" breaks W=1 compilation Qian Cai
@ 2020-02-13 17:23 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-02-13 17:23 UTC (permalink / raw)
To: Qian Cai; +Cc: joe, kvm, linux-kernel
On 13/02/20 14:50, Qian Cai wrote:
> People have been running W=1 to catch additional compilation warnings with an
> expectation that not all of warnings will be fixed, but the linux-next commit
> ead68df94d24 ("KVM: x86: enable -Werror") breaks the build for them.
>
> arch/x86/kvm/../../../virt/kvm/kvm_main.c:663:12: error: no previous prototype
> for ‘kvm_arch_post_init_vm’ [-Werror=missing-prototypes]
> int __weak kvm_arch_post_init_vm(struct kvm *kvm)
> ^~~~~~~~~~~~~~~~~~~~~
> arch/x86/kvm/../../../virt/kvm/kvm_main.c:672:13: error: no previous prototype
> for ‘kvm_arch_pre_destroy_vm’ [-Werror=missing-prototypes]
> void __weak kvm_arch_pre_destroy_vm(struct kvm *kvm)
Thanks, we already found two bugs, one of them real (it's from
-Wtype-limits). But I'll leave out this commit for now from the pull
request, of course.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-13 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 13:50 "KVM: x86: enable -Werror" breaks W=1 compilation Qian Cai
2020-02-13 17:23 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).