* [kvm-unit-tests PATCH 0/2] s390x: Quick fixes
@ 2019-09-25 13:56 Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 1/2] s390x: Add missing include in smp.h Janosch Frank
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Janosch Frank @ 2019-09-25 13:56 UTC (permalink / raw)
To: kvm; +Cc: linux-s390, david, thuth
Missing free and missing import.
Janosch Frank (2):
s390x: Add missing include in smp.h
s390x: Free allocated page in iep test
lib/s390x/smp.h | 2 ++
s390x/iep.c | 1 +
2 files changed, 3 insertions(+)
--
2.20.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [kvm-unit-tests PATCH 1/2] s390x: Add missing include in smp.h
2019-09-25 13:56 [kvm-unit-tests PATCH 0/2] s390x: Quick fixes Janosch Frank
@ 2019-09-25 13:56 ` Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 2/2] s390x: Free allocated page in iep test Janosch Frank
2019-09-25 13:57 ` [kvm-unit-tests PATCH 0/2] s390x: Quick fixes David Hildenbrand
2 siblings, 0 replies; 5+ messages in thread
From: Janosch Frank @ 2019-09-25 13:56 UTC (permalink / raw)
To: kvm; +Cc: linux-s390, david, thuth
smp.h uses struct lowcore and struct psw, which are defined in
asm/arch_def.h
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
lib/s390x/smp.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/s390x/smp.h b/lib/s390x/smp.h
index 4476c31..ce63a89 100644
--- a/lib/s390x/smp.h
+++ b/lib/s390x/smp.h
@@ -12,6 +12,8 @@
#ifndef SMP_H
#define SMP_H
+#include <asm/arch_def.h>
+
struct cpu {
struct lowcore *lowcore;
uint64_t *stack;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [kvm-unit-tests PATCH 2/2] s390x: Free allocated page in iep test
2019-09-25 13:56 [kvm-unit-tests PATCH 0/2] s390x: Quick fixes Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 1/2] s390x: Add missing include in smp.h Janosch Frank
@ 2019-09-25 13:56 ` Janosch Frank
2019-09-25 15:51 ` Thomas Huth
2019-09-25 13:57 ` [kvm-unit-tests PATCH 0/2] s390x: Quick fixes David Hildenbrand
2 siblings, 1 reply; 5+ messages in thread
From: Janosch Frank @ 2019-09-25 13:56 UTC (permalink / raw)
To: kvm; +Cc: linux-s390, david, thuth
Let's also clean up
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
---
s390x/iep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/s390x/iep.c b/s390x/iep.c
index 7da78a3..55c01ee 100644
--- a/s390x/iep.c
+++ b/s390x/iep.c
@@ -43,6 +43,7 @@ static void test_iep(void)
report_prefix_pop();
unprotect_page(iepbuf, PAGE_ENTRY_IEP);
ctl_clear_bit(0, 20);
+ free_page(iepbuf);
}
int main(void)
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [kvm-unit-tests PATCH 0/2] s390x: Quick fixes
2019-09-25 13:56 [kvm-unit-tests PATCH 0/2] s390x: Quick fixes Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 1/2] s390x: Add missing include in smp.h Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 2/2] s390x: Free allocated page in iep test Janosch Frank
@ 2019-09-25 13:57 ` David Hildenbrand
2 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2019-09-25 13:57 UTC (permalink / raw)
To: Janosch Frank, kvm; +Cc: linux-s390, thuth
On 25.09.19 15:56, Janosch Frank wrote:
> Missing free and missing import.
>
> Janosch Frank (2):
> s390x: Add missing include in smp.h
> s390x: Free allocated page in iep test
>
> lib/s390x/smp.h | 2 ++
> s390x/iep.c | 1 +
> 2 files changed, 3 insertions(+)
>
To both
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [kvm-unit-tests PATCH 2/2] s390x: Free allocated page in iep test
2019-09-25 13:56 ` [kvm-unit-tests PATCH 2/2] s390x: Free allocated page in iep test Janosch Frank
@ 2019-09-25 15:51 ` Thomas Huth
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2019-09-25 15:51 UTC (permalink / raw)
To: Janosch Frank, kvm; +Cc: linux-s390, david
On 25/09/2019 15.56, Janosch Frank wrote:
> Let's also clean up
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/iep.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/s390x/iep.c b/s390x/iep.c
> index 7da78a3..55c01ee 100644
> --- a/s390x/iep.c
> +++ b/s390x/iep.c
> @@ -43,6 +43,7 @@ static void test_iep(void)
> report_prefix_pop();
> unprotect_page(iepbuf, PAGE_ENTRY_IEP);
> ctl_clear_bit(0, 20);
> + free_page(iepbuf);
> }
>
> int main(void)
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-25 15:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 13:56 [kvm-unit-tests PATCH 0/2] s390x: Quick fixes Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 1/2] s390x: Add missing include in smp.h Janosch Frank
2019-09-25 13:56 ` [kvm-unit-tests PATCH 2/2] s390x: Free allocated page in iep test Janosch Frank
2019-09-25 15:51 ` Thomas Huth
2019-09-25 13:57 ` [kvm-unit-tests PATCH 0/2] s390x: Quick fixes David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).