* Re: [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode()
@ 2019-11-30 7:20 linmiaohe
2019-12-06 10:10 ` Steven Price
0 siblings, 1 reply; 4+ messages in thread
From: linmiaohe @ 2019-11-30 7:20 UTC (permalink / raw)
To: maz, james.morse, julien.thierry.kdev, suzuki.poulose,
christoffer.dall, catalin.marinas, eric.auger, gregkh, will,
andre.przywara, tglx
Cc: kvm, kvmarm, linux-arm-kernel, linux-kernel
>From: Miaohe Lin <linmiaohe@huawei.com>
>
>As arg dummy is not really needed, there's no need to pass NULL when calling cpu_init_hyp_mode(). So clean it up.
>
>Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>---
> virt/kvm/arm/arm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 86c6aa1cb58e..a5470f1b1a19 100644
>--- a/virt/kvm/arm/arm.c
>+++ b/virt/kvm/arm/arm.c
>@@ -1315,7 +1315,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
> }
> }
>
>-static void cpu_init_hyp_mode(void *dummy)
>+static void cpu_init_hyp_mode(void)
> {
> phys_addr_t pgd_ptr;
> unsigned long hyp_stack_ptr;
>@@ -1349,7 +1349,7 @@ static void cpu_hyp_reinit(void)
> if (is_kernel_in_hyp_mode())
> kvm_timer_init_vhe();
> else
>- cpu_init_hyp_mode(NULL);
>+ cpu_init_hyp_mode();
>
> kvm_arm_init_debug();
>
friendly ping ...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode()
2019-11-30 7:20 [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode() linmiaohe
@ 2019-12-06 10:10 ` Steven Price
0 siblings, 0 replies; 4+ messages in thread
From: Steven Price @ 2019-12-06 10:10 UTC (permalink / raw)
To: linmiaohe, maz, james.morse, julien.thierry.kdev, suzuki.poulose,
christoffer.dall, catalin.marinas, eric.auger, gregkh, will,
andre.przywara, tglx
Cc: kvm, kvmarm, linux-arm-kernel, linux-kernel
On 30/11/2019 07:20, linmiaohe wrote:
>> From: Miaohe Lin <linmiaohe@huawei.com>
>>
>> As arg dummy is not really needed, there's no need to pass NULL when calling cpu_init_hyp_mode(). So clean it up.
It looks like the requirement for this dummy arg was removed in
67f691976662 ("arm64: kvm: allows kvm cpu hotplug"). FWIW:
Reviewed-by: Steven Price <steven.price@arm.com>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> virt/kvm/arm/arm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 86c6aa1cb58e..a5470f1b1a19 100644
>> --- a/virt/kvm/arm/arm.c
>> +++ b/virt/kvm/arm/arm.c
>> @@ -1315,7 +1315,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
>> }
>> }
>>
>> -static void cpu_init_hyp_mode(void *dummy)
>> +static void cpu_init_hyp_mode(void)
>> {
>> phys_addr_t pgd_ptr;
>> unsigned long hyp_stack_ptr;
>> @@ -1349,7 +1349,7 @@ static void cpu_hyp_reinit(void)
>> if (is_kernel_in_hyp_mode())
>> kvm_timer_init_vhe();
>> else
>> - cpu_init_hyp_mode(NULL);
>> + cpu_init_hyp_mode();
>>
>> kvm_arm_init_debug();
>>
> friendly ping ...
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode()
@ 2019-11-21 7:15 linmiaohe
2019-12-06 11:43 ` Marc Zyngier
0 siblings, 1 reply; 4+ messages in thread
From: linmiaohe @ 2019-11-21 7:15 UTC (permalink / raw)
To: maz, pbonzini, rkrcmar, james.morse, julien.thierry.kdev, suzuki.poulose
Cc: kvm, kvmarm, linux-arm-kernel, linux-kernel
From: Miaohe Lin <linmiaohe@huawei.com>
As arg dummy is not really needed, there's no need to pass
NULL when calling cpu_init_hyp_mode(). So clean it up.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
virt/kvm/arm/arm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
index 86c6aa1cb58e..a5470f1b1a19 100644
--- a/virt/kvm/arm/arm.c
+++ b/virt/kvm/arm/arm.c
@@ -1315,7 +1315,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
}
}
-static void cpu_init_hyp_mode(void *dummy)
+static void cpu_init_hyp_mode(void)
{
phys_addr_t pgd_ptr;
unsigned long hyp_stack_ptr;
@@ -1349,7 +1349,7 @@ static void cpu_hyp_reinit(void)
if (is_kernel_in_hyp_mode())
kvm_timer_init_vhe();
else
- cpu_init_hyp_mode(NULL);
+ cpu_init_hyp_mode();
kvm_arm_init_debug();
--
2.19.1
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode()
2019-11-21 7:15 linmiaohe
@ 2019-12-06 11:43 ` Marc Zyngier
0 siblings, 0 replies; 4+ messages in thread
From: Marc Zyngier @ 2019-12-06 11:43 UTC (permalink / raw)
To: linmiaohe; +Cc: kvm, linux-kernel, pbonzini, kvmarm, linux-arm-kernel
On 2019-11-21 07:15, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> As arg dummy is not really needed, there's no need to pass
> NULL when calling cpu_init_hyp_mode(). So clean it up.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> virt/kvm/arm/arm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 86c6aa1cb58e..a5470f1b1a19 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1315,7 +1315,7 @@ long kvm_arch_vm_ioctl(struct file *filp,
> }
> }
>
> -static void cpu_init_hyp_mode(void *dummy)
> +static void cpu_init_hyp_mode(void)
> {
> phys_addr_t pgd_ptr;
> unsigned long hyp_stack_ptr;
> @@ -1349,7 +1349,7 @@ static void cpu_hyp_reinit(void)
> if (is_kernel_in_hyp_mode())
> kvm_timer_init_vhe();
> else
> - cpu_init_hyp_mode(NULL);
> + cpu_init_hyp_mode();
>
> kvm_arm_init_debug();
Applied, thanks.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-06 11:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-30 7:20 [PATCH] KVM: arm: get rid of unused arg in cpu_init_hyp_mode() linmiaohe
2019-12-06 10:10 ` Steven Price
-- strict thread matches above, loose matches on Subject: below --
2019-11-21 7:15 linmiaohe
2019-12-06 11:43 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).