kvmarm.lists.cs.columbia.edu archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/6] KVM: Standardize on "int" return types instead of "long"
@ 2023-02-08 14:00 Thomas Huth
  2023-02-08 14:01 ` [PATCH v2 1/6] KVM: PPC: Standardize on "int" return types in the powerpc KVM code Thomas Huth
                   ` (6 more replies)
  0 siblings, 7 replies; 14+ messages in thread
From: Thomas Huth @ 2023-02-08 14:00 UTC (permalink / raw)
  To: kvm, Paolo Bonzini, Sean Christopherson
  Cc: kvmarm, linux-kernel, kvm-riscv, Marc Zyngier, James Morse,
	Suzuki K Poulose, Oliver Upton, Zenghui Yu,
	Christian Borntraeger, Janosch Frank, David Hildenbrand,
	Gavin Shan, Steven Price, Cornelia Huck

KVM functions use "long" return values for functions that are wired up
to "struct file_operations", but otherwise use "int" return values for
functions that can return 0/-errno in order to avoid unintentional
divergences between 32-bit and 64-bit kernels. Some related functions
that are not part of a "struct file_operations" still use "long", though,
which can cause confusion or even subtle problems (see the x86 and the
arm64 patches). Thus let's standardize on using "int" for return values
in these functions to avoid such problems in the future.

v2:
- Remove KVM_GET_NR_MMU_PAGES ioctl instead of trying to work-around
  the problem (the ioctl is not used in any userspace app anyway)
- Add check for INT_MAX to the arm64 patch
- Added Reviewed-bys from v1

Thomas Huth (6):
  KVM: PPC: Standardize on "int" return types in the powerpc KVM code
  KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys()
  KVM: x86: Remove the KVM_GET_NR_MMU_PAGES ioctl
  KVM: arm64: Limit length in kvm_vm_ioctl_mte_copy_tags() to INT_MAX
  KVM: Standardize on "int" return types instead of "long" in kvm_main.c
  KVM: Change return type of kvm_arch_vm_ioctl() to "int"

 Documentation/virt/kvm/api.rst      |  3 ++-
 arch/arm64/include/asm/kvm_host.h   |  4 ++--
 arch/arm64/kvm/arm.c                |  3 +--
 arch/arm64/kvm/guest.c              |  8 ++++++--
 arch/mips/kvm/mips.c                |  4 ++--
 arch/powerpc/include/asm/kvm_ppc.h  | 14 +++++++-------
 arch/powerpc/kvm/book3s_64_mmu_hv.c | 14 +++++++-------
 arch/powerpc/kvm/book3s_64_vio.c    |  4 ++--
 arch/powerpc/kvm/book3s_hv.c        |  6 +++---
 arch/powerpc/kvm/book3s_pr.c        |  4 ++--
 arch/powerpc/kvm/powerpc.c          |  5 ++---
 arch/riscv/kvm/vm.c                 |  3 +--
 arch/s390/kvm/kvm-s390.c            |  7 +++----
 arch/x86/kvm/x86.c                  | 11 +----------
 include/linux/kvm_host.h            |  3 +--
 include/uapi/linux/kvm.h            |  2 +-
 tools/include/uapi/linux/kvm.h      |  2 +-
 virt/kvm/kvm_main.c                 |  4 ++--
 18 files changed, 46 insertions(+), 55 deletions(-)

-- 
2.31.1


^ permalink raw reply	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-03-14 13:35 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 14:00 [PATCH v2 0/6] KVM: Standardize on "int" return types instead of "long" Thomas Huth
2023-02-08 14:01 ` [PATCH v2 1/6] KVM: PPC: Standardize on "int" return types in the powerpc KVM code Thomas Huth
2023-02-08 14:01 ` [PATCH v2 2/6] KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys() Thomas Huth
2023-02-08 14:01 ` [PATCH v2 3/6] KVM: x86: Remove the KVM_GET_NR_MMU_PAGES ioctl Thomas Huth
2023-02-08 14:48   ` Sean Christopherson
2023-02-08 14:01 ` [PATCH v2 4/6] KVM: arm64: Limit length in kvm_vm_ioctl_mte_copy_tags() to INT_MAX Thomas Huth
2023-02-08 14:05   ` Steven Price
2023-02-08 15:03   ` Cornelia Huck
2023-02-10  6:50   ` Gavin Shan
2023-02-08 14:01 ` [PATCH v2 5/6] KVM: Standardize on "int" return types instead of "long" in kvm_main.c Thomas Huth
2023-02-08 14:01 ` [PATCH v2 6/6] KVM: Change return type of kvm_arch_vm_ioctl() to "int" Thomas Huth
2023-02-28 21:05   ` Thomas Huth
2023-03-01  3:36   ` Anup Patel
2023-03-14 13:35 ` [PATCH v2 0/6] KVM: Standardize on "int" return types instead of "long" Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).