From: Peter Xu <peterx@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: kvm@vger.kernel.org, catalin.marinas@arm.com,
andrew.jones@linux.dev, dmatlack@google.com, will@kernel.org,
shan.gavin@gmail.com, bgardon@google.com, kvmarm@lists.linux.dev,
pbonzini@redhat.com, zhenyzha@redhat.com, shuah@kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v5 3/7] KVM: x86: Allow to use bitmap in ring-based dirty page tracking
Date: Thu, 6 Oct 2022 16:28:48 -0400 [thread overview]
Message-ID: <Yz86gEbNflDpC8As@x1n> (raw)
In-Reply-To: <20221005004154.83502-4-gshan@redhat.com>
On Wed, Oct 05, 2022 at 08:41:50AM +0800, Gavin Shan wrote:
> -8.29 KVM_CAP_DIRTY_LOG_RING/KVM_CAP_DIRTY_LOG_RING_ACQ_REL
> -----------------------------------------------------------
> +8.29 KVM_CAP_DIRTY_LOG_{RING, RING_ACQ_REL, RING_ALLOW_BITMAP}
> +--------------------------------------------------------------
Shall we make it a standalone cap, just to rely on DIRTY_RING[_ACQ_REL]
being enabled first, instead of making the three caps at the same level?
E.g. we can skip creating bitmap for DIRTY_RING[_ACQ_REL] && !_ALLOW_BITMAP
(x86).
> @@ -2060,10 +2060,6 @@ int kvm_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log,
> unsigned long n;
> unsigned long any = 0;
>
> - /* Dirty ring tracking is exclusive to dirty log tracking */
> - if (kvm->dirty_ring_size)
> - return -ENXIO;
Then we can also have one dirty_ring_exclusive(), with something like:
bool dirty_ring_exclusive(struct kvm *kvm)
{
return kvm->dirty_ring_size && !kvm->dirty_ring_allow_bitmap;
}
Does it make sense? Thanks,
--
Peter Xu
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: kvmarm@lists.linux.dev, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, catalin.marinas@arm.com, bgardon@google.com,
shuah@kernel.org, andrew.jones@linux.dev, will@kernel.org,
dmatlack@google.com, pbonzini@redhat.com, zhenyzha@redhat.com,
james.morse@arm.com, suzuki.poulose@arm.com,
alexandru.elisei@arm.com, oliver.upton@linux.dev,
seanjc@google.com, shan.gavin@gmail.com
Subject: Re: [PATCH v5 3/7] KVM: x86: Allow to use bitmap in ring-based dirty page tracking
Date: Thu, 6 Oct 2022 16:28:48 -0400 [thread overview]
Message-ID: <Yz86gEbNflDpC8As@x1n> (raw)
Message-ID: <20221006202848.kMPEYQ_o-ccwR_AMjjNXxYr2eOzOpg4ZExv8Zt4ffBM@z> (raw)
In-Reply-To: <20221005004154.83502-4-gshan@redhat.com>
On Wed, Oct 05, 2022 at 08:41:50AM +0800, Gavin Shan wrote:
> -8.29 KVM_CAP_DIRTY_LOG_RING/KVM_CAP_DIRTY_LOG_RING_ACQ_REL
> -----------------------------------------------------------
> +8.29 KVM_CAP_DIRTY_LOG_{RING, RING_ACQ_REL, RING_ALLOW_BITMAP}
> +--------------------------------------------------------------
Shall we make it a standalone cap, just to rely on DIRTY_RING[_ACQ_REL]
being enabled first, instead of making the three caps at the same level?
E.g. we can skip creating bitmap for DIRTY_RING[_ACQ_REL] && !_ALLOW_BITMAP
(x86).
> @@ -2060,10 +2060,6 @@ int kvm_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log,
> unsigned long n;
> unsigned long any = 0;
>
> - /* Dirty ring tracking is exclusive to dirty log tracking */
> - if (kvm->dirty_ring_size)
> - return -ENXIO;
Then we can also have one dirty_ring_exclusive(), with something like:
bool dirty_ring_exclusive(struct kvm *kvm)
{
return kvm->dirty_ring_size && !kvm->dirty_ring_allow_bitmap;
}
Does it make sense? Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-10-06 20:28 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 0:41 [PATCH v5 0/7] KVM: arm64: Enable ring-based dirty memory tracking Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-05 0:41 ` [PATCH v5 1/7] KVM: x86: Introduce KVM_REQ_RING_SOFT_FULL Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-05 0:41 ` [PATCH v5 2/7] KVM: x86: Move declaration of kvm_cpu_dirty_log_size() to kvm_dirty_ring.h Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-05 0:41 ` [PATCH v5 3/7] KVM: x86: Allow to use bitmap in ring-based dirty page tracking Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-06 20:28 ` Peter Xu [this message]
2022-10-06 20:28 ` Peter Xu
2022-10-06 23:38 ` Gavin Shan
2022-10-06 23:38 ` Gavin Shan
2022-10-07 14:31 ` Peter Xu
2022-10-07 14:31 ` Peter Xu
2022-10-10 23:18 ` Oliver Upton
2022-10-10 23:18 ` Oliver Upton
2022-10-10 23:43 ` Oliver Upton
2022-10-10 23:43 ` Oliver Upton
2022-10-10 23:49 ` Peter Xu
2022-10-10 23:49 ` Peter Xu
2022-10-10 23:58 ` Gavin Shan
2022-10-10 23:58 ` Gavin Shan
2022-10-10 23:58 ` Oliver Upton
2022-10-10 23:58 ` Oliver Upton
2022-10-11 0:20 ` Peter Xu
2022-10-11 0:20 ` Peter Xu
2022-10-11 1:12 ` Oliver Upton
2022-10-11 1:12 ` Oliver Upton
2022-10-11 3:56 ` Gavin Shan
2022-10-11 3:56 ` Gavin Shan
2022-10-11 6:31 ` Gavin Shan
2022-10-11 6:31 ` Gavin Shan
2022-10-14 16:55 ` Peter Xu
2022-10-14 16:55 ` Peter Xu
2022-10-18 7:38 ` Oliver Upton
2022-10-18 7:38 ` Oliver Upton
2022-10-18 7:40 ` Oliver Upton
2022-10-18 7:40 ` Oliver Upton
2022-10-18 15:50 ` Peter Xu
2022-10-18 15:50 ` Peter Xu
2022-10-05 0:41 ` [PATCH v5 4/7] KVM: arm64: Enable ring-based dirty memory tracking Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-05 0:41 ` [PATCH v5 5/7] KVM: selftests: Use host page size to map ring buffer in dirty_log_test Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-05 0:41 ` [PATCH v5 6/7] KVM: selftests: Clear dirty ring states between two modes " Gavin Shan
2022-10-05 0:41 ` Gavin Shan
2022-10-05 0:41 ` [PATCH v5 7/7] KVM: selftests: Automate choosing dirty ring size " Gavin Shan
2022-10-05 0:41 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz86gEbNflDpC8As@x1n \
--to=peterx@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=bgardon@google.com \
--cc=catalin.marinas@arm.com \
--cc=dmatlack@google.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=pbonzini@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=zhenyzha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).