* [PATCH] tools/acpi: fix compilation error
@ 2019-11-19 12:52 Zhengyuan Liu
2019-12-12 22:00 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Zhengyuan Liu @ 2019-11-19 12:52 UTC (permalink / raw)
To: rafael.j.wysocki, robert.moore; +Cc: linux-acpi, lv.zheng
From: liuzhengyuan <liuzhengyuan@kylinos.com.cn>
If we compile tools/acpi target in the top source directory, we'd get a
compilation error showing as bellow:
# make tools/acpi
DESCEND power/acpi
DESCEND tools/acpidbg
CC tools/acpidbg/acpidbg.o
Assembler messages:
Fatal error: can't create /home/lzy/kernel-upstream/linux-linus-ubuntu/power\
/acpi/tools/acpidbg/acpidbg.o: No such file or directory
../../Makefile.rules:26: recipe for target '/home/lzy/kernel-upstream/linux-\
linus-ubuntu/power/acpi/tools/acpidbg/acpidbg.o' failed
make[3]: *** [/home/lzy/kernel-upstream/linux-linus-ubuntu/power/acpi/tools/\
acpidbg/acpidbg.o] Error 1
Makefile:19: recipe for target 'acpidbg' failed
make[2]: *** [acpidbg] Error 2
Makefile:54: recipe for target 'acpi' failed
make[1]: *** [acpi] Error 2
Makefile:1607: recipe for target 'tools/acpi' failed
make: *** [tools/acpi] Error 2
Fixes: d5a4b1a540b ("tools/power/acpi: Remove direct kernel source include reference")
Signed-off-by: liuzhengyuan <liuzhengyuan@kylinos.com.cn>
---
tools/power/acpi/Makefile.config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config
index 0111d24..54a2857 100644
--- a/tools/power/acpi/Makefile.config
+++ b/tools/power/acpi/Makefile.config
@@ -15,7 +15,7 @@ include $(srctree)/../../scripts/Makefile.include
OUTPUT=$(srctree)/
ifeq ("$(origin O)", "command line")
- OUTPUT := $(O)/power/acpi/
+ OUTPUT := $(O)/tools/power/acpi/
endif
#$(info Determined 'OUTPUT' to be $(OUTPUT))
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/acpi: fix compilation error
2019-11-19 12:52 [PATCH] tools/acpi: fix compilation error Zhengyuan Liu
@ 2019-12-12 22:00 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-12-12 22:00 UTC (permalink / raw)
To: Zhengyuan Liu; +Cc: rafael.j.wysocki, robert.moore, linux-acpi, lv.zheng
On Tuesday, November 19, 2019 1:52:09 PM CET Zhengyuan Liu wrote:
> From: liuzhengyuan <liuzhengyuan@kylinos.com.cn>
>
> If we compile tools/acpi target in the top source directory, we'd get a
> compilation error showing as bellow:
>
> # make tools/acpi
> DESCEND power/acpi
> DESCEND tools/acpidbg
> CC tools/acpidbg/acpidbg.o
> Assembler messages:
> Fatal error: can't create /home/lzy/kernel-upstream/linux-linus-ubuntu/power\
> /acpi/tools/acpidbg/acpidbg.o: No such file or directory
> ../../Makefile.rules:26: recipe for target '/home/lzy/kernel-upstream/linux-\
> linus-ubuntu/power/acpi/tools/acpidbg/acpidbg.o' failed
> make[3]: *** [/home/lzy/kernel-upstream/linux-linus-ubuntu/power/acpi/tools/\
> acpidbg/acpidbg.o] Error 1
> Makefile:19: recipe for target 'acpidbg' failed
> make[2]: *** [acpidbg] Error 2
> Makefile:54: recipe for target 'acpi' failed
> make[1]: *** [acpi] Error 2
> Makefile:1607: recipe for target 'tools/acpi' failed
> make: *** [tools/acpi] Error 2
>
> Fixes: d5a4b1a540b ("tools/power/acpi: Remove direct kernel source include reference")
> Signed-off-by: liuzhengyuan <liuzhengyuan@kylinos.com.cn>
You evidently could use the proper English spelling of your full name when
sending the message, so what would be wrong with using it for the sign-off too?
> ---
> tools/power/acpi/Makefile.config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config
> index 0111d24..54a2857 100644
> --- a/tools/power/acpi/Makefile.config
> +++ b/tools/power/acpi/Makefile.config
> @@ -15,7 +15,7 @@ include $(srctree)/../../scripts/Makefile.include
>
> OUTPUT=$(srctree)/
> ifeq ("$(origin O)", "command line")
> - OUTPUT := $(O)/power/acpi/
> + OUTPUT := $(O)/tools/power/acpi/
> endif
> #$(info Determined 'OUTPUT' to be $(OUTPUT))
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-12 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 12:52 [PATCH] tools/acpi: fix compilation error Zhengyuan Liu
2019-12-12 22:00 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).