* [PATCH v2 01/15] ACPI: cmos_rtc: Remove the leftover ACPICA code ACPI_MODULE_NAME()
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 02/15] ACPI: LPSS: Remove the ACPI_MODULE_NAME() Hanjun Guo
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
ACPI_MODULE_NAME() is only needed for ACPICA debug functionality
such as ACPI_DEBUG_PRINT() which is not used in acpi_cmos_rtc.c,
remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/acpi_cmos_rtc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/acpi_cmos_rtc.c
index 33ac6cb..67f1d33 100644
--- a/drivers/acpi/acpi_cmos_rtc.c
+++ b/drivers/acpi/acpi_cmos_rtc.c
@@ -15,8 +15,6 @@
#include "internal.h"
-ACPI_MODULE_NAME("cmos rtc");
-
static const struct acpi_device_id acpi_cmos_rtc_ids[] = {
{ "PNP0B00" },
{ "PNP0B01" },
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 02/15] ACPI: LPSS: Remove the ACPI_MODULE_NAME()
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 01/15] ACPI: cmos_rtc: Remove the leftover ACPICA code ACPI_MODULE_NAME() Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 03/15] ACPI: memhotplug: Remove the leftover ACPICA debug functionality Hanjun Guo
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
ACPI_MODULE_NAME() is only needed for ACPICA debug functionality
such as ACPI_DEBUG_PRINT() which is not used in acpi_lpss.c,
remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/acpi_lpss.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 5e2bfbc..46e307e 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -26,8 +26,6 @@
#include "internal.h"
-ACPI_MODULE_NAME("acpi_lpss");
-
#ifdef CONFIG_X86_INTEL_LPSS
#include <asm/cpu_device_id.h>
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 03/15] ACPI: memhotplug: Remove the leftover ACPICA debug functionality
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 01/15] ACPI: cmos_rtc: Remove the leftover ACPICA code ACPI_MODULE_NAME() Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 02/15] ACPI: LPSS: Remove the ACPI_MODULE_NAME() Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 04/15] ACPI: platform: Remove the ACPI_MODULE_NAME() Hanjun Guo
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
After commit 0a34764411aa ("ACPI / scan: Make memory hotplug drive
use struct acpi_scan_handler"), all the ACPICA debug functionality
was removed, remove the leftover ACPICA debug code.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/acpi_memhotplug.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index e294f44..9cd987d 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -22,13 +22,6 @@
#define ACPI_MEMORY_DEVICE_HID "PNP0C80"
#define ACPI_MEMORY_DEVICE_NAME "Hotplug Mem Device"
-#define _COMPONENT ACPI_MEMORY_DEVICE_COMPONENT
-
-#undef PREFIX
-#define PREFIX "ACPI:memory_hp:"
-
-ACPI_MODULE_NAME("acpi_memhotplug");
-
static const struct acpi_device_id memory_device_ids[] = {
{ACPI_MEMORY_DEVICE_HID, 0},
{"", 0},
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 04/15] ACPI: platform: Remove the ACPI_MODULE_NAME()
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (2 preceding siblings ...)
2020-09-24 2:56 ` [PATCH v2 03/15] ACPI: memhotplug: Remove the leftover ACPICA debug functionality Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 05/15] ACPI: container: Remove the leftover ACPICA debug functionality Hanjun Guo
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
ACPI_MODULE_NAME() is not used in the acpi_platform.c, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/acpi_platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
index c05050f..78d6212 100644
--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -19,8 +19,6 @@
#include "internal.h"
-ACPI_MODULE_NAME("platform");
-
static const struct acpi_device_id forbidden_id_list[] = {
{"PNP0000", 0}, /* PIC */
{"PNP0100", 0}, /* Timer */
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 05/15] ACPI: container: Remove the leftover ACPICA debug functionality
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (3 preceding siblings ...)
2020-09-24 2:56 ` [PATCH v2 04/15] ACPI: platform: Remove the ACPI_MODULE_NAME() Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 06/15] ACPI: custom_method: Remove the dead ACPICA debug code Hanjun Guo
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
After commit 737f1a9f8082 ("ACPI / scan: Make container driver use
struct acpi_scan_handler"), ACPICA debug print function calls were
removed, so the leftover ACPICA debug functionality is useless,
remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/container.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
index 9ea5f55..ccaa647 100644
--- a/drivers/acpi/container.c
+++ b/drivers/acpi/container.c
@@ -14,9 +14,6 @@
#include "internal.h"
-#define _COMPONENT ACPI_CONTAINER_COMPONENT
-ACPI_MODULE_NAME("container");
-
static const struct acpi_device_id container_device_ids[] = {
{"ACPI0004", 0},
{"PNP0A05", 0},
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 06/15] ACPI: custom_method: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (4 preceding siblings ...)
2020-09-24 2:56 ` [PATCH v2 05/15] ACPI: container: Remove the leftover ACPICA debug functionality Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:56 ` [PATCH v2 07/15] ACPI: debugfs: " Hanjun Guo
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
ACPICA debug code _COMPONENT and ACPI_MODULE_NAME() is not
used in custom_method.c, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/custom_method.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/custom_method.c b/drivers/acpi/custom_method.c
index b097ef2..7b54dc9 100644
--- a/drivers/acpi/custom_method.c
+++ b/drivers/acpi/custom_method.c
@@ -13,8 +13,6 @@
#include "internal.h"
-#define _COMPONENT ACPI_SYSTEM_COMPONENT
-ACPI_MODULE_NAME("custom_method");
MODULE_LICENSE("GPL");
static struct dentry *cm_dentry;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 07/15] ACPI: debugfs: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (5 preceding siblings ...)
2020-09-24 2:56 ` [PATCH v2 06/15] ACPI: custom_method: Remove the dead ACPICA debug code Hanjun Guo
@ 2020-09-24 2:56 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 08/15] ACPI: dock: " Hanjun Guo
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:56 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
The _COMPONENT and ACPI_MODULE_NAME() were not used even when
the debugfs.c was introduced, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/debugfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
index d5ecea3..074eb98d 100644
--- a/drivers/acpi/debugfs.c
+++ b/drivers/acpi/debugfs.c
@@ -10,9 +10,6 @@
#include "internal.h"
-#define _COMPONENT ACPI_SYSTEM_COMPONENT
-ACPI_MODULE_NAME("debugfs");
-
struct dentry *acpi_debugfs_dir;
EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 08/15] ACPI: dock: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (6 preceding siblings ...)
2020-09-24 2:56 ` [PATCH v2 07/15] ACPI: debugfs: " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 09/15] ACPI: event: Remove the leftover " Hanjun Guo
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
The ACPICA debug code ACPI_MODULE_NAME() is not used, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/dock.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 9bd72c2..45d4b7b6 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -20,8 +20,6 @@
#include "internal.h"
-ACPI_MODULE_NAME("dock");
-
static bool immediate_undock = 1;
module_param(immediate_undock, bool, 0644);
MODULE_PARM_DESC(immediate_undock, "1 (default) will cause the driver to "
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 09/15] ACPI: event: Remove the leftover ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (7 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 08/15] ACPI: dock: " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 10/15] ACPI: PCI: Remove the unused " Hanjun Guo
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
After commit (ff491a7334ac "netlink: change return-value logic of
netlink_broadcast()"), ACPI_DEBUG_PRINT() was removed from event.c,
so the ACPICA debug code is not used, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/event.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/acpi/event.c b/drivers/acpi/event.c
index 47f2159..1706439 100644
--- a/drivers/acpi/event.c
+++ b/drivers/acpi/event.c
@@ -19,9 +19,6 @@
#include "internal.h"
-#define _COMPONENT ACPI_SYSTEM_COMPONENT
-ACPI_MODULE_NAME("event");
-
/* ACPI notifier chain */
static BLOCKING_NOTIFIER_HEAD(acpi_chain_head);
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 10/15] ACPI: PCI: Remove the unused ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (8 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 09/15] ACPI: event: Remove the leftover " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 11/15] ACPI: proc: Remove the dead " Hanjun Guo
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
The ACPICA debug code _COMPONENT and ACPI_MODULE_NAME() are
not used, so can be removed.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/pci_root.c | 2 --
drivers/acpi/pci_slot.c | 3 ---
2 files changed, 5 deletions(-)
diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
index f90e841..7a6abd3 100644
--- a/drivers/acpi/pci_root.c
+++ b/drivers/acpi/pci_root.c
@@ -24,8 +24,6 @@
#include "internal.h"
-#define _COMPONENT ACPI_PCI_COMPONENT
-ACPI_MODULE_NAME("pci_root");
#define ACPI_PCI_ROOT_CLASS "pci_bridge"
#define ACPI_PCI_ROOT_DEVICE_NAME "PCI Root Bridge"
static int acpi_pci_root_add(struct acpi_device *device,
diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
index ca2461d..d6cb2c2 100644
--- a/drivers/acpi/pci_slot.c
+++ b/drivers/acpi/pci_slot.c
@@ -28,9 +28,6 @@
static int check_sta_before_sun;
-#define _COMPONENT ACPI_PCI_COMPONENT
-ACPI_MODULE_NAME("pci_slot");
-
#define SLOT_NAME_SIZE 21 /* Inspired by #define in acpiphp.h */
struct acpi_pci_slot {
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 11/15] ACPI: proc: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (9 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 10/15] ACPI: PCI: Remove the unused " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 12/15] ACPI: processor: " Hanjun Guo
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
Remove the not used ACPICA debug code _COMPONENT and ACPI_MODULE_NAME()
which were not used even when proc.c was introduced.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/proc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 7892980..0cca799 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -10,15 +10,11 @@
#include "sleep.h"
#include "internal.h"
-#define _COMPONENT ACPI_SYSTEM_COMPONENT
-
/*
* this file provides support for:
* /proc/acpi/wakeup
*/
-ACPI_MODULE_NAME("sleep")
-
static int
acpi_system_wakeup_device_seq_show(struct seq_file *seq, void *offset)
{
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 12/15] ACPI: processor: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (10 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 11/15] ACPI: proc: Remove the dead " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 13/15] ACPI: tiny-power-button: " Hanjun Guo
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
The ACPICA debug code is not used anywhere in processor_core.c
and processor_thermal.c, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/processor_core.c | 3 ---
drivers/acpi/processor_thermal.c | 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index f32beb7d..2ac48cd 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -14,9 +14,6 @@
#include <linux/acpi.h>
#include <acpi/processor.h>
-#define _COMPONENT ACPI_PROCESSOR_COMPONENT
-ACPI_MODULE_NAME("processor_core");
-
static struct acpi_table_madt *get_madt_table(void)
{
static struct acpi_table_madt *madt;
diff --git a/drivers/acpi/processor_thermal.c b/drivers/acpi/processor_thermal.c
index 41feb88..6c7d05b 100644
--- a/drivers/acpi/processor_thermal.c
+++ b/drivers/acpi/processor_thermal.c
@@ -20,8 +20,6 @@
#define PREFIX "ACPI: "
#define ACPI_PROCESSOR_CLASS "processor"
-#define _COMPONENT ACPI_PROCESSOR_COMPONENT
-ACPI_MODULE_NAME("processor_thermal");
#ifdef CONFIG_CPU_FREQ
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 13/15] ACPI: tiny-power-button: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (11 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 12/15] ACPI: processor: " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 14/15] ACPI: video: Remove the leftover " Hanjun Guo
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
The ACPICA debug code is not used, can be removed.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/tiny-power-button.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/acpi/tiny-power-button.c b/drivers/acpi/tiny-power-button.c
index 6273d73..420e61b 100644
--- a/drivers/acpi/tiny-power-button.c
+++ b/drivers/acpi/tiny-power-button.c
@@ -4,7 +4,6 @@
#include <linux/acpi.h>
#include <acpi/button.h>
-ACPI_MODULE_NAME("tiny-power-button");
MODULE_AUTHOR("Josh Triplett");
MODULE_DESCRIPTION("ACPI Tiny Power Button Driver");
MODULE_LICENSE("GPL");
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 14/15] ACPI: video: Remove the leftover ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (12 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 13/15] ACPI: tiny-power-button: " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-24 2:57 ` [PATCH v2 15/15] ACPI: wakeup: Remove the dead " Hanjun Guo
2020-09-25 16:27 ` [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Rafael J. Wysocki
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
After commit (87521e16a7ab "acpi-video-detect: Rewrite backlight interface
selection logic"), ACPI_DEBUG_PRINT() was remove, so ACPI_MODULE_NAME()
and _COMPONENT are not used anymore, remove them.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/video_detect.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 2499d7e..d2981f7 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -35,9 +35,6 @@
#include <linux/workqueue.h>
#include <acpi/video.h>
-ACPI_MODULE_NAME("video");
-#define _COMPONENT ACPI_VIDEO_COMPONENT
-
void acpi_video_unregister_backlight(void);
static bool backlight_notifier_registered;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH v2 15/15] ACPI: wakeup: Remove the dead ACPICA debug code
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (13 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 14/15] ACPI: video: Remove the leftover " Hanjun Guo
@ 2020-09-24 2:57 ` Hanjun Guo
2020-09-25 16:27 ` [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Rafael J. Wysocki
15 siblings, 0 replies; 17+ messages in thread
From: Hanjun Guo @ 2020-09-24 2:57 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hanjun Guo
The ACPICA debug code of ACPI_SYSTEM_COMPONENT and ACPI_MODULE_NAME()
are not used in wakeup.c, remove it.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/wakeup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/acpi/wakeup.c b/drivers/acpi/wakeup.c
index 0b2e425..f89dd9a 100644
--- a/drivers/acpi/wakeup.c
+++ b/drivers/acpi/wakeup.c
@@ -26,8 +26,6 @@ struct acpi_wakeup_handler {
* suspend/resume and isn't really required as this is called in S-state. At
* that time, there is no device hotplug
**/
-#define _COMPONENT ACPI_SYSTEM_COMPONENT
-ACPI_MODULE_NAME("wakeup_devices")
/**
* acpi_enable_wakeup_devices - Enable wake-up device GPEs.
--
1.7.12.4
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver
2020-09-24 2:56 [PATCH v2 00/15] Cleanups before decoupling ACPICA debug with ACPI driver Hanjun Guo
` (14 preceding siblings ...)
2020-09-24 2:57 ` [PATCH v2 15/15] ACPI: wakeup: Remove the dead " Hanjun Guo
@ 2020-09-25 16:27 ` Rafael J. Wysocki
15 siblings, 0 replies; 17+ messages in thread
From: Rafael J. Wysocki @ 2020-09-25 16:27 UTC (permalink / raw)
To: Hanjun Guo; +Cc: ACPI Devel Maling List, Rafael J. Wysocki
On Thu, Sep 24, 2020 at 5:12 AM Hanjun Guo <guohanjun@huawei.com> wrote:
>
> With the evolution of the ACPI driver code, lots of the ACPICA debug
> functions such as ACPI_DEBUG_PRINT() used in ACPI drivers were removed
> away, this makes some of the ACPICA debug code in ACPI driver as dead,
> for example, _COMPONENT and ACPI_MODULE_NAME() are useless without
> ACPICA debug functions.
>
> This patch set will cleanup those dead code before decoupling ACPICA
> debug with ACPI driver, should be no functional change.
>
> v1->v2:
> - Remove patches that not for ACPICA debug cleanups, send them
> seperately, this patch set only contains cleanups for ACPICA debug
> functionality.
>
> Hanjun Guo (15):
> ACPI: cmos_rtc: Remove the leftover ACPICA code ACPI_MODULE_NAME()
> ACPI: LPSS: Remove the ACPI_MODULE_NAME()
> ACPI: memhotplug: Remove the leftover ACPICA debug functionality
> ACPI: platform: Remove the ACPI_MODULE_NAME()
> ACPI: container: Remove the leftover ACPICA debug functionality
> ACPI: custom_method: Remove the dead ACPICA debug code
> ACPI: debugfs: Remove the dead ACPICA debug code
> ACPI: dock: Remove the dead ACPICA debug code
> ACPI: event: Remove the leftover ACPICA debug code
> ACPI: PCI: Remove the unused ACPICA debug code
> ACPI: proc: Remove the dead ACPICA debug code
> ACPI: processor: Remove the dead ACPICA debug code
> ACPI: tiny-power-button: Remove the dead ACPICA debug code
> ACPI: video: Remove the leftover ACPICA debug code
> ACPI: wakeup: Remove the dead ACPICA debug code
All applied as 5.10 material with minor subject and changelog edits, thanks!
^ permalink raw reply [flat|nested] 17+ messages in thread