* [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant
@ 2019-07-17 10:55 Andy Shevchenko
2019-07-25 12:44 ` James Morse
2019-08-26 9:04 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-07-17 10:55 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, linux-acpi, James Morse, Tony Luck,
Borislav Petkov
Cc: Andy Shevchenko, Borislav Petkov, Christoph Hellwig
This is a missed part of the commit 5b53696a30d5
("ACPI / APEI: Switch to use new generic UUID API"), i.e.
replacing old definition with a global constant variable.
Cc: Borislav Petkov <bp@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/acpi/apei/ghes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index a66e00fe31fe..451269a2f47c 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes,
int sev, sec_sev;
struct acpi_hest_generic_data *gdata;
guid_t *sec_type;
- guid_t *fru_id = &NULL_UUID_LE;
+ const guid_t *fru_id = &guid_null;
char *fru_text = "";
sev = ghes_severity(estatus->error_severity);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant
2019-07-17 10:55 [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant Andy Shevchenko
@ 2019-07-25 12:44 ` James Morse
2019-08-26 9:04 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: James Morse @ 2019-07-25 12:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Rafael J. Wysocki, Len Brown, linux-acpi, Tony Luck,
Borislav Petkov, Borislav Petkov, Christoph Hellwig
Hi,
On 17/07/2019 11:55, Andy Shevchenko wrote:
> This is a missed part of the commit 5b53696a30d5
> ("ACPI / APEI: Switch to use new generic UUID API"), i.e.
> replacing old definition with a global constant variable.
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant
2019-07-17 10:55 [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant Andy Shevchenko
2019-07-25 12:44 ` James Morse
@ 2019-08-26 9:04 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2019-08-26 9:04 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Len Brown, linux-acpi, James Morse, Tony Luck, Borislav Petkov,
Borislav Petkov, Christoph Hellwig
On Wednesday, July 17, 2019 12:55:43 PM CEST Andy Shevchenko wrote:
> This is a missed part of the commit 5b53696a30d5
> ("ACPI / APEI: Switch to use new generic UUID API"), i.e.
> replacing old definition with a global constant variable.
>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index a66e00fe31fe..451269a2f47c 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes,
> int sev, sec_sev;
> struct acpi_hest_generic_data *gdata;
> guid_t *sec_type;
> - guid_t *fru_id = &NULL_UUID_LE;
> + const guid_t *fru_id = &guid_null;
> char *fru_text = "";
>
> sev = ghes_severity(estatus->error_severity);
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-26 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 10:55 [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant Andy Shevchenko
2019-07-25 12:44 ` James Morse
2019-08-26 9:04 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).