From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 2/2] gpio: sch: Add interrupt support
Date: Wed, 24 Apr 2019 11:18:02 +0300 [thread overview]
Message-ID: <20190424081802.GV2654@lahna.fi.intel.com> (raw)
In-Reply-To: <8999d3f8-d169-eb85-bd2f-08c99d184ea2@siemens.com>
On Wed, Apr 24, 2019 at 10:12:42AM +0200, Jan Kiszka wrote:
> On 24.04.19 09:58, Mika Westerberg wrote:
> > +Rafael and linux-acpi.
> >
> > On Thu, Apr 18, 2019 at 11:23:49AM +0200, Jan Kiszka wrote:
> > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > >
> > > Validated on the Quark platform, this adds interrupt support on rising
> > > and/or falling edges.
> >
> > The irqchip parts look good to me but but the ACPI SCI handling seems
> > weird. This is typically handled by ACPI core based on the values read
> > from FADT ACPI table. What does it contain on this Quark platform?
>
> There is no FADT on the original Quark firmware, nor did we add one. As we
> are talking about existing devices, possibly not only Quarks, I was going
> down the ACPI-independent way to hook into the interrupt. But I'm open to
> learn about better alternatives.
Hmm, if it does not have FADT table why would you need SCI then? Is this
implementing some real use case?
next prev parent reply other threads:[~2019-04-24 8:18 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1555579429.git.jan.kiszka@siemens.com>
[not found] ` <c9f40465c6effc7b8efd6cbf8461d71d80c80033.1555579429.git.jan.kiszka@siemens.com>
2019-04-24 7:58 ` [PATCH 2/2] gpio: sch: Add interrupt support Mika Westerberg
2019-04-24 7:58 ` Mika Westerberg
2019-04-24 8:12 ` Jan Kiszka
2019-04-24 8:12 ` Jan Kiszka
2019-04-24 8:18 ` Mika Westerberg [this message]
2019-04-24 8:18 ` Mika Westerberg
2019-04-24 8:25 ` Jan Kiszka
2019-04-24 8:25 ` Jan Kiszka
2019-04-24 8:42 ` Mika Westerberg
2019-04-24 8:42 ` Mika Westerberg
2019-04-24 9:36 ` Jan Kiszka
2019-04-24 9:36 ` Jan Kiszka
2019-04-24 9:45 ` Mika Westerberg
2019-04-24 9:45 ` Mika Westerberg
2019-04-24 9:48 ` Jan Kiszka
2019-04-24 9:48 ` Jan Kiszka
2019-04-24 10:01 ` Mika Westerberg
2019-04-24 10:01 ` Mika Westerberg
2019-04-24 10:19 ` Jan Kiszka
2019-04-24 10:19 ` Jan Kiszka
2019-04-24 10:33 ` Mika Westerberg
2019-04-24 10:33 ` Mika Westerberg
2019-04-24 10:39 ` Jan Kiszka
2019-04-24 10:39 ` Jan Kiszka
2019-04-24 10:46 ` Mika Westerberg
2019-04-24 10:46 ` Mika Westerberg
2019-04-24 12:41 ` Jan Kiszka
2019-04-24 12:41 ` Jan Kiszka
2019-04-24 13:13 ` Mika Westerberg
2019-04-24 13:13 ` Mika Westerberg
2019-04-24 14:24 ` Jan Kiszka
2019-04-24 14:24 ` Jan Kiszka
2019-04-24 15:33 ` Mika Westerberg
2019-04-24 15:33 ` Mika Westerberg
2019-04-26 13:06 ` Andy Shevchenko
2019-04-26 13:06 ` Andy Shevchenko
2019-04-26 13:36 ` Jan Kiszka
2019-04-26 13:36 ` Jan Kiszka
2019-04-26 14:42 ` Enrico Weigelt, metux IT consult
2019-04-26 14:42 ` Enrico Weigelt, metux IT consult
2019-04-26 15:31 ` Manivannan Sadhasivam
2019-04-26 15:31 ` Manivannan Sadhasivam
2019-04-26 16:03 ` Jan Kiszka
2019-04-26 16:03 ` Jan Kiszka
2019-04-26 17:20 ` Andy Shevchenko
2019-04-26 17:20 ` Andy Shevchenko
2019-04-26 17:33 ` Manivannan Sadhasivam
2019-04-26 17:33 ` Manivannan Sadhasivam
2019-04-26 17:39 ` Jan Kiszka
2019-04-26 17:39 ` Jan Kiszka
2019-04-26 17:46 ` Manivannan Sadhasivam
2019-04-26 17:46 ` Manivannan Sadhasivam
2019-04-26 17:52 ` Jan Kiszka
2019-04-26 17:52 ` Jan Kiszka
2019-04-26 17:56 ` Manivannan Sadhasivam
2019-04-26 17:56 ` Manivannan Sadhasivam
2019-04-26 17:44 ` Andy Shevchenko
2019-04-26 17:44 ` Andy Shevchenko
2019-04-26 17:52 ` Manivannan Sadhasivam
2019-04-26 17:52 ` Manivannan Sadhasivam
2019-04-26 18:26 ` Andy Shevchenko
2019-04-26 18:26 ` Andy Shevchenko
2019-04-26 17:37 ` Jan Kiszka
2019-04-26 17:37 ` Jan Kiszka
2019-04-29 11:09 ` Enrico Weigelt, metux IT consult
2019-04-29 11:09 ` Enrico Weigelt, metux IT consult
2019-05-16 12:20 ` Linus Walleij
2019-04-26 14:41 ` Linus Walleij
2019-04-26 14:41 ` Linus Walleij
2019-04-26 15:44 ` Jan Kiszka
2019-04-26 15:44 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424081802.GV2654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).