From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Yehezkel Bernat <yehezkelshb@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Lukas Wunner <lukas@wunner.de>,
Mario Limonciello <Mario.Limonciello@dell.com>,
Anthony Wong <anthony.wong@canonical.com>,
linux-acpi@vger.kernel.org, raanan.avargil@intel.com
Subject: Re: [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake
Date: Fri, 5 Jul 2019 17:51:06 +0300 [thread overview]
Message-ID: <20190705145106.GA2640@lahna.fi.intel.com> (raw)
In-Reply-To: <CA+CmpXsak9Rvkq_RNzoxRecMercUPKqdK+KzbHv_fJC59inaHA@mail.gmail.com>
On Fri, Jul 05, 2019 at 05:44:01PM +0300, Yehezkel Bernat wrote:
> On Fri, Jul 5, 2019 at 12:58 PM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > +static void icm_icl_rtd3_veto(struct tb *tb, const struct icm_pkg_header *hdr)
> > +{
> > + const struct icm_icl_event_rtd3_veto *pkg =
> > + (const struct icm_icl_event_rtd3_veto *)hdr;
> > + struct icm *icm = tb_priv(tb);
> > +
> > + tb_dbg(tb, "ICM rtd3 veto=0x%08x\n", pkg->veto_reason);
> > +
> > + if (pkg->veto_reason) {
> > + if (!icm->veto) {
> > + icm->veto = true;
> > + /* Keep the domain powered while veto is in effect */
> > + pm_runtime_get(&tb->dev);
> > + }
> > + } else {
> > + if (icm->veto) {
> > + icm->veto = false;
> > + /* Allow the domain suspend now */
> > + pm_runtime_mark_last_busy(&tb->dev);
> > + pm_runtime_put_autosuspend(&tb->dev);
>
> Handling the removal of the veto is duplicated below. Worth introducing as a
> helper function?
>
> > + }
> > + }
> > +}
> > +
>
> ...
>
> > @@ -1853,6 +1943,18 @@ static void icm_complete(struct tb *tb)
> > if (tb->nhi->going_away)
> > return;
> >
> > + /*
> > + * If RTD3 was vetoed before we entered system suspend allow it
> > + * again now before driver ready is sent. Firmware sends a new RTD3
> > + * veto if it is still the case after we have sent it driver ready
> > + * command.
> > + */
> > + if (icm->veto) {
> > + icm->veto = false;
> > + pm_runtime_mark_last_busy(&tb->dev);
> > + pm_runtime_put_autosuspend(&tb->dev);
> > + }
> > +
>
> Here is the duplication.
Indeed, I'll put it to a helper function.
> > +static int nhi_suspend_power_down(struct tb *tb)
> > +{
> > + int ret;
> > +
> > + /*
> > + * If there is no device connected we need to perform an additional
> > + * handshake through LC mailbox and force power down before
> > + * entering D3.
> > + */
> > + ret = device_for_each_child(&tb->root_switch->dev, NULL,
> > + nhi_device_connected);
> > + if (!ret) {
> > + lc_mailbox_cmd(tb->nhi, LC_PREPARE_FOR_RESET);
> > + ret = lc_mailbox_cmd_complete(tb->nhi,
> > + LC_MAILBOX_TIMEOUT);
> > + if (ret)
> > + return ret;
> > +
> > + return nhi_power_down(tb->nhi);
>
> Just to be sure: unforce power is done only if no device is connected?
> My understanding of the comment above was that unforce power should be done
> anyway (so it should be outside of this if block), and the difference between
> the cases is only about the additional LC mailbox message. I guess I misread it.
nhi_power_down() should be only called if no device was connected so it
should be in correct place. I can try to clarify the comment a bit,
though.
next prev parent reply other threads:[~2019-07-05 14:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 9:57 [PATCH 0/8] thunderbolt: Intel Ice Lake support Mika Westerberg
2019-07-05 9:57 ` [PATCH 1/8] thunderbolt: Correct path indices for PCIe tunnel Mika Westerberg
2019-07-05 9:57 ` [PATCH 2/8] thunderbolt: Move NVM upgrade support flag to struct icm Mika Westerberg
2019-07-05 10:52 ` Yehezkel Bernat
2019-07-05 10:58 ` Mika Westerberg
2019-07-09 15:11 ` Mario.Limonciello
2019-08-05 13:15 ` Mika Westerberg
2019-07-05 9:57 ` [PATCH 3/8] thunderbolt: Use 32-bit writes when writing ring producer/consumer Mika Westerberg
2019-07-05 11:09 ` Yehezkel Bernat
2019-07-05 11:24 ` Mika Westerberg
2019-07-05 16:04 ` David Laight
2019-08-07 16:13 ` Mika Westerberg
2019-08-07 16:22 ` David Laight
2019-08-07 16:36 ` 'Mika Westerberg'
2019-08-07 16:41 ` David Laight
2019-08-08 9:57 ` 'Mika Westerberg'
2019-08-12 9:01 ` David Laight
2019-07-05 9:57 ` [PATCH 4/8] thunderbolt: Do not fail adding switch if some port is not implemented Mika Westerberg
2019-07-05 9:57 ` [PATCH 5/8] thunderbolt: Hide switch attributes that are not set Mika Westerberg
2019-07-05 9:57 ` [PATCH 6/8] thunderbolt: Expose active parts of NVM even if upgrade is not supported Mika Westerberg
2019-07-05 9:57 ` [PATCH 7/8] thunderbolt: Add support for Intel Ice Lake Mika Westerberg
2019-07-05 14:44 ` Yehezkel Bernat
2019-07-05 14:51 ` Mika Westerberg [this message]
2019-07-05 15:02 ` Yehezkel Bernat
2019-08-04 18:25 ` Lukas Wunner
2019-08-05 14:16 ` Mika Westerberg
2019-07-05 9:58 ` [PATCH 8/8] ACPI / property: Add two new Thunderbolt property GUIDs to the list Mika Westerberg
2019-07-09 8:18 ` Rafael J. Wysocki
2019-07-05 10:33 ` [PATCH 0/8] thunderbolt: Intel Ice Lake support Mika Westerberg
2019-07-05 14:56 ` Yehezkel Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705145106.GA2640@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=andreas.noever@gmail.com \
--cc=anthony.wong@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
--cc=raanan.avargil@intel.com \
--cc=rjw@rjwysocki.net \
--cc=yehezkelshb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).