* [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist
@ 2019-11-06 11:51 Hans de Goede
2019-11-06 14:01 ` Mika Westerberg
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hans de Goede @ 2019-11-06 11:51 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Bartosz Golaszewski, Linus Walleij
Cc: Hans de Goede, linux-gpio, linux-acpi
The Terra Pad 1061 has the usual micro-USB-B id-pin handler, but instead
of controlling the actual micro-USB-B it turns the 5V boost for the
tablet's USB-A connector and its keyboard-cover connector off.
The actual micro-USB-B connector on the tablet is wired for charging only,
and its id pin is *not* connected to the GPIO which is used for the
(broken) id-pin event handler in the DSDT.
While at it not only add a comment why the Terra Pad 1061 is on the
blacklist, but also fix the missing comment for the Minix Neo Z83-4 entry.
Fixes: 61f7f7c8f978 ("gpiolib: acpi: Add gpiolib_acpi_run_edge_events_on_boot option and blacklist")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/gpio/gpiolib-acpi.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 2911dd6f2625..5372652c38eb 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -1307,11 +1307,28 @@ late_initcall_sync(acpi_gpio_handle_deferred_request_irqs);
static const struct dmi_system_id run_edge_events_on_boot_blacklist[] = {
{
+ /*
+ * The Minix Neo Z83-4 has a micro-USB-B id-pin handler for
+ * a non existing micro-USB-B connector which puts the HDMI
+ * DDC pins in GPIO mode, breaking HDMI support.
+ */
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "MINIX"),
DMI_MATCH(DMI_PRODUCT_NAME, "Z83-4"),
}
},
+ {
+ /*
+ * The Terra Pad 1061 has a micro-USB-B id-pin handler, which
+ * instead of controlling the actual micro-USB-B turns the 5V
+ * boost for its USB-A connector off. The actual micro-USB-B
+ * connector is wired for charging only.
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Wortmann_AG"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "TERRA_PAD_1061"),
+ }
+ },
{} /* Terminating entry */
};
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist
2019-11-06 11:51 [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist Hans de Goede
@ 2019-11-06 14:01 ` Mika Westerberg
2019-11-06 14:26 ` Andy Shevchenko
2019-11-13 9:47 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2019-11-06 14:01 UTC (permalink / raw)
To: Hans de Goede
Cc: Andy Shevchenko, Bartosz Golaszewski, Linus Walleij, linux-gpio,
linux-acpi
On Wed, Nov 06, 2019 at 12:51:09PM +0100, Hans de Goede wrote:
> The Terra Pad 1061 has the usual micro-USB-B id-pin handler, but instead
> of controlling the actual micro-USB-B it turns the 5V boost for the
> tablet's USB-A connector and its keyboard-cover connector off.
>
> The actual micro-USB-B connector on the tablet is wired for charging only,
> and its id pin is *not* connected to the GPIO which is used for the
> (broken) id-pin event handler in the DSDT.
>
> While at it not only add a comment why the Terra Pad 1061 is on the
> blacklist, but also fix the missing comment for the Minix Neo Z83-4 entry.
>
> Fixes: 61f7f7c8f978 ("gpiolib: acpi: Add gpiolib_acpi_run_edge_events_on_boot option and blacklist")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist
2019-11-06 11:51 [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist Hans de Goede
2019-11-06 14:01 ` Mika Westerberg
@ 2019-11-06 14:26 ` Andy Shevchenko
2019-11-13 9:47 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2019-11-06 14:26 UTC (permalink / raw)
To: Hans de Goede
Cc: Mika Westerberg, Bartosz Golaszewski, Linus Walleij, linux-gpio,
linux-acpi
On Wed, Nov 06, 2019 at 12:51:09PM +0100, Hans de Goede wrote:
> The Terra Pad 1061 has the usual micro-USB-B id-pin handler, but instead
> of controlling the actual micro-USB-B it turns the 5V boost for the
> tablet's USB-A connector and its keyboard-cover connector off.
>
> The actual micro-USB-B connector on the tablet is wired for charging only,
> and its id pin is *not* connected to the GPIO which is used for the
> (broken) id-pin event handler in the DSDT.
>
> While at it not only add a comment why the Terra Pad 1061 is on the
> blacklist, but also fix the missing comment for the Minix Neo Z83-4 entry.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
>
> Fixes: 61f7f7c8f978 ("gpiolib: acpi: Add gpiolib_acpi_run_edge_events_on_boot option and blacklist")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 2911dd6f2625..5372652c38eb 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -1307,11 +1307,28 @@ late_initcall_sync(acpi_gpio_handle_deferred_request_irqs);
>
> static const struct dmi_system_id run_edge_events_on_boot_blacklist[] = {
> {
> + /*
> + * The Minix Neo Z83-4 has a micro-USB-B id-pin handler for
> + * a non existing micro-USB-B connector which puts the HDMI
> + * DDC pins in GPIO mode, breaking HDMI support.
> + */
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "MINIX"),
> DMI_MATCH(DMI_PRODUCT_NAME, "Z83-4"),
> }
> },
> + {
> + /*
> + * The Terra Pad 1061 has a micro-USB-B id-pin handler, which
> + * instead of controlling the actual micro-USB-B turns the 5V
> + * boost for its USB-A connector off. The actual micro-USB-B
> + * connector is wired for charging only.
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Wortmann_AG"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TERRA_PAD_1061"),
> + }
> + },
> {} /* Terminating entry */
> };
>
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist
2019-11-06 11:51 [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist Hans de Goede
2019-11-06 14:01 ` Mika Westerberg
2019-11-06 14:26 ` Andy Shevchenko
@ 2019-11-13 9:47 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2019-11-13 9:47 UTC (permalink / raw)
To: Hans de Goede
Cc: Mika Westerberg, Andy Shevchenko, Bartosz Golaszewski,
open list:GPIO SUBSYSTEM, ACPI Devel Maling List
On Wed, Nov 6, 2019 at 12:51 PM Hans de Goede <hdegoede@redhat.com> wrote:
> The Terra Pad 1061 has the usual micro-USB-B id-pin handler, but instead
> of controlling the actual micro-USB-B it turns the 5V boost for the
> tablet's USB-A connector and its keyboard-cover connector off.
>
> The actual micro-USB-B connector on the tablet is wired for charging only,
> and its id pin is *not* connected to the GPIO which is used for the
> (broken) id-pin event handler in the DSDT.
>
> While at it not only add a comment why the Terra Pad 1061 is on the
> blacklist, but also fix the missing comment for the Minix Neo Z83-4 entry.
>
> Fixes: 61f7f7c8f978 ("gpiolib: acpi: Add gpiolib_acpi_run_edge_events_on_boot option and blacklist")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-13 9:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-06 11:51 [PATCH] gpiolib: acpi: Add Terra Pad 1061 to the run_edge_events_on_boot_blacklist Hans de Goede
2019-11-06 14:01 ` Mika Westerberg
2019-11-06 14:26 ` Andy Shevchenko
2019-11-13 9:47 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).