From: LABBE Corentin <clabbe@baylibre.com>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/2] PNP: constify driver name
Date: Wed, 18 Mar 2020 10:21:18 +0100 [thread overview]
Message-ID: <20200318092118.GA24828@Red> (raw)
In-Reply-To: <a76a7dc9-4e5d-bb5b-b70c-cf6762b73f7d@intel.com>
On Tue, Mar 17, 2020 at 06:46:24PM +0100, Rafael J. Wysocki wrote:
> On 3/6/2020 8:53 AM, Corentin Labbe wrote:
> > struct pnp_driver has name set as char* instead of const char* like platform_driver, pci_driver, usb_driver, etc...
> > Let's unify a bit by setting name as const char*.
> > Furthermore, all users of this structures set name from already const
> > data.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > include/linux/pnp.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> > index 3b12fd28af78..b18dca67253d 100644
> > --- a/include/linux/pnp.h
> > +++ b/include/linux/pnp.h
> > @@ -379,7 +379,7 @@ struct pnp_id {
> > };
> >
> > struct pnp_driver {
> > - char *name;
> > + const char *name;
> > const struct pnp_device_id *id_table;
> > unsigned int flags;
> > int (*probe) (struct pnp_dev *dev, const struct pnp_device_id *dev_id);
>
> Applied as 5.7 material along with the [2/2].
>
> BTW, please CC PNP patches to linux-acpi in the future.
>
Perhaps it is better to update MAINTAINERS ?
I will send a patch for it.
prev parent reply other threads:[~2020-03-18 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1583481181-22972-1-git-send-email-clabbe@baylibre.com>
2020-03-17 17:46 ` [PATCH 1/2] PNP: constify driver name Rafael J. Wysocki
2020-03-18 9:21 ` LABBE Corentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318092118.GA24828@Red \
--to=clabbe@baylibre.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).