Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
       [not found] <20200701062140.12953-1-laurent.pinchart+renesas@ideasonboard.com>
@ 2020-07-01  6:21 ` Laurent Pinchart
  2020-07-01  7:34   ` Sakari Ailus
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2020-07-01  6:21 UTC (permalink / raw)
  To: linux-media
  Cc: linux-renesas-soc, Sakari Ailus, Jacopo Mondi,
	Niklas Söderlund, Kieran Bingham, Lad Prabhakar,
	Rafael J. Wysocki

Drivers may need to test if a fwnode is a graph endpoint. To avoid
hand-written solutions that wouldn't work for all fwnode types, add a
new fwnode_graph_is_endpoint() function for this purpose. We don't need
to wire it up to different backends for OF and ACPI for now, as the
implementation can simply be based on checkout the presence of a
remote-endpoint property.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 include/linux/property.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/property.h b/include/linux/property.h
index 10d03572f52e..9f805c442819 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -389,6 +389,11 @@ struct fwnode_handle *
 fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
 			     u32 endpoint);
 
+static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
+{
+	return fwnode_property_present(fwnode, "remote-endpoint");
+}
+
 /*
  * Fwnode lookup flags
  *
-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
  2020-07-01  6:21 ` [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint Laurent Pinchart
@ 2020-07-01  7:34   ` Sakari Ailus
  2020-07-01 12:19     ` Rafael J. Wysocki
  0 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2020-07-01  7:34 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: linux-media, linux-renesas-soc, Jacopo Mondi,
	Niklas Söderlund, Kieran Bingham, Lad Prabhakar,
	Rafael J. Wysocki, devicetree, linux-acpi

Hi Laurent,

On Wed, Jul 01, 2020 at 09:21:37AM +0300, Laurent Pinchart wrote:
> Drivers may need to test if a fwnode is a graph endpoint. To avoid
> hand-written solutions that wouldn't work for all fwnode types, add a
> new fwnode_graph_is_endpoint() function for this purpose. We don't need
> to wire it up to different backends for OF and ACPI for now, as the
> implementation can simply be based on checkout the presence of a
> remote-endpoint property.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  include/linux/property.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 10d03572f52e..9f805c442819 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -389,6 +389,11 @@ struct fwnode_handle *
>  fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
>  			     u32 endpoint);
>  
> +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> +{
> +	return fwnode_property_present(fwnode, "remote-endpoint");
> +}
> +
>  /*
>   * Fwnode lookup flags
>   *

Thanks for the patch. I've bounced it to devicetree and linux-acpi lists
(now cc'd) --- hope that works.

Rafael: do you think this simple patch could go though the media tree,
assuming that folks are generally fine with the patch as such?
Alternatively,

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Kind regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
  2020-07-01  7:34   ` Sakari Ailus
@ 2020-07-01 12:19     ` Rafael J. Wysocki
  2020-07-15 20:57       ` Sakari Ailus
  0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2020-07-01 12:19 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Laurent Pinchart, linux-media, Linux-Renesas, Jacopo Mondi,
	Niklas Söderlund, Kieran Bingham, Lad Prabhakar,
	Rafael J. Wysocki, devicetree, ACPI Devel Maling List

On Wed, Jul 1, 2020 at 9:34 AM Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
> Hi Laurent,
>
> On Wed, Jul 01, 2020 at 09:21:37AM +0300, Laurent Pinchart wrote:
> > Drivers may need to test if a fwnode is a graph endpoint. To avoid
> > hand-written solutions that wouldn't work for all fwnode types, add a
> > new fwnode_graph_is_endpoint() function for this purpose. We don't need
> > to wire it up to different backends for OF and ACPI for now, as the
> > implementation can simply be based on checkout the presence of a
> > remote-endpoint property.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >  include/linux/property.h | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/include/linux/property.h b/include/linux/property.h
> > index 10d03572f52e..9f805c442819 100644
> > --- a/include/linux/property.h
> > +++ b/include/linux/property.h
> > @@ -389,6 +389,11 @@ struct fwnode_handle *
> >  fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
> >                            u32 endpoint);
> >
> > +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> > +{
> > +     return fwnode_property_present(fwnode, "remote-endpoint");
> > +}
> > +
> >  /*
> >   * Fwnode lookup flags
> >   *
>
> Thanks for the patch. I've bounced it to devicetree and linux-acpi lists
> (now cc'd) --- hope that works.
>
> Rafael: do you think this simple patch could go though the media tree,
> assuming that folks are generally fine with the patch as such?

Yes, it could.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
  2020-07-01 12:19     ` Rafael J. Wysocki
@ 2020-07-15 20:57       ` Sakari Ailus
  2020-07-17  2:19         ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2020-07-15 20:57 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Laurent Pinchart, linux-media, Linux-Renesas, Jacopo Mondi,
	Niklas Söderlund, Kieran Bingham, Lad Prabhakar,
	Rafael J. Wysocki, devicetree, ACPI Devel Maling List

Rafael,

On Wed, Jul 01, 2020 at 02:19:21PM +0200, Rafael J. Wysocki wrote:
> On Wed, Jul 1, 2020 at 9:34 AM Sakari Ailus <sakari.ailus@iki.fi> wrote:
> >
> > Hi Laurent,
> >
> > On Wed, Jul 01, 2020 at 09:21:37AM +0300, Laurent Pinchart wrote:
> > > Drivers may need to test if a fwnode is a graph endpoint. To avoid
> > > hand-written solutions that wouldn't work for all fwnode types, add a
> > > new fwnode_graph_is_endpoint() function for this purpose. We don't need
> > > to wire it up to different backends for OF and ACPI for now, as the
> > > implementation can simply be based on checkout the presence of a
> > > remote-endpoint property.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > >  include/linux/property.h | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/include/linux/property.h b/include/linux/property.h
> > > index 10d03572f52e..9f805c442819 100644
> > > --- a/include/linux/property.h
> > > +++ b/include/linux/property.h
> > > @@ -389,6 +389,11 @@ struct fwnode_handle *
> > >  fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
> > >                            u32 endpoint);
> > >
> > > +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> > > +{
> > > +     return fwnode_property_present(fwnode, "remote-endpoint");
> > > +}
> > > +
> > >  /*
> > >   * Fwnode lookup flags
> > >   *
> >
> > Thanks for the patch. I've bounced it to devicetree and linux-acpi lists
> > (now cc'd) --- hope that works.
> >
> > Rafael: do you think this simple patch could go though the media tree,
> > assuming that folks are generally fine with the patch as such?
> 
> Yes, it could.

Thanks! I've applied this to my tree.

-- 
Kind regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
  2020-07-15 20:57       ` Sakari Ailus
@ 2020-07-17  2:19         ` Laurent Pinchart
  2020-07-17  7:56           ` Sakari Ailus
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2020-07-17  2:19 UTC (permalink / raw)
  To: Sakari Ailus
  Cc: Rafael J. Wysocki, Laurent Pinchart, linux-media, Linux-Renesas,
	Jacopo Mondi, Niklas Söderlund, Kieran Bingham,
	Lad Prabhakar, Rafael J. Wysocki, devicetree,
	ACPI Devel Maling List

Hi Sakari,

On Wed, Jul 15, 2020 at 11:57:17PM +0300, Sakari Ailus wrote:
> On Wed, Jul 01, 2020 at 02:19:21PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Jul 1, 2020 at 9:34 AM Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > > On Wed, Jul 01, 2020 at 09:21:37AM +0300, Laurent Pinchart wrote:
> > > > Drivers may need to test if a fwnode is a graph endpoint. To avoid
> > > > hand-written solutions that wouldn't work for all fwnode types, add a
> > > > new fwnode_graph_is_endpoint() function for this purpose. We don't need
> > > > to wire it up to different backends for OF and ACPI for now, as the
> > > > implementation can simply be based on checkout the presence of a
> > > > remote-endpoint property.
> > > >
> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > > ---
> > > >  include/linux/property.h | 5 +++++
> > > >  1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/include/linux/property.h b/include/linux/property.h
> > > > index 10d03572f52e..9f805c442819 100644
> > > > --- a/include/linux/property.h
> > > > +++ b/include/linux/property.h
> > > > @@ -389,6 +389,11 @@ struct fwnode_handle *
> > > >  fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
> > > >                            u32 endpoint);
> > > >
> > > > +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> > > > +{
> > > > +     return fwnode_property_present(fwnode, "remote-endpoint");
> > > > +}
> > > > +
> > > >  /*
> > > >   * Fwnode lookup flags
> > > >   *
> > >
> > > Thanks for the patch. I've bounced it to devicetree and linux-acpi lists
> > > (now cc'd) --- hope that works.
> > >
> > > Rafael: do you think this simple patch could go though the media tree,
> > > assuming that folks are generally fine with the patch as such?
> > 
> > Yes, it could.
> 
> Thanks! I've applied this to my tree.

Do you mean the whole series ? :-) Do you intend to send a pull request
for v5.9 ?

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint
  2020-07-17  2:19         ` Laurent Pinchart
@ 2020-07-17  7:56           ` Sakari Ailus
  0 siblings, 0 replies; 6+ messages in thread
From: Sakari Ailus @ 2020-07-17  7:56 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Rafael J. Wysocki, Laurent Pinchart, linux-media, Linux-Renesas,
	Jacopo Mondi, Niklas Söderlund, Kieran Bingham,
	Lad Prabhakar, Rafael J. Wysocki, devicetree,
	ACPI Devel Maling List

On Fri, Jul 17, 2020 at 05:19:16AM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> On Wed, Jul 15, 2020 at 11:57:17PM +0300, Sakari Ailus wrote:
> > On Wed, Jul 01, 2020 at 02:19:21PM +0200, Rafael J. Wysocki wrote:
> > > On Wed, Jul 1, 2020 at 9:34 AM Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > > > On Wed, Jul 01, 2020 at 09:21:37AM +0300, Laurent Pinchart wrote:
> > > > > Drivers may need to test if a fwnode is a graph endpoint. To avoid
> > > > > hand-written solutions that wouldn't work for all fwnode types, add a
> > > > > new fwnode_graph_is_endpoint() function for this purpose. We don't need
> > > > > to wire it up to different backends for OF and ACPI for now, as the
> > > > > implementation can simply be based on checkout the presence of a
> > > > > remote-endpoint property.
> > > > >
> > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > > > ---
> > > > >  include/linux/property.h | 5 +++++
> > > > >  1 file changed, 5 insertions(+)
> > > > >
> > > > > diff --git a/include/linux/property.h b/include/linux/property.h
> > > > > index 10d03572f52e..9f805c442819 100644
> > > > > --- a/include/linux/property.h
> > > > > +++ b/include/linux/property.h
> > > > > @@ -389,6 +389,11 @@ struct fwnode_handle *
> > > > >  fwnode_graph_get_remote_node(const struct fwnode_handle *fwnode, u32 port,
> > > > >                            u32 endpoint);
> > > > >
> > > > > +static inline bool fwnode_graph_is_endpoint(struct fwnode_handle *fwnode)
> > > > > +{
> > > > > +     return fwnode_property_present(fwnode, "remote-endpoint");
> > > > > +}
> > > > > +
> > > > >  /*
> > > > >   * Fwnode lookup flags
> > > > >   *
> > > >
> > > > Thanks for the patch. I've bounced it to devicetree and linux-acpi lists
> > > > (now cc'd) --- hope that works.
> > > >
> > > > Rafael: do you think this simple patch could go though the media tree,
> > > > assuming that folks are generally fine with the patch as such?
> > > 
> > > Yes, it could.
> > 
> > Thanks! I've applied this to my tree.
> 
> Do you mean the whole series ? :-) Do you intend to send a pull request
> for v5.9 ?

It's here:

<URL:https://patchwork.linuxtv.org/project/linux-media/patch/20200715222030.GG836@valkosipuli.retiisi.org.uk/>

-- 
Sakari Ailus

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200701062140.12953-1-laurent.pinchart+renesas@ideasonboard.com>
2020-07-01  6:21 ` [PATCH v4 1/4] device property: Add a function to test is a fwnode is a graph endpoint Laurent Pinchart
2020-07-01  7:34   ` Sakari Ailus
2020-07-01 12:19     ` Rafael J. Wysocki
2020-07-15 20:57       ` Sakari Ailus
2020-07-17  2:19         ` Laurent Pinchart
2020-07-17  7:56           ` Sakari Ailus

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git