Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] i2c: designware: Add device HID for Hygon I2C controller
@ 2020-07-31  8:48 Pu Wen
  2020-07-31  9:27 ` Andy Shevchenko
  2020-07-31 13:49 ` Wolfram Sang
  0 siblings, 2 replies; 3+ messages in thread
From: Pu Wen @ 2020-07-31  8:48 UTC (permalink / raw)
  To: rjw, lenb, jarkko.nikula, andriy.shevchenko, mika.westerberg
  Cc: linux-kernel, linux-acpi, linux-i2c, Pu Wen

Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
was registered in http://www.uefi.org/acpi_id_list, and the I2C
controller on Hygon paltform will use the HID.

Signed-off-by: Pu Wen <puwen@hygon.cn>
---
 drivers/acpi/acpi_apd.c                     | 1 +
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
index ba2612e9a0eb..f24f6d3f1fa5 100644
--- a/drivers/acpi/acpi_apd.c
+++ b/drivers/acpi/acpi_apd.c
@@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
 	{ "AMD0030", },
 	{ "AMD0040", APD_ADDR(st_misc_desc)},
+	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
 #endif
 #ifdef CONFIG_ARM64
 	{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index a71bc58fc03c..0dfeb2d11603 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "HISI02A1", 0 },
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
+	{ "HYGO0010", ACCESS_INTR_MASK },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
-- 
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: designware: Add device HID for Hygon I2C controller
  2020-07-31  8:48 [PATCH] i2c: designware: Add device HID for Hygon I2C controller Pu Wen
@ 2020-07-31  9:27 ` Andy Shevchenko
  2020-07-31 13:49 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-07-31  9:27 UTC (permalink / raw)
  To: Pu Wen
  Cc: rjw, lenb, jarkko.nikula, mika.westerberg, linux-kernel,
	linux-acpi, linux-i2c

On Fri, Jul 31, 2020 at 04:48:45PM +0800, Pu Wen wrote:
> Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
> was registered in http://www.uefi.org/acpi_id_list, and the I2C
> controller on Hygon paltform will use the HID.

Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Pu Wen <puwen@hygon.cn>
> ---
>  drivers/acpi/acpi_apd.c                     | 1 +
>  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index ba2612e9a0eb..f24f6d3f1fa5 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>  	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
>  	{ "AMD0030", },
>  	{ "AMD0040", APD_ADDR(st_misc_desc)},
> +	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
>  #endif
>  #ifdef CONFIG_ARM64
>  	{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index a71bc58fc03c..0dfeb2d11603 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>  	{ "HISI02A1", 0 },
>  	{ "HISI02A2", 0 },
>  	{ "HISI02A3", 0 },
> +	{ "HYGO0010", ACCESS_INTR_MASK },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> -- 
> 2.23.0
> 

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i2c: designware: Add device HID for Hygon I2C controller
  2020-07-31  8:48 [PATCH] i2c: designware: Add device HID for Hygon I2C controller Pu Wen
  2020-07-31  9:27 ` Andy Shevchenko
@ 2020-07-31 13:49 ` Wolfram Sang
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2020-07-31 13:49 UTC (permalink / raw)
  To: Pu Wen
  Cc: rjw, lenb, jarkko.nikula, andriy.shevchenko, mika.westerberg,
	linux-kernel, linux-acpi, linux-i2c


[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Fri, Jul 31, 2020 at 04:48:45PM +0800, Pu Wen wrote:
> Add device HID HYGO0010 to match the Hygon ACPI Vendor ID (HYGO) that
> was registered in http://www.uefi.org/acpi_id_list, and the I2C
> controller on Hygon paltform will use the HID.
> 
> Signed-off-by: Pu Wen <puwen@hygon.cn>

I can take this via I2C, but I'd need an ack from Rafael or Len.

Or it can go via ACPI, fine with me

Acked-by: Wolfram Sang <wsa@kernel.org>

> ---
>  drivers/acpi/acpi_apd.c                     | 1 +
>  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> index ba2612e9a0eb..f24f6d3f1fa5 100644
> --- a/drivers/acpi/acpi_apd.c
> +++ b/drivers/acpi/acpi_apd.c
> @@ -240,6 +240,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
>  	{ "AMDI0020", APD_ADDR(cz_uart_desc) },
>  	{ "AMD0030", },
>  	{ "AMD0040", APD_ADDR(st_misc_desc)},
> +	{ "HYGO0010", APD_ADDR(wt_i2c_desc) },
>  #endif
>  #ifdef CONFIG_ARM64
>  	{ "APMC0D0F", APD_ADDR(xgene_i2c_desc) },
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index a71bc58fc03c..0dfeb2d11603 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -55,6 +55,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>  	{ "HISI02A1", 0 },
>  	{ "HISI02A2", 0 },
>  	{ "HISI02A3", 0 },
> +	{ "HYGO0010", ACCESS_INTR_MASK },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
> -- 
> 2.23.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31  8:48 [PATCH] i2c: designware: Add device HID for Hygon I2C controller Pu Wen
2020-07-31  9:27 ` Andy Shevchenko
2020-07-31 13:49 ` Wolfram Sang

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git