Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-acpi@vger.kernel.org, Bingbu Cao <bingbu.cao@intel.com>,
	linux-media@vger.kernel.org,
	Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
	Hyungwoo Yang <hyungwoo.yang@intel.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	rajmohan.mani@intel.com, Tomasz Figa <tfiga@chromium.org>,
	"Qiu, Tian Shu" <tian.shu.qiu@intel.com>
Subject: Re: [PATCH v6 1/6] i2c: Allow an ACPI driver to manage the device's power state during probe
Date: Fri, 28 Aug 2020 10:38:32 +0200
Message-ID: <20200828083832.GE1343@ninjato> (raw)
In-Reply-To: <20200826115432.6103-2-sakari.ailus@linux.intel.com>


[-- Attachment #1: Type: text/plain, Size: 3346 bytes --]

Hi Sakari,

On Wed, Aug 26, 2020 at 02:54:27PM +0300, Sakari Ailus wrote:
> Enable drivers to tell ACPI that there's no need to power on a device for
> probe. Drivers should still perform this by themselves if there's a need
> to. In some cases powering on the device during probe is undesirable, and
> this change enables a driver to choose what fits best for it.
> 
> Add a field called "flags" into struct i2c_driver for driver flags, and a
> flag I2C_DRV_FL_ALLOW_LOW_POWER_PROBE to tell a driver supports probe in
> low power state.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/i2c/i2c-core-base.c | 18 +++++++++++++++---
>  include/linux/i2c.h         | 14 ++++++++++++++
>  2 files changed, 29 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 34a9609f256da..f2683790eb0d2 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -436,6 +436,15 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
>  	return irq > 0 ? irq : -ENXIO;
>  }
>  
> +static bool allow_low_power_probe(struct device *dev)
> +{
> +	struct i2c_driver *driver = to_i2c_driver(dev->driver);
> +
> +	return driver->flags & I2C_DRV_FL_ALLOW_LOW_POWER_PROBE &&
> +		is_acpi_node(dev_fwnode(dev)) &&
> +		device_property_present(dev, "allow-low-power-probe");

So, I wondered about potential DT usage and I read the discussion about
that in v5 which concluded that for the DT case, the drivers can make
use of the binding individually. I can agree to that, but then the name
of the binding is probably problematic. 'allow-*' sounds like
configuration but DT is for describing HW. So, I think something in the
range of 'keep-low-power' or so might be better suited. Grepping shows
there already is a generic binding "low-power-enable". Not sure, if it
really fits, because here it is more about 'keeping' rather than
enabling. Or?

> +/**
> + * enum i2c_driver_flags - Flags for an I2C device driver
> + *
> + * @I2C_DRV_FL_ALLOW_LOW_POWER_PROBE: Let the ACPI driver manage the device's
> + *				      power state during probe and remove
> + */
> +enum i2c_driver_flags {
> +	I2C_DRV_FL_ALLOW_LOW_POWER_PROBE = BIT(0),
> +};
> +
>  /**
>   * struct i2c_driver - represent an I2C device driver
>   * @class: What kind of i2c device we instantiate (for detect)
> @@ -231,6 +242,7 @@ enum i2c_alert_protocol {
>   * @detect: Callback for device detection
>   * @address_list: The I2C addresses to probe (for detect)
>   * @clients: List of detected clients we created (for i2c-core use only)
> + * @flags: A bitmask of flags defined in &enum i2c_driver_flags
>   *
>   * The driver.owner field should be set to the module owner of this driver.
>   * The driver.name field should be set to the name of this driver.
> @@ -289,6 +301,8 @@ struct i2c_driver {
>  	int (*detect)(struct i2c_client *client, struct i2c_board_info *info);
>  	const unsigned short *address_list;
>  	struct list_head clients;
> +
> +	unsigned int flags;

Here I wonder if all this is really I2C specific? I could imagine this
being useful for other busses as well, so maybe 'struct device_driver'
is a better place?

Thanks for this work!

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 11:54 [PATCH v6 0/6] Support running driver's probe for a device powered off Sakari Ailus
2020-08-26 11:54 ` [PATCH v6 1/6] i2c: Allow an ACPI driver to manage the device's power state during probe Sakari Ailus
2020-08-28  8:38   ` Wolfram Sang [this message]
2020-08-31  8:23     ` Sakari Ailus
2020-08-31  9:31       ` Wolfram Sang
2020-08-31  9:54         ` Sakari Ailus
2020-08-31 10:00   ` Wolfram Sang
2020-08-31 17:05     ` Sakari Ailus
2020-08-26 11:54 ` [PATCH v6 2/6] ACPI: Add a convenience function to tell a device is in low power state Sakari Ailus
2020-08-26 11:54 ` [PATCH v6 3/6] ov5670: Support probe whilst the device is in a " Sakari Ailus
2020-08-26 11:54 ` [PATCH v6 4/6] media: i2c: imx319: Support probe while the device is off Sakari Ailus
2020-08-26 11:54 ` [PATCH v6 5/6] at24: Support probing while off Sakari Ailus
2020-08-26 11:54 ` [PATCH v6 6/6] Documentation: ACPI: Document allow-low-power-probe _DSD property Sakari Ailus
2020-08-26 18:06   ` Randy Dunlap
2020-08-27 13:28     ` Sakari Ailus
2020-09-01 20:28       ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828083832.GE1343@ninjato \
    --to=wsa@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=bingbu.cao@intel.com \
    --cc=chiranjeevi.rapolu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hyungwoo.yang@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rajmohan.mani@intel.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tfiga@chromium.org \
    --cc=tian.shu.qiu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git