[PATCH][V2] ACPI: video: use ACPI backlight for HP 635 Notebook

[PATCH][V2] ACPI: video: use ACPI backlight for HP 635 Notebook

[Alex Hung]

Default backlight interface is AMD's radeon_bl0 which does not work on
this system. As a result, let's for ACPI backlight interface for this
system.

BugLink: https://bugs.launchpad.net/bugs/1894667

Cc: stable@vger.kernel.org
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---

V2: correct Cc to stable

 drivers/acpi/video_detect.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 2499d7e..05047a3 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -282,6 +282,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "530U4E/540U4E"),
 		},
 	},
+	/* https://bugs.launchpad.net/bugs/1894667 */
+	{
+	 .callback = video_detect_force_video,
+	 .ident = "HP 635 Notebook",
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "HP 635 Notebook PC"),
+		},
+	},
 
 	/* Non win8 machines which need native backlight nevertheless */
 	{
-- 
2.7.4

Re: [PATCH][V2] ACPI: video: use ACPI backlight for HP 635 Notebook

[Sasha Levin]

Hi

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.8.9, v5.4.65, v4.19.145, v4.14.198, v4.9.236, v4.4.236.

v5.8.9: Build OK!
v5.4.65: Build OK!
v4.19.145: Build OK!
v4.14.198: Build OK!
v4.9.236: Build OK!
v4.4.236: Failed to apply! Possible dependencies:
    49eb5208220a ("ACPI / video: Add a quirk to force acpi-video backlight on SAMSUNG 530U4E/540U4E")


NOTE: The patch will not be queued to stable trees until it is upstream.

How should we proceed with this patch?

-- 
Thanks
Sasha

Re: [PATCH][V2] ACPI: video: use ACPI backlight for HP 635 Notebook

[Rafael J. Wysocki]

On Mon, Sep 14, 2020 at 12:34 AM Alex Hung <alex.hung@canonical.com> wrote:
>
> Default backlight interface is AMD's radeon_bl0 which does not work on
> this system. As a result, let's for ACPI backlight interface for this
> system.
>
> BugLink: https://bugs.launchpad.net/bugs/1894667
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>
> V2: correct Cc to stable
>
>  drivers/acpi/video_detect.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 2499d7e..05047a3 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -282,6 +282,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>                 DMI_MATCH(DMI_PRODUCT_NAME, "530U4E/540U4E"),
>                 },
>         },
> +       /* https://bugs.launchpad.net/bugs/1894667 */
> +       {
> +        .callback = video_detect_force_video,
> +        .ident = "HP 635 Notebook",
> +        .matches = {
> +               DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> +               DMI_MATCH(DMI_PRODUCT_NAME, "HP 635 Notebook PC"),
> +               },
> +       },
>
>         /* Non win8 machines which need native backlight nevertheless */
>         {
> --

Applied as 5.10 material, thanks!