From: Maximilian Luz <luzmaximilian@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Maximilian Luz <luzmaximilian@gmail.com>,
Mark Gross <mgross@linux.intel.com>, Len Brown <lenb@kernel.org>,
Mark Pearson <markpearson@lenovo.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/4] ACPI: platform: Hide ACPI_PLATFORM_PROFILE option
Date: Thu, 11 Feb 2021 21:17:00 +0100 [thread overview]
Message-ID: <20210211201703.658240-2-luzmaximilian@gmail.com> (raw)
In-Reply-To: <20210211201703.658240-1-luzmaximilian@gmail.com>
The ACPI_PLATFORM_PROFILE option essentially provides a library and not
really an independent module. Thus it seems to be more user-friendly to
hide this option and simply make drivers depending on it select it.
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
drivers/acpi/Kconfig | 16 +---------------
drivers/platform/x86/Kconfig | 4 ++--
2 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 5ddff93e38c2..030678965159 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -327,21 +327,7 @@ config ACPI_THERMAL
the module will be called thermal.
config ACPI_PLATFORM_PROFILE
- tristate "ACPI Platform Profile Driver"
- default m
- help
- This driver adds support for platform-profiles on platforms that
- support it.
-
- Platform-profiles can be used to control the platform behaviour. For
- example whether to operate in a lower power mode, in a higher
- power performance mode or between the two.
-
- This driver provides the sysfs interface and is used as the registration
- point for platform specific drivers.
-
- Which profiles are supported is determined on a per-platform basis and
- should be obtained from the platform specific driver.
+ tristate
config ACPI_CUSTOM_DSDT_FILE
string "Custom DSDT Table file to include"
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 56353e8c792a..ad4e630e73e2 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -450,7 +450,7 @@ config IDEAPAD_LAPTOP
depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on ACPI_WMI || ACPI_WMI = n
- depends on ACPI_PLATFORM_PROFILE
+ select ACPI_PLATFORM_PROFILE
select INPUT_SPARSEKMAP
select NEW_LEDS
select LEDS_CLASS
@@ -484,7 +484,7 @@ config THINKPAD_ACPI
depends on RFKILL || RFKILL = n
depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on BACKLIGHT_CLASS_DEVICE
- depends on ACPI_PLATFORM_PROFILE
+ select ACPI_PLATFORM_PROFILE
select HWMON
select NVRAM
select NEW_LEDS
--
2.30.0
next prev parent reply other threads:[~2021-02-11 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 20:16 [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices Maximilian Luz
2021-02-11 20:17 ` Maximilian Luz [this message]
2021-02-11 20:17 ` [PATCH v2 2/4] ACPI: platform: Fix file references in comment Maximilian Luz
2021-02-11 20:17 ` [PATCH v2 3/4] ACPI: platform: Add balanced-performance platform profile Maximilian Luz
2021-02-11 20:17 ` [PATCH v2 4/4] platform/surface: Add platform profile driver Maximilian Luz
2021-03-04 11:01 ` Hans de Goede
2021-02-12 15:29 ` [External] [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices Mark Pearson
2021-02-15 14:34 ` Hans de Goede
2021-02-15 14:54 ` Rafael J. Wysocki
2021-02-15 14:56 ` Hans de Goede
2021-02-15 15:22 ` Hans de Goede
2021-02-15 15:29 ` Rafael J. Wysocki
2021-02-15 16:36 ` Hans de Goede
2021-02-15 18:40 ` Rafael J. Wysocki
2021-02-24 14:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211201703.658240-2-luzmaximilian@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).