From: Hans de Goede <hdegoede@redhat.com>
To: Maximilian Luz <luzmaximilian@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Mark Gross <mgross@linux.intel.com>, Len Brown <lenb@kernel.org>,
Mark Pearson <markpearson@lenovo.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
platform-driver-x86@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices
Date: Mon, 15 Feb 2021 15:34:08 +0100 [thread overview]
Message-ID: <898aa498-8256-d59f-9e72-0e1199b3a62a@redhat.com> (raw)
In-Reply-To: <20210211201703.658240-1-luzmaximilian@gmail.com>
Hi,
On 2/11/21 9:16 PM, Maximilian Luz wrote:
> This series adds a driver to provide platform profile support on 5th-
> and later generation Microsoft Surface devices with a Surface System
> Aggregator Module. On those devices, the platform profile can be used to
> influence cooling behavior and power consumption.
>
> To achieve this, a new platform profile is introduced: the
> 'balanced-performance' profile.
>
> In addition, a couple of fix-ups are performed:
> - Hide CONFIG_ACPI_PLATFORM_PROFILE and change drivers so that it is
> selected instead of depended on.
> - Fix some references to documentation in a comment.
>
> Note: This series (or more specifically "platform/surface: Add platform
> profile driver") depends on the "platform/surface: Add Surface
> Aggregator device registry" series.
>
> Changes in v2:
> - Introduce new 'balanced-performance' platform profile and change
> profile mapping in driver.
> - Perform some fix-ups for the ACPI platform profile implementation:
> - Fix some references to documentation in a comment.
> - Hide CONFIG_ACPI_PLATFORM_PROFILE
Thanks, the entire series looks good to me, so for the series:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Rafael, can you (once 5.12-rc1 is out) pick 1-3/4 and then provide a
stable branch for me to merge?
Then I will pick up 4/4.
Regards,
Hans
>
> Maximilian Luz (4):
> ACPI: platform: Hide ACPI_PLATFORM_PROFILE option
> ACPI: platform: Fix file references in comment
> ACPI: platform: Add balanced-performance platform profile
> platform/surface: Add platform profile driver
>
> .../ABI/testing/sysfs-platform_profile | 18 +-
> MAINTAINERS | 6 +
> drivers/acpi/Kconfig | 16 +-
> drivers/acpi/platform_profile.c | 1 +
> drivers/platform/surface/Kconfig | 22 ++
> drivers/platform/surface/Makefile | 1 +
> .../surface/surface_platform_profile.c | 190 ++++++++++++++++++
> drivers/platform/x86/Kconfig | 4 +-
> include/linux/platform_profile.h | 6 +-
> 9 files changed, 237 insertions(+), 27 deletions(-)
> create mode 100644 drivers/platform/surface/surface_platform_profile.c
>
next prev parent reply other threads:[~2021-02-15 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 20:16 [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices Maximilian Luz
2021-02-11 20:17 ` [PATCH v2 1/4] ACPI: platform: Hide ACPI_PLATFORM_PROFILE option Maximilian Luz
2021-02-11 20:17 ` [PATCH v2 2/4] ACPI: platform: Fix file references in comment Maximilian Luz
2021-02-11 20:17 ` [PATCH v2 3/4] ACPI: platform: Add balanced-performance platform profile Maximilian Luz
2021-02-11 20:17 ` [PATCH v2 4/4] platform/surface: Add platform profile driver Maximilian Luz
2021-03-04 11:01 ` Hans de Goede
2021-02-12 15:29 ` [External] [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices Mark Pearson
2021-02-15 14:34 ` Hans de Goede [this message]
2021-02-15 14:54 ` Rafael J. Wysocki
2021-02-15 14:56 ` Hans de Goede
2021-02-15 15:22 ` Hans de Goede
2021-02-15 15:29 ` Rafael J. Wysocki
2021-02-15 16:36 ` Hans de Goede
2021-02-15 18:40 ` Rafael J. Wysocki
2021-02-24 14:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=898aa498-8256-d59f-9e72-0e1199b3a62a@redhat.com \
--to=hdegoede@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=markpearson@lenovo.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).