* [rafael-pm:linux-next 20/23] drivers/pci/pci-acpi.c:1127:12: warning: 'adev' is used uninitialized
@ 2021-09-29 4:25 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-09-29 4:25 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: kbuild-all, linux-acpi, devel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 5171 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
head: 5264d800ffd532b515f32ad3a3439b5611438157
commit: 9896a58cdd59a6454adeebbe10a881b05550e63a [20/23] PCI: ACPI: PM: Do not use pci_platform_pm_ops for ACPI
config: ia64-randconfig-r031-20210928 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=9896a58cdd59a6454adeebbe10a881b05550e63a
git remote add rafael-pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
git fetch --no-tags rafael-pm linux-next
git checkout 9896a58cdd59a6454adeebbe10a881b05550e63a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:153,
from include/linux/pgtable.h:6,
from arch/ia64/include/asm/uaccess.h:40,
from include/linux/uaccess.h:11,
from arch/ia64/include/asm/sections.h:11,
from include/linux/interrupt.h:21,
from include/linux/pci.h:38,
from drivers/pci/pci-acpi.c:13:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
drivers/pci/pci-acpi.c: In function 'acpi_pci_need_resume':
>> drivers/pci/pci-acpi.c:1127:12: warning: 'adev' is used uninitialized [-Wuninitialized]
1127 | if (!adev || !acpi_device_power_manageable(adev))
| ^
vim +/adev +1127 drivers/pci/pci-acpi.c
b67ea76172d4b19 Rafael J. Wysocki 2010-02-17 1109
9896a58cdd59a64 Rafael J. Wysocki 2021-09-20 1110 bool acpi_pci_need_resume(struct pci_dev *dev)
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1111 {
9896a58cdd59a64 Rafael J. Wysocki 2021-09-20 1112 struct acpi_device *adev;
9896a58cdd59a64 Rafael J. Wysocki 2021-09-20 1113
9896a58cdd59a64 Rafael J. Wysocki 2021-09-20 1114 if (acpi_pci_disabled)
9896a58cdd59a64 Rafael J. Wysocki 2021-09-20 1115 return false;
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1116
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1117 /*
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1118 * In some cases (eg. Samsung 305V4A) leaving a bridge in suspend over
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1119 * system-wide suspend/resume confuses the platform firmware, so avoid
9d64b539b738fc1 Rafael J. Wysocki 2018-08-16 1120 * doing that. According to Section 16.1.6 of ACPI 6.2, endpoint
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1121 * devices are expected to be in D3 before invoking the S3 entry path
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1122 * from the firmware, so they should not be affected by this issue.
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1123 */
9d64b539b738fc1 Rafael J. Wysocki 2018-08-16 1124 if (pci_is_bridge(dev) && acpi_target_system_state() != ACPI_STATE_S0)
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1125 return true;
26112ddc254c986 Rafael J. Wysocki 2018-06-30 1126
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 @1127 if (!adev || !acpi_device_power_manageable(adev))
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1128 return false;
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1129
9896a58cdd59a64 Rafael J. Wysocki 2021-09-20 1130 adev = ACPI_COMPANION(&dev->dev);
9a51c6b1f9e0239 Rafael J. Wysocki 2019-05-16 1131 if (adev->wakeup.flags.valid &&
9a51c6b1f9e0239 Rafael J. Wysocki 2019-05-16 1132 device_may_wakeup(&dev->dev) != !!adev->wakeup.prepare_count)
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1133 return true;
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1134
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1135 if (acpi_target_system_state() == ACPI_STATE_S0)
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1136 return false;
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1137
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1138 return !!adev->power.flags.dsw_present;
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1139 }
bac2a909a096c91 Rafael J. Wysocki 2015-01-21 1140
:::::: The code at line 1127 was first introduced by commit
:::::: bac2a909a096c9110525c18cbb8ce73c660d5f71 PCI / PM: Avoid resuming PCI devices during system suspend
:::::: TO: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26622 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-29 4:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-29 4:25 [rafael-pm:linux-next 20/23] drivers/pci/pci-acpi.c:1127:12: warning: 'adev' is used uninitialized kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).