From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Robert Moore <robert.moore@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RFC PATCH 0/2] acpi: add support for CXL _OSC
Date: Thu, 17 Mar 2022 15:19:38 +0000 [thread overview]
Message-ID: <20220317151938.000042e9@Huawei.com> (raw)
In-Reply-To: <20220317002704.1835870-1-vishal.l.verma@intel.com>
On Wed, 16 Mar 2022 18:27:02 -0600
Vishal Verma <vishal.l.verma@intel.com> wrote:
> Add support for using the CXL definition of _OSC where applicable, and
> negotiating CXL specific support and control bits.
>
> Patch 1 adds the new CXL _OSC UUID, and uses it instead of the PCI UUID
> when a root port is CXL enabled. It provides a fallback method for
> CXL-1.1 devices that may not implement the CXL-2.0 _OSC.
_OSC is implemented by the firmware of a host not the device so perhaps
rephrase this.
>
> Patch 2 performs negotiation for the CXL specific _OSC support and
> control bits.
>
> I've tested these against a custom qemu[1], which adds the CXL _OSC (in
> addition to other CXL support). Specifically, _OSC support is added
> here[2].
>
> [1]: https://gitlab.com/jic23/qemu/-/tree/cxl-v7-draft-2-for-test
> [2]: https://gitlab.com/jic23/qemu/-/commit/31c85054b84645dfbd9e9bb14aa35286141c14cf
Glad that worked :) I was wondering if it was correct.
There are some issues with that code raised in a recent review, so good
to have this to test against it going forwards.
Thanks,
Jonathan
>
> Dan Williams (1):
> PCI/ACPI: Use CXL _OSC instead of PCIe _OSC
>
> Vishal Verma (1):
> acpi/pci_root: negotiate CXL _OSC
>
> include/linux/acpi.h | 11 +++
> include/acpi/acpi_bus.h | 7 +-
> drivers/acpi/pci_root.c | 201 ++++++++++++++++++++++++++++++++++------
> 3 files changed, 187 insertions(+), 32 deletions(-)
>
>
> base-commit: 74be98774dfbc5b8b795db726bd772e735d2edd4
next prev parent reply other threads:[~2022-03-17 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 0:27 [RFC PATCH 0/2] acpi: add support for CXL _OSC Vishal Verma
2022-03-17 0:27 ` [RFC PATCH 1/2] PCI/ACPI: Use CXL _OSC instead of PCIe _OSC Vishal Verma
2022-03-17 1:47 ` Dan Williams
2022-03-17 15:40 ` Jonathan Cameron
2022-03-17 0:27 ` [RFC PATCH 2/2] acpi/pci_root: negotiate CXL _OSC Vishal Verma
2022-03-17 3:19 ` Dan Williams
2022-03-17 3:49 ` Verma, Vishal L
2022-03-17 16:10 ` Jonathan Cameron
2022-03-18 21:16 ` Verma, Vishal L
2022-03-17 15:19 ` Jonathan Cameron [this message]
2022-03-18 19:52 ` [RFC PATCH 0/2] acpi: add support for " Verma, Vishal L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220317151938.000042e9@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).